fix: rely on jdbc4 datasource validation

Author: gpascucci

.env.example

@@ -5,10 +5,9 @@ ILCR_SECURITY_ENABLED=false
 
 # Local Oracle dev DB. Keep real local credentials in ignored .env only.
 # Leave ILCR_DATASOURCE_ENABLED=false for the in-memory scaffold.
-# In Docker Compose, set ILCR_DATASOURCE_ENABLED=true to validate Oracle on startup.
+# In Docker Compose, set ILCR_DATASOURCE_ENABLED=true to enable Oracle connectivity.
 # For direct Maven runs, the oracle profile also enables the datasource.
 ILCR_DATASOURCE_ENABLED=false
-ILCR_DATASOURCE_VALIDATION_QUERY=SELECT 1 FROM DUAL
 SPRING_DATASOURCE_URL=jdbc:oracle:thin:@//<host>:1521/<service-name>
 SPRING_DATASOURCE_USERNAME=<username>
 SPRING_DATASOURCE_PASSWORD=<password>

backend/src/main/java/ca/bc/gov/nrs/ilcr/configuration/DataSourceConfiguration.java

@@ -35,8 +35,7 @@ public DataSource dataSource(
             @Value("${spring.datasource.hikari.max-lifetime:180000}") long maxLifetime,
             @Value("${spring.datasource.hikari.keepalive-time:60000}") long keepaliveTime,
             @Value("${spring.datasource.hikari.initialization-fail-timeout:-1}") long initializationFailTimeout,
-            @Value("${spring.datasource.hikari.leak-detection-threshold:60000}") long leakDetectionThreshold,
-            @Value("${ilcr.datasource.validation-query:SELECT 1 FROM DUAL}") String validationQuery
+            @Value("${spring.datasource.hikari.leak-detection-threshold:60000}") long leakDetectionThreshold
     ) {
         requireProperty("spring.datasource.url", url);
         requireProperty("spring.datasource.username", username);
@@ -56,7 +55,6 @@ public DataSource dataSource(
         config.setKeepaliveTime(keepaliveTime);
         config.setInitializationFailTimeout(initializationFailTimeout);
         config.setLeakDetectionThreshold(leakDetectionThreshold);
-        config.setConnectionTestQuery(validationQuery);
 
         return new HikariDataSource(config);
     }

backend/src/main/resources/application.yml

@@ -55,7 +55,6 @@ ilcr:
     enabled: ${ILCR_SECURITY_ENABLED:true}
   datasource:
     enabled: ${ILCR_DATASOURCE_ENABLED:true}
-    validation-query: ${ILCR_DATASOURCE_VALIDATION_QUERY:SELECT 1 FROM DUAL}
 
 features:
   flags:

docker-compose.yml

@@ -13,7 +13,6 @@ services:
       LOG_LEVEL: INFO
       ILCR_SECURITY_ENABLED: ${ILCR_SECURITY_ENABLED:-false}
       ILCR_DATASOURCE_ENABLED: ${ILCR_DATASOURCE_ENABLED:-false}
-      ILCR_DATASOURCE_VALIDATION_QUERY: ${ILCR_DATASOURCE_VALIDATION_QUERY:-SELECT 1 FROM DUAL}
       SPRING_DATASOURCE_URL: ${SPRING_DATASOURCE_URL:-}
       SPRING_DATASOURCE_USERNAME: ${SPRING_DATASOURCE_USERNAME:-}
       SPRING_DATASOURCE_PASSWORD: ${SPRING_DATASOURCE_PASSWORD:-}