fix(schedule6): import groupInput — the blur re-mask shipped inert (#291)

CI surfaced 16 Vitest unhandled errors, all one root cause: `commitRate` called
`groupInput` without importing it, so every blur threw a ReferenceError. The
throw landed AFTER `apply(rateInputsOf(form))`, so the rate itself updated and
the defect-291 fix looked correct in manual testing — only the re-mask was lost,
leaving `50000` unmasked beside a freshly formatted rate.

Nothing caught it. `tsc --noEmit` aborts on this repo's tsconfig (TS5107/TS6310)
before reading a single source file; eslint has no-undef off for TS, as standard;
and vite build uses esbuild, which does not type-check. An unhandled error in a
React event handler fails no test, so the suite stayed green.

Three failure-path assertions expected the unmasked value — they had encoded the
broken behaviour. Grouping on blur is the established convention here (schedule9,
schedule1OtherCosts, CommaNumberInput all assert it), so the expectations were
stale, not the fix.

Also adds a test that asserts the FIELD, not just the rate — mutation-verified to
fail with the original ReferenceError when the import is removed.

Separately, OtherAcceptableSubtotal becomes a type alias: Schedule3SubPage's
deriveSummary prop is `=> Readonly<Record<string, number | null>>` and TypeScript
grants an implicit index signature to a type alias but never to an interface.
That was a second error the broken type-check hid. Verified against an
origin/main baseline: zero type-error regressions in any file this branch
touches.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: Rylan-cgi

frontend/src/components/schedule3OtherAcceptableCosts/derived.ts

@@ -20,8 +20,16 @@ import { committedNum, sumAsZero, wholeDollars } from '@/utils/derivedMath'
  * unit test of its own — it was the only new figure in that batch pinned by nothing.
  */
 
-/** The footer triple, keyed so it cannot be mis-paired with the summary labels positionally. */
-export interface OtherAcceptableSubtotal {
+/**
+ * The footer triple, keyed so it cannot be mis-paired with the summary labels positionally.
+ *
+ * `type`, NOT `interface`: `Schedule3SubPage`'s `deriveSummary` prop is typed
+ * `=> Readonly<Record<string, number | null>>` because it looks the triple up by key, and TypeScript
+ * grants an implicit index signature to a type alias but never to an interface. As an interface this
+ * assignment does not type-check — and it shipped that way, because `tsc --noEmit` aborts on this
+ * repo's tsconfig before reading a single source file (see deferred-work.md).
+ */
+export type OtherAcceptableSubtotal = {
   readonly harvest: number | null
   readonly pop: number | null
   readonly crown: number | null

frontend/src/components/schedule6/__tests__/Schedule6.test.tsx

@@ -209,6 +209,38 @@ describe('Schedule 6 page (Story 8.3)', () => {
     expect(rateIn(rowPanel(1))).toBe('') // the mask renders a blank, not an em dash
   })
 
+  test('the same blur re-applies the comma mask to the field itself (#291)', async () => {
+    // Legacy's handlers re-rendered the INPUT alongside the rate (`render="vol cal ..."`,
+    // schedule6.xhtml:153,163,364,383), which re-ran the converter and put the mask back. Schedule 6
+    // is the only page whose blur moves a derived cell, so it was the only one that could leave
+    // `50000` sitting unmasked next to a freshly-formatted rate.
+    //
+    // This test exists because that re-mask shipped INERT: `commitRate` called `groupInput` without
+    // importing it, so every blur threw a ReferenceError *after* the rate had been applied. The rate
+    // updated, the mask never came back, and the throw surfaced only as a Vitest unhandled error --
+    // which fails no test. Assert the field, not just the rate.
+    server.use(http.get(URL, () => HttpResponse.json(doc())))
+    render(<Schedule6 />)
+    const user = userEvent.setup()
+
+    await screen.findByRole('button', { name: 'Road Maintenance report Id: 1' })
+    await user.click(within(rowPanel(1)).getByRole('button', { name: /^edit$/i }))
+
+    const volume = within(rowPanel(1)).getByLabelText('Volume m³')
+    await user.clear(volume)
+    await user.type(volume, '1000000')
+    expect(volume).toHaveValue('1000000') // mid-entry: untouched, so the caret is not moved
+    await user.tab()
+    expect(within(rowPanel(1)).getByLabelText('Volume m³')).toHaveValue('1,000,000')
+
+    const cost = within(rowPanel(1)).getByLabelText('Cost $')
+    await user.clear(cost)
+    await user.type(cost, '2500000')
+    await user.tab()
+    expect(within(rowPanel(1)).getByLabelText('Cost $')).toHaveValue('2,500,000')
+    expect(rateIn(rowPanel(1))).toBe('2.50') // 2,500,000 / 1,000,000
+  })
+
   test('the footer totals do NOT move during entry — legacy left them until Save (#291)', async () => {
     // The deliberate boundary: totalVol/totalCos/totalCal appear in NO legacy render or update
     // target, so refreshing them from the document is already faithful and they are not mirrored.
@@ -1172,7 +1204,7 @@ describe('Schedule 6 page (Story 8.3)', () => {
     // Values stay put so the entry can be corrected and resubmitted.
     expect(within(panel).getByLabelText('TSA or TFL')).toHaveValue('TFL')
     expect(within(panel).getByLabelText('TFL')).toHaveValue('99')
-    expect(within(panel).getByLabelText('Volume m³')).toHaveValue('1000')
+    expect(within(panel).getByLabelText('Volume m³')).toHaveValue('1,000')
   })
 
   test('a load failure carrying no detail falls back to the generic load message (AC7)', async () => {
@@ -1205,7 +1237,7 @@ describe('Schedule 6 page (Story 8.3)', () => {
     expect(await screen.findByText('Schedule could not be saved.')).toBeInTheDocument()
     // add-is-save: the panel and its values survive a server-side failure so the entry is not retyped.
     expect(screen.getByRole('region', { name: 'Add Road Maintenance report' })).toBeInTheDocument()
-    expect(within(panel).getByLabelText('Volume m³')).toHaveValue('1000')
+    expect(within(panel).getByLabelText('Volume m³')).toHaveValue('1,000')
   })
 
   test('an edit failure renders the detail verbatim and leaves the editor open (AC4 / AC10)', async () => {
@@ -1227,7 +1259,7 @@ describe('Schedule 6 page (Story 8.3)', () => {
     expect(await screen.findByText(detail)).toBeInTheDocument()
     // The failure branch must not run onSuccess: the editor stays open holding the rejected value so
     // it can be corrected, page state is not replaced, and no success banner appears alongside.
-    expect(within(rowPanel(1)).getByLabelText('Volume m³')).toHaveValue('2000')
+    expect(within(rowPanel(1)).getByLabelText('Volume m³')).toHaveValue('2,000')
     expect(screen.queryByText('Data saved successfully')).not.toBeInTheDocument()
     // The in-flight lock releases on the error path too, or Save is dead until reload.
     await waitFor(() =>

frontend/src/components/schedule6/index.tsx

@@ -18,7 +18,7 @@ import apiService from '@/service/api-service'
 import { useScheduleContextGuard } from '@/hooks/useScheduleContextGuard'
 import { useScheduleDocument } from '@/hooks/useScheduleDocument'
 import { extractDetail } from '@/utils/error'
-import { numStr } from '@/utils/number'
+import { groupInput, numStr } from '@/utils/number'
 import LoadingScreen from '@/components/core/LoadingScreen'
 import NotificationColumn from '@/components/core/NotificationColumn'
 import PageState from '@/components/core/PageState'