test(schedule10): Story 11.2 Task 9 — verify, fix a shared-sequence collision, clear checkstyle

Verification gate for Story 11.2 (Schedule 10 write path + Check Status):
1148 unit + 865 integration tests, 0 failures; 0 checkstyle violations in
schedule10 (1234 pre-existing elsewhere left untouched).

Repair a latent CROSS-SCHEDULE collision, not a Schedule 10 bug. V33 seeds
ILCR_COST_REPORT_DETAIL ids 9500-9506, above the SHARED
ILCR_COST_REPORT_DETAIL_SEQ start of 9000. Nothing had consumed 500 values in
one suite before, so it stayed latent; Schedule 10 writes twelve cost rows per
road detail (Schedule 6 writes 1, 7A/7B about 2) and was the first to push past
9500, failing seven Schedule 6/7A ITs with DuplicateKeyException. V20260818 now
restarts the shared sequence at 10000, following the V21 precedent, after
confirming no test pins a generated cost-detail id in 9000-9599.

Add Schedule10RequestValidationTest (24 tests) pinning the constraint-to-bundle-key
pairing for both write requests: the schedule10TsaOrTflRequiredErrorMsg vs
Schedule 6 decoy key, the sub-grade-100 / stabilizing-999.999 length asymmetry
from both sides, the two distinct cost bands, and the deliberate absence of
@digits. Written green as characterization, not red-phase.

Re-wrap javadoc and comments across 19 schedule10 sources to clear 119
checkstyle violations. Comment-only: all 33 package sources were compared
against HEAD with comments stripped and whitespace removed and are
token-identical, so the integration run stands as evidence for the production
code.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: Rylan-cgi

backend/src/main/java/ca/bc/gov/nrs/ilcr/schedule10/InvalidBecClassificationException.java

@@ -2,12 +2,12 @@
 
 /**
  * Raised when a road-detail write names a BEC classification the cross-reference does not offer, or
- * when that classification plus the RSMR class resolves to no moisture-code pair at all. Maps to 400
- * with legacy's own {@code invalidBiogeoCode} text.
+ * when that classification plus the RSMR class resolves to no moisture-code pair at all. Maps to
+ * 400 with legacy's own {@code invalidBiogeoCode} text.
  *
- * <p>Two distinct causes, one message, because legacy uses this same string for both: its Check Status
- * emits it when a stored BEC id is outside the allowable filtered list, and its autocomplete refuses a
- * typed value that resolves to nothing.
+ * <p>Two distinct causes, one message, because legacy uses this same string for both: its Check
+ * Status emits it when a stored BEC id is outside the allowable filtered list, and its autocomplete
+ * refuses a typed value that resolves to nothing.
  *
  * <p>The zero-candidate case matters for the write path specifically: the two moisture codes are
  * derived from this classification and the RSMR class, and both target columns are {@code NOT NULL}

backend/src/main/java/ca/bc/gov/nrs/ilcr/schedule10/InvalidTflNumberException.java

@@ -5,12 +5,13 @@
 
 /**
  * Raised when a TFL-located page carries a TFL number the reference table does not hold, after the
- * missing-leading-zero aliases have been applied. Maps to 400 with legacy's verbatim validator text.
+ * missing-leading-zero aliases have been applied. Maps to 400 with legacy's verbatim validator
+ * text.
  *
- * <p>Because the accept set and the Road-Group-derivable set are the same 22 keys, a TFL that passes
- * this check always derives a Road Group — so the "unmapped TFL saves with a blank Road Group" state
- * is unreachable through a write, in this application and in legacy alike. It exists only in stored
- * data that predates or bypassed the screen.
+ * <p>Because the accept set and the Road-Group-derivable set are the same 22 keys, a TFL that
+ * passes this check always derives a Road Group — so the "unmapped TFL saves with a blank Road
+ * Group" state is unreachable through a write, in this application and in legacy alike. It exists
+ * only in stored data that predates or bypassed the screen.
  */
 public class InvalidTflNumberException extends BusinessException {
 

backend/src/main/java/ca/bc/gov/nrs/ilcr/schedule10/RevisionCountRequiredException.java

@@ -7,12 +7,12 @@
  * Raised when an UPDATE reaches the service without its optimistic-lock token. Maps to 400.
  *
  * <p>Bean Validation already enforces this through the {@code OnUpdate} group, so this is the
- * belt-and-braces guard for any path that reaches the service without that group applied. Without it
- * the token would be unboxed from null and NPE into a 500.
+ * belt-and-braces guard for any path that reaches the service without that group applied. Without
+ * it the token would be unboxed from null and NPE into a 500.
  *
- * <p>Deliberately a 400 rather than a coerced 409: substituting a sentinel like {@code -1} matches no
- * row, so the optimistic-lock UPDATE misses and the user is told another user changed the row when the
- * real fix is to send the token. Several older schedules coerce; this one does not.
+ * <p>Deliberately a 400 rather than a coerced 409: substituting a sentinel like {@code -1} matches
+ * no row, so the optimistic-lock UPDATE misses and the user is told another user changed the row
+ * when the real fix is to send the token. Several older schedules coerce; this one does not.
  */
 public class RevisionCountRequiredException extends BusinessException {
 

backend/src/main/java/ca/bc/gov/nrs/ilcr/schedule10/RoadGroup10Lookup.java

@@ -87,19 +87,19 @@ static String rmgFor(String tsaNumber, String tsbNumberCode, String tflNumberCod
   /**
    * The storable form of an entered TFL number, or {@code null} when it is not a valid TFL.
    *
-   * <p>Legacy's validator ({@code ILCRTflNumberValidator:33-45}) accepts a TFL if the lookup resolves
-   * it directly, or if it resolves after applying the missing-leading-zero aliases
-   * ({@code RoadGroupUtil.translateNoLeadingZeroButNumberMatch} :202-215). It validates the alias but
-   * then stores the raw entry, which leaves an accepted value in a form the reference table does not
+   * <p>Legacy's validator ({@code ILCRTflNumberValidator:33-45}) accepts a TFL if the lookup
+   * resolves it directly, or if it resolves after applying the missing-leading-zero aliases ({@code
+   * RoadGroupUtil.translateNoLeadingZeroButNumberMatch} :202-215). It validates the alias but then
+   * stores the raw entry, which leaves an accepted value in a form the reference table does not
    * hold; this returns the canonical form so the stored value is the one that resolves.
    *
    * <p><strong>On which table validates.</strong> The legacy validator calls Schedule <em>6</em>'s
-   * lookup even for this screen. That reads like a defect, but the two tables accept an identical set
-   * of 22 keys — verified by diffing the {@code case} labels of both methods — so validating here
-   * against Schedule 10's own table accepts and rejects exactly what legacy does. Only the returned
-   * Road Group values differ between the tables, which is what this class exists to keep separate.
-   * The cross-wiring is still worth reporting upstream: the tables are maintained independently, so a
-   * future edit to either would silently split validation from derivation.
+   * lookup even for this screen. That reads like a defect, but the two tables accept an identical
+   * set of 22 keys — verified by diffing the {@code case} labels of both methods — so validating
+   * here against Schedule 10's own table accepts and rejects exactly what legacy does. Only the
+   * returned Road Group values differ between the tables, which is what this class exists to keep
+   * separate. The cross-wiring is still worth reporting upstream: the tables are maintained
+   * independently, so a future edit to either would silently split validation from derivation.
    *
    * @param tflNumberCode the entered TFL number, possibly missing a leading zero
    * @return the canonical TFL to store, or {@code null} when the value is not a valid TFL

backend/src/main/java/ca/bc/gov/nrs/ilcr/schedule10/Schedule10CheckStatus.java

@@ -21,39 +21,40 @@
  * (:32-339).
  *
  * <p><strong>It evaluates the assembled document, not the database.</strong> Legacy validates its
- * loaded domain object, so this takes the same input — which means Check Status sees exactly what the
- * GET serves, needs no queries of its own, and can be unit-tested from a hand-built document. It also
- * puts the derived totals within reach: several rules check {@code Total Costs}, {@code Total} and
- * {@code $/km}, which exist only as derived values.
+ * loaded domain object, so this takes the same input — which means Check Status sees exactly what
+ * the GET serves, needs no queries of its own, and can be unit-tested from a hand-built document.
+ * It also puts the derived totals within reach: several rules check {@code Total Costs}, {@code
+ * Total} and {@code $/km}, which exist only as derived values.
  *
  * <p><strong>Emission order is contractual.</strong> Rules run page-by-page, and within a page the
  * three page-level rules come before the per-road ones, in the order legacy declares them. The
  * ordinals that appear in the composed text are positional, so a reordering would silently renumber
  * the user's error list.
  *
  * <p>This class resolves no text. It emits bundle keys plus pre-formatted arguments and the label
- * prefix; the controller performs the single concatenation {@code label + ": " + resolvedText}, so the
- * verbatim byte composition lives in exactly one place.
+ * prefix; the controller performs the single concatenation {@code label + ": " + resolvedText}, so
+ * the verbatim byte composition lives in exactly one place.
  *
  * <p><strong>Legacy quirks preserved deliberately</strong> — each is reproduced, not corrected:
  * <ul>
- *   <li>{@code Road Name} and {@code Sub Zone} are titled with the PAGE label only, so on a page with
- *       several roads the user cannot tell which road is at fault.</li>
- *   <li>{@code Sub Zone} has no control anywhere on the screen; it is populated only on read from the
- *       catalogue row.</li>
- *   <li>{@code Material Type Total (%)} is reported whenever the five percentages do not total 100 —
- *       including when all five are blank, because the legacy total coerces nulls to zero and is
+ *   <li>{@code Road Name} and {@code Sub Zone} are titled with the PAGE label only, so on a page
+ *       with several roads the user cannot tell which road is at fault.</li>
+ *   <li>{@code Sub Zone} has no control anywhere on the screen; it is populated only on read from
+ *       the catalogue row.</li>
+ *   <li>{@code Material Type Total (%)} is reported whenever the five percentages do not total 100
+ *       — including when all five are blank, because the legacy total coerces nulls to zero and is
  *       therefore never absent.</li>
- *   <li>Additional-stabilizing transfers are checked against a floor of ZERO here while the entry form
- *       accepts negatives, so a value the form allowed can be reported as out of range.</li>
- *   <li>{@code Region}, {@code Road Type} and {@code Ballast Method Code} are required on the form but
- *       checked NOWHERE here.</li>
- *   <li>End Haul and Overland figures are checked nowhere — those rules are commented out in legacy.</li>
- *   <li>Both range bounds are formatted with the LOWER bound's pattern; legacy accepts an upper pattern
- *       and then ignores it.</li>
- *   <li>Label drift against the screen is kept as legacy writes it: {@code Ripple Rock} for the screen's
- *       "Rippable Rock", {@code Less Landing} singular, {@code Less Other Eng}, and a lower-case
- *       {@code total} in one stabilizing label.</li>
+ *   <li>Additional-stabilizing transfers are checked against a floor of ZERO here while the entry
+ *       form accepts negatives, so a value the form allowed can be reported as out of range.</li>
+ *   <li>{@code Region}, {@code Road Type} and {@code Ballast Method Code} are required on the form
+ *       but checked NOWHERE here.</li>
+ *   <li>End Haul and Overland figures are checked nowhere — those rules are commented out in
+ *       legacy.</li>
+ *   <li>Both range bounds are formatted with the LOWER bound's pattern; legacy accepts an upper
+ *       pattern and then ignores it.</li>
+ *   <li>Label drift against the screen is kept as legacy writes it: {@code Ripple Rock} for the
+ *       screen's "Rippable Rock", {@code Less Landing} singular, {@code Less Other Eng}, and a
+ *       lower-case {@code total} in one stabilizing label.</li>
  * </ul>
  *
  * <p>Two deliberate departures: the Boulder Area rule is dropped, because that field is removed by
@@ -78,8 +79,8 @@ final class Schedule10CheckStatus {
   /** Ballast method requiring the additional-stabilizing figures and a material type. */
   private static final String BALLAST_CRUSHED = "C";
 
-  // Legacy number patterns, transcribed per rule. Formatting is applied mechanically so the rendered
-  // bounds are whatever the pattern produces, exactly as legacy renders them.
+  // Legacy number patterns, transcribed per rule. Formatting is applied mechanically so the
+  // rendered bounds are whatever the pattern produces, exactly as legacy renders them.
   private static final String FMT_INT = "###";
   private static final String FMT_3DP = "###.###";
   private static final String FMT_1DP = "###.#";
@@ -97,7 +98,9 @@ final class Schedule10CheckStatus {
   private Schedule10CheckStatus() {
   }
 
-  /** One outstanding requirement: the machine field, its label prefix, and an unresolved message. */
+  /**
+   * One outstanding requirement: the machine field, its label prefix, and an unresolved message.
+   */
   record Issue(String field, String label, String messageKey, List<String> args) {
   }
 
@@ -182,8 +185,8 @@ static DetailOutcome evaluateRoadDetail(
     requirePresent(
         issues, "subzone", pagePrefix + " Sub Zone", bec == null ? null : bec.subzone());
 
-    // Legacy dereferences the classification and its id without a guard, so one road detail holding a
-    // null foreign key aborts the entire check before any message is emitted. Reported instead.
+    // Legacy dereferences the classification and its id without a guard, so one road detail holding
+    // a null foreign key aborts the entire check before any message is emitted. Reported instead.
     if (bec == null || !allowableBec.contains(bec.biogeoclimaticCatalogueId())) {
       issues.add(new Issue("becClassification", prefix + " BEC Zone", MSG_BEC, List.of()));
     }
@@ -217,12 +220,14 @@ static DetailOutcome evaluateRoadDetail(
     requireRange(issues, "subGradeActualCost", prefix + " Sub-Grade: Actual Cost ($)",
         field(subGrade, SubGrade::actualCost), ZERO, FMT_MONEY, SEVEN_DIGITS, false);
     requireRange(issues, "subGradeTtTransfer", prefix + " Sub-Grade: TtT Transfer ($)",
-        field(subGrade, SubGrade::ttTransfer), SEVEN_DIGITS.negate(), FMT_MONEY, SEVEN_DIGITS, false);
+        field(subGrade, SubGrade::ttTransfer), SEVEN_DIGITS.negate(), FMT_MONEY, SEVEN_DIGITS,
+        false);
     requireRange(issues, "subGradeOtherTransfer", prefix + " Sub-Grade: Other Transfer ($)",
         field(subGrade, SubGrade::otherTransfer), SEVEN_DIGITS.negate(), FMT_MONEY, SEVEN_DIGITS,
         false);
     requireRange(issues, "subGradeTotalCosts", prefix + " Sub-Grade: Total Costs ($)",
-        field(subGrade, SubGrade::totalCosts), EIGHT_DIGITS.negate(), FMT_MONEY, EIGHT_DIGITS, false);
+        field(subGrade, SubGrade::totalCosts), EIGHT_DIGITS.negate(), FMT_MONEY, EIGHT_DIGITS,
+        false);
     requireRange(issues, "lessBridges", prefix + " Sub-Grade: Less Bridges ($)",
         field(subGrade, SubGrade::lessBridges), ZERO, FMT_MONEY, SEVEN_DIGITS, false);
     requireRange(issues, "lessCulverts", prefix + " Sub-Grade: Less Culverts ($)",
@@ -236,13 +241,15 @@ static DetailOutcome evaluateRoadDetail(
     requireRange(issues, "lessOtherEng", prefix + " Sub-Grade: Less Other Eng ($)",
         field(subGrade, SubGrade::lessOtherEng), ZERO, FMT_MONEY, SEVEN_DIGITS, false);
     requireRange(issues, "subGradeTotal", prefix + " Sub-Grade: Total ($)",
-        field(subGrade, SubGrade::total), EIGHT_DIGITS.negate(), FMT_MONEY_2DP, EIGHT_DIGITS, false);
-    requireRange(issues, "subGradeCostPerLength", prefix + " Sub-Grade: $/km",
-        field(subGrade, SubGrade::costPerLength), EIGHT_DIGITS.negate(), FMT_MONEY_2DP, EIGHT_DIGITS,
+        field(subGrade, SubGrade::total), EIGHT_DIGITS.negate(), FMT_MONEY_2DP, EIGHT_DIGITS,
         false);
+    requireRange(issues, "subGradeCostPerLength", prefix + " Sub-Grade: $/km",
+        field(subGrade, SubGrade::costPerLength), EIGHT_DIGITS.negate(), FMT_MONEY_2DP,
+        EIGHT_DIGITS, false);
 
     Stabilizing stabilizing = detail.stabilizing();
-    boolean crushed = stabilizing != null && BALLAST_CRUSHED.equals(stabilizing.ballastMethodCode());
+    boolean crushed =
+        stabilizing != null && BALLAST_CRUSHED.equals(stabilizing.ballastMethodCode());
 
     requireRange(issues, "stabilizingLength", prefix + " Additional Stabilizing: Length (km)",
         field(stabilizing, Stabilizing::length), ZERO, FMT_3DP, new BigDecimal("999.999"), crushed);
@@ -251,7 +258,8 @@ static DetailOutcome evaluateRoadDetail(
         field(stabilizing, Stabilizing::surfaceWidth), ZERO, FMT_1DP, new BigDecimal("999.9"),
         crushed);
     requireRange(issues, "stabilizingDepth", prefix + " Additional Stabilizing: Depth (m)",
-        field(stabilizing, Stabilizing::depth), ZERO, FMT_2DP_SMALL, new BigDecimal("99.9"), crushed);
+        field(stabilizing, Stabilizing::depth), ZERO, FMT_2DP_SMALL, new BigDecimal("99.9"),
+        crushed);
     requireRange(issues, "stabilizingDistanceToSource",
         prefix + " Additional Stabilizing: Distance to Source (km)",
         field(stabilizing, Stabilizing::distanceToSource), ZERO, FMT_1DP, new BigDecimal("999.9"),
@@ -267,8 +275,8 @@ static DetailOutcome evaluateRoadDetail(
     requireRange(issues, "stabilizingActualCost",
         prefix + " Additional Stabilizing: Actual Cost ($)",
         stabilizing.actualCost(), ZERO, FMT_MONEY, SEVEN_DIGITS, true);
-    // Floor of ZERO, while the entry form accepts down to -9,999,999 for both transfers. A value the
-    // form allowed is therefore reported here. Legacy carries the same disagreement.
+    // Floor of ZERO, while the entry form accepts down to -9,999,999 for both transfers. A value
+    // the form allowed is therefore reported here. Legacy carries the same disagreement.
     requireRange(issues, "stabilizingTtTransfer",
         prefix + " Additional Stabilizing: TtT Transfer ($)",
         stabilizing.ttTransfer(), ZERO, FMT_MONEY, SEVEN_DIGITS, true);
@@ -292,13 +300,13 @@ private static void requirePresent(
   }
 
   /**
-   * The legacy numeric rule: an absent optional value passes, an absent required value is reported as
-   * missing, and otherwise the value must sit inside the inclusive range.
+   * The legacy numeric rule: an absent optional value passes, an absent required value is reported
+   * as missing, and otherwise the value must sit inside the inclusive range.
    *
    * <p>When both bounds are identical the must-equal message is used with a single argument. Legacy
    * reaches that branch by comparing the two bounds by REFERENCE, which happens to work for the one
-   * rule that uses it because small boxed integers are cached; numeric equality is used here instead,
-   * which agrees for every rule in this schedule and does not depend on that accident.
+   * rule that uses it because small boxed integers are cached; numeric equality is used here
+   * instead, which agrees for every rule in this schedule and does not depend on that accident.
    */
   private static void requireRange(
       List<Issue> issues, String field, String label, BigDecimal value,
@@ -324,8 +332,8 @@ private static void requireRange(
    * Renders a bound with its pattern.
    *
    * <p>Both bounds use the LOWER bound's pattern: legacy accepts an upper pattern and then never
-   * applies it. Symbols are pinned to a fixed locale so the rendered separators cannot drift with the
-   * server's default.
+   * applies it. Symbols are pinned to a fixed locale so the rendered separators cannot drift with
+   * the server's default.
    */
   private static String format(BigDecimal bound, String pattern) {
     DecimalFormat format =