Skip to content

feat: Homepage implementation backend - #22

Merged
ConradBoydElliottGustafson merged 6 commits into
mainfrom
homepage-implementation
Jul 23, 2026
Merged

feat: Homepage implementation backend#22
ConradBoydElliottGustafson merged 6 commits into
mainfrom
homepage-implementation

Conversation

@SScholefield

@SScholefield SScholefield commented Jul 21, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Builds the backend foundation for Home page: the read endpoints that let a user pick a working mill + reporting year and resolve that selection into a context the schedule pages consume. This replaces the hardcoded default the Schedule pages currently fake with a real, server-controlled selection source.

Scope is backend only.
GET /api/v1/mills
GET /api/v1/reporting-years
GET /api/v1/mill-context?millId&year

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

  • New unit tests
  • New integrated tests
  • New component tests
  • New end-to-end tests
  • New user flow tests
  • No new tests are required
  • Manual tests (description below)
  • Updated existing tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

paulushcgcj
paulushcgcj reviewed Jul 21, 2026
View reviewed changes

@paulushcgcj paulushcgcj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some mentions about some stories that I could not find on github. Other than that looks good. Left just one suggestion

Comment thread backend/src/main/java/ca/bc/gov/nrs/ilcr/configuration/SecurityConfiguration.java Outdated
This was linked to issues Jul 23, 2026
[HOME-1.1] List Selectable Mills and Reporting Years (backend) #177
Closed
[HOME-1.2] Resolve the Working Context and Its Report Statuses (backend) #178
Closed
@SScholefield
SScholefield requested a review from paulushcgcj July 23, 2026 18:57
adityaravi12
adityaravi12 approved these changes Jul 23, 2026
View reviewed changes

@adityaravi12 adityaravi12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

paulushcgcj
paulushcgcj reviewed Jul 23, 2026
View reviewed changes

@paulushcgcj paulushcgcj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small N+1 observation — trackStatus in MillContextService calls findStatusDescription(code) and it is invoked twice from resolveWorkingContext (once per track). Two round-trips to a lookup table is minor today, but the pattern will grow if more tracks or status lookups are added. Worth considering a batch method like findStatusDescriptions(List<String> codes) returning a Map<String, String>, or flagging for a follow-up.

ConradBoydElliottGustafson
ConradBoydElliottGustafson approved these changes Jul 23, 2026
View reviewed changes

@ConradBoydElliottGustafson ConradBoydElliottGustafson left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonably-sized PR with high level of checks applied. Purpose and scope are understandable and the guardrails have all been applied. Pass.

@ConradBoydElliottGustafson

ConradBoydElliottGustafson commented Jul 23, 2026

Copy link
Copy Markdown

We can't let these PRs languish -- it will create merge hell. We'll get the SONAR report when the github actions are all working. Come on DevOps team let's do this thing ;-)

@ConradBoydElliottGustafson
ConradBoydElliottGustafson merged commit d4831c4 into main Jul 23, 2026
16 of 20 checks passed
@ConradBoydElliottGustafson
ConradBoydElliottGustafson deleted the homepage-implementation branch July 23, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulushcgcj paulushcgcj paulushcgcj left review comments
@ConradBoydElliottGustafson ConradBoydElliottGustafson ConradBoydElliottGustafson approved these changes
@adityaravi12 adityaravi12 adityaravi12 approved these changes
@gpascucci gpascucci Awaiting requested review from gpascucci gpascucci is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[HOME-1.2] Resolve the Working Context and Its Report Statuses (backend) [HOME-1.1] List Selectable Mills and Reporting Years (backend)

4 participants

@SScholefield @ConradBoydElliottGustafson @paulushcgcj @adityaravi12