chore: don't create unneeded networks#289
Draft
davidlougheed wants to merge 1 commit intoreleases/v18from
Draft
Conversation
before this, networks for turned-off features would be created.
v-rocheleau
requested changes
Nov 26, 2024
Contributor
v-rocheleau
left a comment
v-rocheleau
left a comment
There was a problem hiding this comment.
Network creation is as expected now.
One issue, when the feature flags are off, bentoctl run encounters missing network errors.
Member
Author
|
hmmm. maybe these are needed then... |
Contributor
From what I gather this is caused by the gateway compose file, which always expects these networks. |
Member
Author
|
i'll reconvert this to draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before this, networks for turned-off features would be created.