fix: hide the error stack properly

Author: himself65

src/error.test.ts

@@ -0,0 +1,25 @@
+import { describe, expect, it } from "vitest";
+import { APIError } from "./error";
+
+describe("APIError", () => {
+	it("should throw correct stack", () => {
+		const error = new APIError("INTERNAL_SERVER_ERROR", {
+			message: "Test error",
+		});
+		expect(error.stack).toMatchInlineSnapshot(`"APIError: Test error"`);
+
+		function testError() {
+			throw new APIError("INTERNAL_SERVER_ERROR", {
+				message: "Test error in function",
+			});
+		}
+
+		function deepTestError() {
+			testError();
+		}
+
+		expect(() => deepTestError()).toThrowErrorMatchingInlineSnapshot(
+			`[APIError: Test error in function]`,
+		);
+	});
+});

src/error.ts

@@ -1,3 +1,42 @@
+// https://github.com/nodejs/node/blob/360f7cc7867b43344aac00564286b895e15f21d7/lib/internal/errors.js#L246C1-L261C2
+function isErrorStackTraceLimitWritable() {
+	const desc = Object.getOwnPropertyDescriptor(Error, "stackTraceLimit");
+	if (desc === undefined) {
+		return Object.isExtensible(Error);
+	}
+
+	return Object.prototype.hasOwnProperty.call(desc, "writable")
+		? desc.writable
+		: desc.set !== undefined;
+}
+
+// https://github.com/nodejs/node/blob/360f7cc7867b43344aac00564286b895e15f21d7/lib/internal/errors.js#L411-L432
+function makeErrorForHideStackFrame<B extends new (...args: any[]) => Error>(
+	Base: B,
+	clazz: any,
+): B {
+	class HideStackFramesError extends Base {
+		constructor(...args: any[]) {
+			if (isErrorStackTraceLimitWritable()) {
+				const limit = Error.stackTraceLimit;
+				Error.stackTraceLimit = 0;
+				super(...args);
+				Error.stackTraceLimit = limit;
+			} else {
+				super(...args);
+			}
+		}
+
+		// This is a workaround for wpt tests that expect that the error
+		// constructor has a `name` property of the base class.
+		get ["constructor"]() {
+			return clazz;
+		}
+	}
+
+	return HideStackFramesError;
+}
+
 export const _statusCode = {
 	OK: 200,
 	CREATED: 201,
@@ -116,19 +155,27 @@ export type Status =
 	| 510
 	| 511;
 
-export class APIError extends Error {
+class InternalAPIError extends Error {
 	constructor(
 		public status: keyof typeof _statusCode | Status = "INTERNAL_SERVER_ERROR",
 		public body:
 			| ({
 					message?: string;
 					code?: string;
+					cause?: unknown;
 			  } & Record<string, any>)
 			| undefined = undefined,
 		public headers: HeadersInit = {},
 		public statusCode = typeof status === "number" ? status : _statusCode[status],
 	) {
-		super(body?.message);
+		super(
+			body?.message,
+			body?.cause
+				? {
+						cause: body.cause,
+					}
+				: undefined,
+		);
 		this.name = "APIError";
 		this.status = status;
 		this.headers = headers;
@@ -142,6 +189,7 @@ export class APIError extends Error {
 					...body,
 				}
 			: undefined;
-		this.stack = "";
 	}
 }
+
+export const APIError = makeErrorForHideStackFrame(InternalAPIError, Error);