fix(to-response): only mark true cycles in safeStringify#140
Merged
Conversation
bytaesu
commented
Apr 29, 2026
Member
- Closes safeStringify should only mark true cycles as circular references, not shared objects #86
commit: |
There was a problem hiding this comment.
Pull request overview
Adjusts safeStringify in toResponse to only label true cycles as circular references (matching JSON.stringify behavior for shared-but-non-cyclic references), addressing issue #86.
Changes:
- Reworked circular detection in
safeStringifyto check only the current ancestor chain (not “seen before” globally). - Updated/added tests to ensure shared object/array references serialize in full while true cycles are still marked.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/better-call/src/to-response.ts | Updates safeStringify to detect only ancestor-chain cycles using parent tracking + stable IDs. |
| packages/better-call/src/to-response.test.ts | Updates circular-ref expectations and adds coverage for shared non-cyclic references (object + array). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Successfully created backport PR for |
bytaesu
added a commit
that referenced
this pull request
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.