fix(component): [worksheet] prevent paste into disabled parent rows (#1846)

* fix(component): [worksheet] prevent paste into disabled parent rows

The paste handler was using `cell.rowIndex + 1` to check against
`disabledRows`, but `disabledRows` contains row IDs, not 1-based
indices. This meant paste was never blocked on disabled rows unless
IDs happened to be sequential numbers. Also, `setSelectedCells` was
called before any disabled check, visually updating the cell value.

Fix uses `rows[cell.rowIndex]?.id` to compare against `disabledRows`
and adds the disabled row check before `setSelectedCells` runs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(component): [worksheet] fix lint errors in useCopyPaste

Remove unnecessary non-null assertion and fix prettier formatting
in the disabled rows filter callback.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(component): [worksheet] remove unnecessary istanbul ignore comment

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* test(component): [worksheet] add tests for paste into disabled rows

Add two tests to the 'disable rows' describe block:
- Verify paste does not modify a disabled parent row
- Verify paste still works on non-disabled rows when disabledRows is set

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: bc-apostoliuk

packages/big-design/src/components/Worksheet/hooks/useCopyPaste/useCopyPaste.ts

@@ -121,14 +121,20 @@ export const useCopyPasteHandler = () => {
         if (
           copiedCells[0] &&
           selectedCells[0] &&
+          columns[selectedCells[0].columnIndex] &&
+          !disabledRows.includes(rows[selectedCells[0].rowIndex]?.id) &&
           isPasteAllowed(copiedCells[0], selectedCells[0], columns[selectedCells[0].columnIndex])
         ) {
           setSelectedCells([{ ...selectedCells[0], value: copiedCells[0].value }]);
 
           updateItems(
-            cellsToUpdate.filter((cell) => !disabledRows.includes(cell.rowIndex + 1)),
+            cellsToUpdate.filter((cell) => !disabledRows.includes(rows[cell.rowIndex]?.id)),
             copiedCells
-              .filter((_, idx) => !disabledRows.includes(cellsToUpdate[idx]?.rowIndex + 1))
+              .filter((_, idx) => {
+                const cell = cellsToUpdate[idx];
+
+                return cell ? !disabledRows.includes(rows[cell.rowIndex]?.id) : false;
+              })
               .map((cell) => cell.value),
           );
         }
@@ -142,6 +148,7 @@ export const useCopyPasteHandler = () => {
       cellsToUpdate,
       disabledRows,
       columns,
+      rows,
     ],
   );
 

packages/big-design/src/components/Worksheet/spec.tsx

@@ -1573,6 +1573,62 @@ describe('disable rows', () => {
 
     expect(screen.getByDisplayValue('test test test')).toBeInTheDocument();
   });
+
+  test('paste does not modify disabled row', async () => {
+    render(
+      <Worksheet columns={columns} disabledRows={[3]} items={items} onChange={handleChange} />,
+    );
+
+    const sourceCell = await screen.findByText('Shoes Name Three');
+
+    if (sourceCell.parentElement) {
+      await userEvent.click(sourceCell.parentElement);
+    }
+
+    await userEvent.keyboard('{Meta>}{c}{/Meta}');
+
+    const targetCell = await screen.findByText('Shoes Name One');
+
+    if (targetCell.parentElement) {
+      await userEvent.click(targetCell.parentElement);
+    }
+
+    await userEvent.keyboard('{Meta>}{v}{/Meta}');
+
+    expect(handleChange).not.toHaveBeenCalled();
+  });
+
+  test('paste works on non-disabled rows when some rows are disabled', async () => {
+    render(
+      <Worksheet columns={columns} disabledRows={[1]} items={items} onChange={handleChange} />,
+    );
+
+    const sourceCell = await screen.findByText('Shoes Name Three');
+
+    if (sourceCell.parentElement) {
+      await userEvent.click(sourceCell.parentElement);
+    }
+
+    await userEvent.keyboard('{Meta>}{c}{/Meta}');
+
+    const targetCell = await screen.findByText('Shoes Name One');
+
+    if (targetCell.parentElement) {
+      await userEvent.click(targetCell.parentElement);
+    }
+
+    await userEvent.keyboard('{Meta>}{v}{/Meta}');
+
+    expect(handleChange).toHaveBeenCalledWith([
+      {
+        id: 3,
+        numberField: 50,
+        otherField2: 3,
+        productName: 'Shoes Name Three',
+        visibleOnStorefront: false,
+      },
+    ]);
+  });
 });
 
 describe('expandable', () => {