Carry the impound multi-update flash in the layout's flash region

The multi-update form redirects back to a turbo_stream response, so its flash
needed a copy inside the results frame to survive. Replace #flash-messages
alongside the frame instead, and drop the render_flash local and the bootstrap
alert markup it rendered.

The flash component renders its container even when empty, so the turbo_stream
has something to target.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: sethherr

app/components/ui/alerts/flash_message/component.rb

@@ -10,14 +10,12 @@ def initialize(flash: {})
           @flash = flash
         end
 
-        def render?
-          messages.any?
-        end
-
         private
 
+        # Renders even when empty: #flash-messages is the turbo_stream target for
+        # frame updates that carry a flash (see organized/impound_records).
         def messages
-          @messages ||= @flash.filter_map do |type, message|
+          @flash.filter_map do |type, message|
             next unless message.is_a?(String)
             {text: message, kind: kind_for(type)}
           end

app/views/organized/impound_records/_results.html.erb

@@ -1,18 +1,3 @@
-<%#
-  render_flash is passed only by index.turbo_stream.erb: the multi-update
-  form redirects back here and the frame is replaced via turbo_stream, so the
-  flash must live inside the frame to survive. On a full page load the layout
-  renders the flash instead.
-%>
-
-<% if local_assigns[:render_flash] %>
-  <div class="bootstrapstyle primary-alert-block">
-    <% flash.each do |name, msg| %>
-      <%= render partial: "/shared/alert", locals: {body: msg, type: name} %>
-    <% end %>
-  </div>
-<% end %>
-
 <% if @render_chart %>
   <%= render(UI::ChartAsyncFrame::Component.new(
     id: :impound_records_chart_frame,

app/views/organized/impound_records/index.turbo_stream.erb

@@ -1,3 +1,8 @@
 <%= turbo_stream.update :impound_records_results_frame do %>
-  <%= render partial: "results", locals: {render_flash: true} %>
+  <%= render partial: "results" %>
+<% end %>
+
+<%# The multi-update form redirects back here, so carry its flash along with the frame %>
+<%= turbo_stream.replace "flash-messages" do %>
+  <%= render(UI::Alerts::FlashMessage::Component.new(flash:)) %>
 <% end %>

spec/components/ui/alerts/flash_message/component_spec.rb

@@ -48,8 +48,9 @@
   context "with empty flash" do
     let(:flash) { {} }
 
-    it "renders nothing" do
-      expect(component.to_html).to be_blank
+    it "renders the container with no alerts, so turbo_streams can target it" do
+      expect(component).to have_css("#flash-messages")
+      expect(component).not_to have_css("[role='alert']")
     end
   end
 

spec/integration/organized/impound_records_spec.rb

@@ -163,7 +163,8 @@ def check_for_update(impound_record)
     expect(page).to have_no_css("[role=alert]", text: /select at least one record/i)
     within("#impoundRecordUpdateForm") { find("button[type=submit]").click }
 
-    expect(page).to have_content("Updated 1 impound record", wait: 10)
+    # The turbo_stream response replaces the layout's flash region alongside the frame
+    expect(page).to have_css("#flash-messages", text: "Updated 1 impound record", wait: 10)
     expect(registered.impound_record_updates.pluck(:kind)).to eq ["retrieved_by_owner"]
     expect(unregistered.impound_record_updates).to be_empty