Render flash messages with UI::Alerts::FlashMessage (#4020)

The four layouts that rendered flash through `/layouts/revised_messages`
now render the component instead, the way admin already did. The partial
stays behind for `@page_errors` and the mustache template
`BikeIndexAlerts` renders client-side alerts into, so the JS alerts on
the bike-edit and payments pages keep working.

- **`flash[:info]` becomes `flash[:notice]`.** `info` isn't one of
`KINDS` — 24 call sites across 14 controllers set it directly, four more
reach it by passing `flash_type: :info` to `authenticate_user`, and four
views passed it as a kind, where it silently fell back. Renamed rather
than aliased in the component, so the flash type and the kind it renders
stay the same word. `KINDS` now derives from `TEXT_CLASSES`.
- **The unknown-kind guard raises in dev and test, falls back to notice
elsewhere.** Rails sweeps the flash after the layout renders, so a raise
from the layout leaves the offending key in the session and raises again
on the next request, and the next.
- **Every flash value is a string now.** Six sites set an Array
(`errors.full_messages`) or a `flash[:errors]` key; the component
renders neither, and the old bootstrap partial rendered the Array's
`inspect`. Five get `to_sentence`, and the theft alert plan forms get
`UI::Alerts::ObjectError` above the form like the other admin forms.
- **The impound multi-update's turbo_stream replaces `#flash-messages`**
alongside the results frame, rather than rendering a second copy of the
flash inside the frame. The component renders its container even when
empty so there's something to target, and the replace only fires when
there's a flash — otherwise every filter and sort would wipe an alert
the rider hadn't dismissed.
- **`UI::Alert` moves to `UI::Alerts::Base`**, so all three alert
components share the namespace. The three `MARKUP_DIGEST` bumps are that
rename reaching templates inside fragment caches.

Flash now sits bottom-center instead of top, and success messages no
longer auto-fade after 10s — the component's behavior, already what
admin gets.

Author: sethherr

app/components/admin/badges/bike_hidden_explanation/component.rb

@@ -24,7 +24,7 @@ def call
         def user_hidden_content
           return unless @bike.user_hidden?
 
-          content_tag(:small, "user hidden", class: UI::Alert::Component::TEXT_CLASSES[:notice])
+          content_tag(:small, "user hidden", class: UI::Alerts::Base::Component::TEXT_CLASSES[:notice])
         end
 
         # BikeVersion can't be example
@@ -47,11 +47,11 @@ def deleted_content
           content_tag(:small,
             content_tag(:span, "deleted: ") +
               content_tag(:span, l(@bike.deleted_at, format: :convert_time), class: "localizeTime"),
-            class: UI::Alert::Component::TEXT_CLASSES[:warning])
+            class: UI::Alerts::Base::Component::TEXT_CLASSES[:warning])
         end
 
         def error_class
-          UI::Alert::Component::TEXT_CLASSES[:error]
+          UI::Alerts::Base::Component::TEXT_CLASSES[:error]
         end
       end
     end

app/components/admin/badges/marketplace_listing/component.rb

@@ -29,9 +29,9 @@ def humanize(str)
 
         def status_class
           case @status
-          when "for_sale" then UI::Alert::Component::TEXT_CLASSES[:notice]
-          when "sold" then UI::Alert::Component::TEXT_CLASSES[:success]
-          when "removed" then UI::Alert::Component::TEXT_CLASSES[:warning]
+          when "for_sale" then UI::Alerts::Base::Component::TEXT_CLASSES[:notice]
+          when "sold" then UI::Alerts::Base::Component::TEXT_CLASSES[:success]
+          when "removed" then UI::Alerts::Base::Component::TEXT_CLASSES[:warning]
           else
             ""
           end

app/components/admin/bike_cell/component.html.erb

@@ -1,5 +1,5 @@
 <% if @bike.blank? %>
-  <small class="<%= UI::Alert::Component::TEXT_CLASSES[:error] %>">
+  <small class="<%= UI::Alerts::Base::Component::TEXT_CLASSES[:error] %>">
     Missing bike
     <% if @bike_id.present? %>
       <code><%= @bike_id %></code>

app/components/admin/bikes_table/component.html.erb

@@ -53,7 +53,7 @@
 
           <% if bike.claimed? %>
             <span
-              class="tw:absolute tw:top-0 tw:right-0 <%= UI::Alert::Component::TEXT_CLASSES[:notice] %>"
+              class="tw:absolute tw:top-0 tw:right-0 <%= UI::Alerts::Base::Component::TEXT_CLASSES[:notice] %>"
               title="<%= bike.type %> is claimed"
               style="cursor: default"
             >
@@ -65,7 +65,7 @@
 
       <% table.column(sortable: "manufacturer_id") do |bike| %>
         <% if bike.manufacturer_other.present? %>
-          <span class="<%= UI::Alert::Component::TEXT_CLASSES[:warning] %>">
+          <span class="<%= UI::Alerts::Base::Component::TEXT_CLASSES[:warning] %>">
             <%= bike.manufacturer_other %>
           </span>
         <% else %>
@@ -85,7 +85,7 @@
 
           <% if bike.stolen_recovery? %>
             <small>
-              <%= link_to "recovery!", edit_admin_recovery_url(bike.recovered_records.first.id), class: "#{UI::Alert::Component::TEXT_CLASSES[:success]} tw:underline" %>
+              <%= link_to "recovery!", edit_admin_recovery_url(bike.recovered_records.first.id), class: "#{UI::Alerts::Base::Component::TEXT_CLASSES[:success]} tw:underline" %>
             </small>
           <% end %>
 
@@ -104,7 +104,7 @@
           <% end %>
 
           <% if bike.status_stolen? %>
-            <span class="tw:absolute tw:right-0 tw:bottom-0 tw:text-xs <%= UI::Alert::Component::TEXT_CLASSES[:error] %>">
+            <span class="tw:absolute tw:right-0 tw:bottom-0 tw:text-xs <%= UI::Alerts::Base::Component::TEXT_CLASSES[:error] %>">
               stolen
             </span>
           <% end %>

app/components/admin/bikes_table/component.rb

@@ -8,7 +8,7 @@ module BikesTable
     # checkboxes, and skip_user to drop the owner column.
     class Component < ApplicationComponent
       # Digest of the markup inside the row cache — the cached_markup_digest spec keeps it current
-      MARKUP_DIGEST = "55bd93d8018c"
+      MARKUP_DIGEST = "864a82f880b3"
 
       def initialize(bikes:, no_show_header: false, show_serial: false, render_sortable: false,
         skip_user: false, render_multi_check: false)

app/components/admin/current_header/component.rb

@@ -105,7 +105,7 @@ def primary_activity_subject
       end
 
       def error_text_class
-        UI::Alert::Component::TEXT_CLASSES[:error]
+        UI::Alerts::Base::Component::TEXT_CLASSES[:error]
       end
     end
   end

app/components/admin/organization_cell/component.rb

@@ -23,7 +23,7 @@ def organization_subject
       end
 
       def error_text_class
-        UI::Alert::Component::TEXT_CLASSES[:error]
+        UI::Alerts::Base::Component::TEXT_CLASSES[:error]
       end
     end
   end

app/components/admin/strava_requests_rate_limit_details/component.html.erb

@@ -40,6 +40,6 @@
   </div>
 
   <% if StravaJobs::RequestRunner.new.skip_job? %>
-    <%= render(UI::Alert::Component.new(text: "StravaJobs::RequestRunner is skipped", kind: :error)) %>
+    <%= render(UI::Alerts::Base::Component.new(text: "StravaJobs::RequestRunner is skipped", kind: :error)) %>
   <% end %>
 </div>

app/components/admin/user_cell/component.html.erb

@@ -1,7 +1,7 @@
 <span class="tw:inline-flex tw:items-baseline tw:gap-x-2">
   <% if show_missing_user? %>
     <small
-      class="<%= UI::Alert::Component::TEXT_CLASSES[:error] %>"
+      class="<%= UI::Alerts::Base::Component::TEXT_CLASSES[:error] %>"
       title="<%= @user_id %>"
     >
       Missing user

app/components/admin/users_table/component.html.erb

@@ -23,7 +23,7 @@
   <% end %>
 
   <% table.column(sortable: "deleted_at", classes: "deleted-cell tw:text-xs") do |user| %>
-    <span class="<%= UI::Alert::Component::TEXT_CLASSES[:error] %>">
+    <span class="<%= UI::Alerts::Base::Component::TEXT_CLASSES[:error] %>">
       <%= render UI::Time::Component.new(time: user.deleted_at) %>
     </span>
   <% end %>