Follow up to #3352
Stolen record attrs were renamed to the new address_record variants (:zipcode to :postal_code, :state_id to :region_record_id and added :region_string)
#3352 kept controllers accepting the old names, since forms are often submitted long after render.
We want to remove the legacy form support, this issue is to track the parts that need to be updated.
The tail of StolenRecord#bike_index_geocode — “assign only blank attrs, then assign_region_record if region_string_changed?” — duplicates the tail of Geocodeable#address_record_geocode. Extract that shared tail into the concern and letting StolenRecord contribute only the address_changed? guard + reverse branch
The Organized::BulkImportController will need to keep supporting the legacy parameters FOREVER (or at least for a long while). When this issue is being addressed, handling for the legacy attributes should move to the OrganizedBulkImportsController
Follow up to #3352
Stolen record attrs were renamed to the new address_record variants (
:zipcodeto:postal_code,:state_idto:region_record_idand added:region_string)#3352 kept controllers accepting the old names, since forms are often submitted long after render.
We want to remove the legacy form support, this issue is to track the parts that need to be updated.
The tail of
StolenRecord#bike_index_geocode— “assign only blank attrs, then assign_region_record if region_string_changed?” — duplicates the tail ofGeocodeable#address_record_geocode. Extract that shared tail into the concern and letting StolenRecord contribute only the address_changed? guard + reverse branchThe
Organized::BulkImportControllerwill need to keep supporting the legacy parameters FOREVER (or at least for a long while). When this issue is being addressed, handling for the legacy attributes should move to theOrganizedBulkImportsController