Spiralogram: cast DiscreteVariable into string#81
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
=======================================
Coverage 67.51% 67.51%
=======================================
Files 7 7
Lines 671 671
Branches 102 102
=======================================
Hits 453 453
Misses 173 173
Partials 45 45 Continue to review full report at Codecov.
|
ajdapretnar
force-pushed
the
spiralogram
branch
from
d73f94f to
d6a03c7
Compare
ajdapretnar
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #81 +/- ##
==========================================
- Coverage 67.51% 67.41% -0.10%
==========================================
Files 7 7
Lines 671 669 -2
Branches 102 102
==========================================
- Hits 453 451 -2
Misses 173 173
Partials 45 45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Spiralogram apparently supports discrete variables on radius, but they didn't work properly.
Description of changes
Cast DiscreteVariables into strings.
Tests.
Includes