Skip to content

Commit 2419daa

Browse files
committed
Add additional tests for subset definitions
1 parent 94fce4d commit 2419daa

3 files changed

Lines changed: 37 additions & 1 deletion

File tree

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ dependencies = [
7777
"class_resolver>=0.6.0",
7878
"pydantic>=2.0",
7979
"curies>=0.10.17",
80-
"curies-processing>=0.1.2",
80+
"curies-processing>=0.1.6",
8181
"python-dateutil",
8282
"networkx>=3.4",
8383
# Resource Downloaders

tests/test_obo_reader/test_reader.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -315,6 +315,18 @@ def test_8_subset(self) -> None:
315315
self.assertEqual(1, len(term.subsets))
316316
self.assertEqual(default_reference("go", "TESTSET"), term.subsets[0])
317317

318+
def test_8_subset_blocked(self) -> None:
319+
"""Test parsing subsets that are blocked."""
320+
ontology = from_str("""\
321+
ontology: chebi
322+
323+
[Term]
324+
id: CHEBI:10
325+
subset: 2:STAR
326+
""")
327+
term = self.get_only_term(ontology)
328+
self.assertEqual(0, len(term.subsets))
329+
318330
def test_9_synonym_minimal(self) -> None:
319331
"""Test parsing a synonym just the text."""
320332
ontology = from_str("""\

tests/test_obo_reader/test_reader_ontology.py

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,30 @@ def test_7_subset(self) -> None:
7979
ontology.subsetdefs,
8080
)
8181

82+
def test_7_curie(self) -> None:
83+
"""Test parsing a subset definition that is a CURIE."""
84+
ontology = from_str("""\
85+
ontology: chebi
86+
subsetdef: obo:test "name"
87+
""")
88+
self.assertEqual([(Reference.from_curie("obo:test"), "name")], ontology.subsetdefs)
89+
90+
def test_7_blocked_curie(self) -> None:
91+
"""Test parsing a subset definition that is explicitly blocked."""
92+
ontology = from_str("""\
93+
ontology: chebi
94+
subsetdef: 1:STAR "Preliminary entries"
95+
""")
96+
self.assertEqual([], ontology.subsetdefs)
97+
98+
def test_7_uri(self) -> None:
99+
"""Test parsing a subset definition that is a URI."""
100+
ontology = from_str("""\
101+
ontology: chebi
102+
subsetdef: http://purl.obolibrary.org/obo/chebi#TEST "name"
103+
""")
104+
self.assertEqual([(default_reference("chebi", "TEST"), "name")], ontology.subsetdefs)
105+
82106
def test_8_synonym_typedef(self) -> None:
83107
"""Test the ``synonym_typedef`` tag."""
84108
with self.assertRaises(ValueError):

0 commit comments

Comments
 (0)