test(wallet): make truc tx test bdk_testenv-agnostic

Rewrite `test_create_and_spend_from_truc_tx` to exercise the BIP-431
rule #2 filter in-memory, dropping `bdk_testenv`/`bdk_electrum`:
funding via `insert_checkpoint`+`receive_output`, broadcasts via
`insert_tx`. Also fix txD to be genuinely non-TRUC.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: oleonardolima

Cargo.toml

@@ -46,7 +46,6 @@ test-utils = ["std", "anyhow", "tempfile"]
 [dev-dependencies]
 anyhow = "1"
 assert_matches = "1.5.0"
-bdk_testenv = { version = "0.13.1" }
 bdk_bitcoind_rpc = { version = "0.22.0" }
 bdk_electrum = { version = "0.23.2" }
 bdk_esplora = { version = "0.22.1", features = ["async-https", "blocking-https", "tokio"] }
@@ -78,7 +77,3 @@ name = "esplora_blocking"
 
 [[example]]
 name = "bitcoind_rpc"
-
-# override `bdk_testenv` to the latest one, as it's the one that have `bitcoind v0.28`
-[patch.crates-io]
-bdk_testenv = { git = "https://github.com/bitcoindevkit/bdk.git", branch = "master", package = "bdk_testenv" }

tests/wallet.rs

@@ -1,10 +1,8 @@
 use std::str::FromStr;
 use std::sync::Arc;
-use std::time::Duration;
 
 use assert_matches::assert_matches;
 use bdk_chain::{BlockId, CanonicalizationParams, ConfirmationBlockTime};
-use bdk_testenv::TestEnv;
 use bdk_wallet::coin_selection;
 use bdk_wallet::coin_selection::InsufficientFunds;
 use bdk_wallet::descriptor::{calc_checksum, DescriptorError, IntoWalletDescriptor};
@@ -3065,57 +3063,35 @@ fn test_tx_ordering_untouched_preserves_insertion_ordering_bnb_success() {
 
 #[test]
 fn test_create_and_spend_from_truc_tx() -> anyhow::Result<()> {
-    let env = TestEnv::new().expect("should create `TestEnv` successfully!");
-
-    let _ = env
-        .mine_blocks(101, None)
-        .expect("should mine blocks successfully!");
-
     let (descriptor, change_descriptor) = get_test_wpkh_and_change_desc();
     let mut wallet = Wallet::create(descriptor, change_descriptor)
         .network(Network::Regtest)
         .create_wallet_no_persist()
         .expect("should create wallet successfully!");
 
-    let recv_addr = wallet.next_unused_address(KeychainKind::External);
-
-    // add funds to the wallet (two 250k sats UTXOs)
-    let _ = env
-        .send(&recv_addr, Amount::from_sat(250_000))
-        .expect("should fund wallet successfully!");
-    let _ = env
-        .send(&recv_addr, Amount::from_sat(250_000))
-        .expect("should fund wallet successfully!");
-
-    // mine block that confirms tx
-    let _ = env.mine_blocks(6, None)?;
-    env.wait_until_electrum_sees_block(Duration::from_secs(6))?;
-
-    let balance = wallet.balance();
-    assert_eq!(
-        balance.total(),
-        Amount::ZERO,
-        "wallet balance SHOULD be zero before any scan/sync"
-    );
-
-    // wallet full scan
-    let electrum_client = bdk_electrum::BdkElectrumClient::new(env.electrum_client());
-
-    let request = wallet.start_full_scan();
-    let response = electrum_client
-        .full_scan(request, 50, 5, true)
-        .expect("should execute full scan successfully!");
+    // establish a chain tip so confirmed funds can be anchored to a block in the active chain.
+    let block = BlockId {
+        height: 1_000,
+        hash: BlockHash::all_zeros(),
+    };
+    insert_checkpoint(&mut wallet, block);
+    let anchor = ConfirmationBlockTime {
+        block_id: block,
+        confirmation_time: 0,
+    };
 
-    wallet.apply_update(response)?;
+    // add funds to the wallet (two 250k sats confirmed UTXOs)
+    receive_output(&mut wallet, Amount::from_sat(250_000), anchor);
+    receive_output(&mut wallet, Amount::from_sat(250_000), anchor);
 
     let balance = wallet.balance();
     assert_eq!(
         balance.total(),
         Amount::from_sat(500_000),
-        "wallet balance SHOULD be 500K after initial full scan"
+        "wallet balance SHOULD be 500K after funding"
     );
 
-    // Should be able to create/broadcast TRUC (v3) transactions.
+    // Should be able to create TRUC (v3) transactions.
     // NOTE: "A TRUC transaction can spend outputs from confirmed non-TRUC transactions. A non-TRUC
     // transaction can spend outputs from confirmed TRUC transactions" See, rule #2: https://github.com/bitcoin/bips/blob/master/bip-0431.mediawiki#specification
 
@@ -3130,26 +3106,16 @@ fn test_create_and_spend_from_truc_tx() -> anyhow::Result<()> {
 
     let _ = wallet.sign(&mut psbt, SignOptions::default())?;
     let tx_a = psbt.extract_tx()?;
+    let txid_a = tx_a.compute_txid();
 
-    // broadcast txA (TRUC)
-    let txid_a = electrum_client
-        .transaction_broadcast(&tx_a)
-        .expect("should broadcast txA (TRUC) successfully!");
-    let _ = env.wait_until_electrum_sees_txid(txid_a, Duration::from_secs(6));
-
-    // wallet sync
-    let request = wallet.start_sync_with_revealed_spks();
-    let response = electrum_client
-        .sync(request, 5, true)
-        .expect("should execute sync successfully!");
-
-    wallet.apply_update(response)?;
+    // "broadcast" txA (TRUC): insert it into the wallet's local view as an unconfirmed tx.
+    insert_tx(&mut wallet, tx_a);
 
     let balance = wallet.balance();
     assert_eq!(
         balance.untrusted_pending,
         Amount::from_sat(125_000),
-        "wallet balance SHOULD have 125K unconfirmed (TRUC) UTXO after txA sync!"
+        "wallet balance SHOULD have 125K unconfirmed (TRUC) UTXO after txA!"
     );
 
     // create txB (non-TRUC)
@@ -3173,24 +3139,15 @@ fn test_create_and_spend_from_truc_tx() -> anyhow::Result<()> {
         "SHOULD NOT try to spend an unconfirmed TRUC output in a non-TRUC tx!"
     );
 
-    // broadcast txB (non-TRUC)
-    let txid_b = electrum_client
-        .transaction_broadcast(&tx_b)
-        .expect("should broadcast txB (non-TRUC) successfully!");
-
-    // wallet sync
-    let request = wallet.start_sync_with_revealed_spks();
-    let response = electrum_client
-        .sync(request, 5, true)
-        .expect("should execute sync successfully!");
-
-    wallet.apply_update(response)?;
+    // "broadcast" txB (non-TRUC)
+    let txid_b = tx_b.compute_txid();
+    insert_tx(&mut wallet, tx_b);
 
     let balance = wallet.balance();
     assert_eq!(
         balance.untrusted_pending,
         Amount::from_sat(250_000),
-        "wallet balance SHOULD have 250K unconfirmed, both non-TRUC (txB) and TRUC (txA) UTXOs after txB sync!"
+        "wallet balance SHOULD have 250K unconfirmed, both non-TRUC (txB) and TRUC (txA) UTXOs after txB!"
     );
 
     // create txC (TRUC)
@@ -3200,7 +3157,7 @@ fn test_create_and_spend_from_truc_tx() -> anyhow::Result<()> {
     builder.add_recipient(recv_addr.script_pubkey(), Amount::from_sat(200_000));
     builder.version(3);
 
-    let mut psbt = builder.finish().expect("should create txB (TRUC) successfully! as per BIP-431 it can spend unconfirmed outputs from TRUC txs.");
+    let mut psbt = builder.finish().expect("should create txC (TRUC) successfully! as per BIP-431 it can spend unconfirmed outputs from TRUC txs.");
 
     let _ = wallet.sign(&mut psbt, SignOptions::default())?;
     let tx_c = psbt.extract_tx()?;
@@ -3213,33 +3170,21 @@ fn test_create_and_spend_from_truc_tx() -> anyhow::Result<()> {
         "SHOULD NOT try to spend an unconfirmed non-TRUC output in a TRUC tx!"
     );
 
-    // broadcast txC (TRUC)
-    let txid_c = electrum_client
-        .transaction_broadcast(&tx_c)
-        .expect("should broadcast txC (TRUC) successfully!");
-    let _ = env.wait_until_electrum_sees_txid(txid_c, Duration::from_secs(6));
-
-    // wallet sync
-    let request = wallet.start_sync_with_revealed_spks();
-    let response = electrum_client
-        .sync(request, 5, true)
-        .expect("should execute sync successfully!");
-
-    wallet.apply_update(response)?;
+    // "broadcast" txC (TRUC)
+    insert_tx(&mut wallet, tx_c);
 
     let balance = wallet.balance();
     assert_eq!(
         balance.untrusted_pending,
         Amount::from_sat(325_000),
-        "wallet balance SHOULD have 325K unconfirmed UTXOs after sync!"
+        "wallet balance SHOULD have 325K unconfirmed UTXOs after txC!"
     );
 
     // create txD (non-TRUC)
     let recv_addr = wallet.next_unused_address(KeychainKind::External);
 
     let mut builder = wallet.build_tx();
     builder.add_recipient(recv_addr.script_pubkey(), Amount::from_sat(400_000));
-    builder.version(3);
 
     let psbt = builder.finish();