Fix Error with LC XL mk3 (#118)

* Launchkontrol Mk3 cleanup Debug Output stuff

Author: ericahrens

src/main/java/com/bitwig/extensions/controllers/novation/launchcontrolxlmk3/LaunchControlMidiProcessor.java

@@ -48,7 +48,7 @@ public class LaunchControlMidiProcessor {
     public LaunchControlMidiProcessor(final ControllerHost host,
         final AbstractLaunchControlExtensionDefinition definition) {
         final String productId = definition.isXlVersion() ? "15" : "16";
-        LaunchControlMk3Extension.println(" IS XL = %s", definition.isXlVersion());
+        host.println(" IS XL = " + definition.isXlVersion());
         LAUNCH_CONFIRM_CODE = LAUNCH_CONFIRM_CODE.formatted(productId);
         NOVATION_HEADER = "F0 00 20 29 02 %s ".formatted(productId);
         COLOR_SYSEX[5] = (byte) (definition.isXlVersion() ? 0x15 : 0x16);
@@ -127,7 +127,7 @@ private void handleMidiIn(final int status, final int data1, final int data2) {
                 this.modeListeners.forEach(listener -> listener.accept(mode));
             }
         }
-        LaunchControlMk3Extension.println(" MIDI %02X %02X %02X", status, data1, data2);
+        //host.println(" MIDI %02X %02X %02X".formatted(status, data1, data2));
     }
 
     public void sendRgb(final int index, final RgbColor color) {
@@ -152,18 +152,18 @@ public void addStartListener(final Runnable startAction) {
 
     private void handleSysEx(final String data) {
         if (!data.endsWith("f7")) {
-            LaunchControlMk3Extension.println("Illegal Sysex Received : %s", data);
+            host.println("Illegal Sysex Received : " + data);
             return;
         }
         if (data.startsWith(DEVICE_RESPONSE_HEADER)) {
             final String[] values = extractValues(data, DEVICE_RESPONSE_HEADER.length(), 8);
-            LaunchControlMk3Extension.println("Device response : %s", Arrays.toString(values));
+            host.println("Device response : " + Arrays.toString(values));
             startMidi();
         } else {
             if (data.startsWith(LAUNCH_CONFIRM_CODE)) {
                 hwUpdater.run();
             } else {
-                LaunchControlMk3Extension.println(" SYSEX %s", data);
+                host.println(" SYSEX " + data);
             }
         }
     }

src/main/java/com/bitwig/extensions/controllers/novation/launchcontrolxlmk3/LaunchControlMk3Extension.java

@@ -17,38 +17,18 @@
 
 public class LaunchControlMk3Extension extends ControllerExtension {
 
-    private static ControllerHost debugHost;
-    private static final DateTimeFormatter DF = DateTimeFormatter.ofPattern("hh:mm:ss SSS");
 
     private final AbstractLaunchControlExtensionDefinition definition;
     private HardwareSurface surface;
     private Context diContext;
 
-    public static void println(final String format, final Object... args) {
-        if (debugHost != null) {
-            final LocalDateTime now = LocalDateTime.now();
-            debugHost.println(now.format(DF) + " > " + String.format(format, args));
-        }
-    }
-    
-    public static void showCallLocation(final String message) {
-        println("MSG: %s", message);
-        for (final StackTraceElement element : Thread.currentThread().getStackTrace()) {
-            final String s = element.toString();
-            if (s.startsWith("com.bitwig.extensions") && !s.contains("showCallLocation")) {
-                println("  | %s ", s.replace("com.bitwig.extensions.controllers.novation.launchcontrolxlmk3", ""));
-            }
-        }
-    }
-    
     public LaunchControlMk3Extension(final AbstractLaunchControlExtensionDefinition definition,
         final ControllerHost host) {
         super(definition, host);
         this.definition = definition;
     }
 
     public void init() {
-        debugHost = getHost();
         diContext = new Context(this, Set.of(definition.isXlVersion() ? "XLModel" : "LCModel"));
         diContext.registerService(AbstractLaunchControlExtensionDefinition.class, definition);
         surface = diContext.getService(HardwareSurface.class);
@@ -60,10 +40,6 @@ public void init() {
             mixerLayer.setSpecOverlay(specControl);
         }
         diContext.activate();
-        final Layers layers = diContext.getService(Layers.class);
-        for (final Layer l : layers.getLayers()) {
-            LaunchControlMk3Extension.println(" > " + l.getName());
-        }
     }
 
     @Override

src/main/java/com/bitwig/extensions/controllers/novation/launchcontrolxlmk3/bindings/SegmentDisplayBinding.java

@@ -35,7 +35,6 @@ private boolean isBlocked() {
     private void handleNameUpdate(final String name) {
         this.name = name;
         if (isActive() && !isBlocked()) {
-            LaunchControlMk3Extension.println(" NAME UPDATE " + name);
             getTarget().show2LinesBuffered(title, name);
         }
     }

src/main/java/com/bitwig/extensions/controllers/novation/launchcontrolxlmk3/layer/LcMixerLayer.java

@@ -58,7 +58,6 @@ public LcMixerLayer(final Layers layers, final LaunchControlMidiProcessor midiPr
         final LaunchViewControl viewControl, final LaunchControlXlHwElements hwElements,
         final DisplayControl displayControl, final TransportHandler transportHandler, final ButtonLayers buttonLayers) {
         super(layers, midiProcessor, host, viewControl, hwElements, displayControl, transportHandler, buttonLayers);
-        LaunchControlMk3Extension.println(" LC MIXER LAYER");
         panLayer = new Layer(layers, "PAN");
         sendLayer = new Layer(layers, "SEND");
 

src/main/java/com/bitwig/extensions/controllers/novation/launchcontrolxlmk3/layer/XlMixerLayer.java

@@ -58,7 +58,6 @@ public XlMixerLayer(final Layers layers, final LaunchControlXlHwElements hwEleme
         final LaunchControlMidiProcessor midiProcessor, final ControllerHost host,
         final TransportHandler transportHandler, final ButtonLayers buttonLayers) {
         super(layers, midiProcessor, host, viewControl, hwElements, displayControl, transportHandler, buttonLayers);
-        LaunchControlMk3Extension.println(" XL MIXER LAYER");
 
         final TrackBank trackBank = viewControl.getTrackBank();
         for (int i = 0; i < 8; i++) {