Skip to content

Remove omegaconf dependency #166

Description

@singlerider

bbot_server/applets/base.py:8 imports OmegaConf for a single call site at line 312:

cron = OmegaConf.select(self.global_config, cron_config_key, default=cron_default)

Two problems:

  1. self.global_config resolves to bbcfg, a pydantic BBOTServerSettings, not an OmegaConf DictConfig. OmegaConf.select is the wrong API for that object.
  2. cron_config_key has no call sites in the tree, so the branch never executes.

omegaconf was never declared in pyproject.toml. It arrived transitively from bbot until bbot 3.0.2 dropped it, which broke imports. #165 declares it explicitly to unbreak CI.

Replace line 312 with a dotted lookup on the pydantic model and drop omegaconf from pyproject.toml.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions