feat: improve the doc picker modal (#828)

Author: jeremydw

.changeset/clean-dingos-develop.md

@@ -0,0 +1,5 @@
+---
+'@blinkk/root-cms': patch
+---
+
+feat: improve doc picker modal

AGENTS.md

@@ -20,22 +20,24 @@ The project is a monorepo managed with `pnpm` and `turbo`.
 - **@blinkk/root-cms** (`packages/root-cms`): The CMS integration for Root.js.
 - **@blinkk/create-root** (`packages/create-root`): CLI tool to scaffold new Root.js projects.
 - **Other Packages**:
-    - `eslint-config-root`: Shared ESLint configuration.
-    - `rds`: Likely related to data services or storage (needs verification).
-    - `root-core`: Core logic/utilities.
-    - `root-db`: Database abstraction/layer.
-    - `root-form`: Form handling utilities.
-    - `root-password-protect`: Middleware/utility for password protection.
-    - `root-webui`: UI components or interface for the system.
+  - `eslint-config-root`: Shared ESLint configuration.
+  - `rds`: Likely related to data services or storage (needs verification).
+  - `root-core`: Core logic/utilities.
+  - `root-db`: Database abstraction/layer.
+  - `root-form`: Form handling utilities.
+  - `root-password-protect`: Middleware/utility for password protection.
+  - `root-webui`: UI components or interface for the system.
 
 ### Apps (`apps/`)
 
 - **gci**: An application built within the monorepo.
 
 ### Documentation (`docs/`)
+
 Contains documentation for the project, likely powering `rootjs.dev`.
 
 ### Examples (`examples/`)
+
 Contains example projects demonstrating various features of Root.js.
 
 ## Development
@@ -49,20 +51,26 @@ Contains example projects demonstrating various features of Root.js.
 When working on this project, please adhere to the following guidelines:
 
 ### Package Management
+
 - **Always use `pnpm`**: This project uses `pnpm` for package management. Do not use `npm` or `yarn`.
 - **Install dependencies**: Run `pnpm install` at the root to install dependencies for all packages.
 
 ### Build & Test
+
 - **Use Turbo**: Use `turbo run build` or `turbo run test` to run tasks across the monorepo efficiently.
 - **Dev Server**: Use `pnpm dev` in specific package or app directories for development.
 
 ### Version Control & Contributions
+
 - **Changesets**: If your changes require a release (version bump), you must create a changeset. Run `pnpm changeset` and follow the prompts.
 - **Commit Messages**: Follow the conventional commit format (e.g., `feat: add new feature`, `fix: resolve issue`).
 - **Linting**: Ensure code passes linting rules by running `pnpm lint`.
 
 ### Documentation
+
 - **Update Docs**: If you change functionality, check if `docs/` needs updating. The documentation is a Root.js app itself.
+- **Comment Style**: All comments should end in punctuation. Use block comments to describe interfaces and their fields. Avoid adding superfluous comments.
+- **Comment Requirements**: When creating new classes, hooks, or components that have medium-to-complex functionality, ensure you write at least a brief block comment describing what it is for. For complex functionality, provide an example of how to use it in the comment.
 
 ## Contribution
 

packages/root-cms/ui/components/DocEditor/fields/ReferencesField.tsx

@@ -12,8 +12,8 @@ import {useState} from 'preact/hooks';
 import * as schema from '../../../../core/schema.js';
 import {useDraftDoc, useDraftDocField} from '../../../hooks/useDraftDoc.js';
 import {joinClassNames} from '../../../utils/classes.js';
+import {useDocPickerModal} from '../../DocPickerModal/DocPickerModal.js';
 import {DocPreviewCard} from '../../DocPreviewCard/DocPreviewCard.js';
-import {useDocSelectModal} from '../../DocSelectModal/DocSelectModal.js';
 import {FieldProps} from './FieldProps.js';
 import {ReferenceFieldValue} from './ReferenceField.js';
 
@@ -43,14 +43,15 @@ export function ReferencesField(props: FieldProps) {
     }
   });
 
-  const docSelectModal = useDocSelectModal();
+  const docPickerModal = useDocPickerModal();
 
-  function openDocSelectModal() {
-    docSelectModal.open({
+  function openDocPickerModal() {
+    docPickerModal.open({
       collections: field.collections,
       initialCollection: field.initialCollection,
+      multiSelect: true,
       selectedDocIds: refIds,
-      onChange: (docId: string, selected: boolean) => {
+      onChangeMulti: (docId: string, selected: boolean) => {
         setRefIds((old) => {
           const next = [...old];
           if (selected) {
@@ -146,7 +147,7 @@ export function ReferencesField(props: FieldProps) {
       ) : (
         <div className="ReferencesField__none">None selected</div>
       )}
-      <Button color="dark" size="xs" onClick={() => openDocSelectModal()}>
+      <Button color="dark" size="xs" onClick={() => openDocPickerModal()}>
         {field.buttonLabel || 'Select'}
       </Button>
     </div>

packages/root-cms/ui/components/DocPickerModal/DocPickerModal.css

@@ -1,3 +1,7 @@
+.DocPickerModal {
+  padding-right: 20px;
+}
+
 .DocPickerModal__collection__select {
   display: flex;
   gap: 8px;
@@ -10,29 +14,87 @@
   font-weight: 600;
 }
 
+.DocPickerModal__DocsList__controls {
+  display: flex;
+  gap: 12px;
+  align-items: center;
+  margin-bottom: 12px;
+  padding-bottom: 12px;
+  border-bottom: 1px solid var(--color-border);
+}
+
+.DocPickerModal__DocsList__controls:last-child {
+  border-bottom: 0;
+  margin-bottom: 0;
+}
+
+.DocPickerModal__DocsList__controls__search {
+  flex: 1;
+  min-width: 200px;
+}
+
+.DocPickerModal__DocsList__controls__sort {
+  min-width: 140px;
+}
+
+.DocPickerModal__DocsList {
+  display: flex;
+  flex-direction: column;
+  height: 100%;
+}
+
+.DocPickerModal__DocsList__stickyHeader {
+  position: sticky;
+  top: 0;
+  background: white;
+  z-index: 1;
+  margin-bottom: 8px;
+  border-bottom: 1px solid var(--color-border);
+}
+
+.DocPickerModal__DocsList__docsContainer {
+  flex: 1;
+  overflow-y: auto;
+  min-height: 0;
+}
+
 .DocPickerModal__DocCard {
   display: flex;
   align-items: center;
-  padding: 8px 0;
+  padding: 8px 8px 8px 0;
   border-top: 1px solid var(--color-border);
   overflow: hidden;
 }
 
+.DocPickerModal__DocCard:first-child {
+  border-top: none;
+}
+
 .DocPickerModal__DocCard__image {
   border: 1px solid var(--color-border);
   flex-shrink: 0;
+  cursor: pointer;
 }
 
 .DocPickerModal__DocCard__content {
-  display: block;
+  display: flex;
   padding: 0 12px;
   text-decoration: none;
   flex: 1;
+  flex-direction: column;
+}
+
+.DocPickerModal__DocCard__content__header {
+  display: flex;
+  gap: 8px;
+  align-items: center;
+  flex-wrap: wrap;
 }
 
 .DocPickerModal__DocCard__content__header__docId {
   font-size: 14px;
   font-weight: 500;
+  cursor: pointer;
 }
 
 .DocPickerModal__DocCard__content__title {
@@ -43,16 +105,65 @@
   display: -webkit-box;
   -webkit-box-orient: vertical;
   -webkit-line-clamp: 1;
+  cursor: pointer;
 }
 
-.DocPickerModal__DocCard__content__url {
-  font-size: 12px;
-  font-weight: 500;
-  color: #ababab;
+.DocPickerModal__DocCard__content__link {
+  display: inline-block;
+  cursor: pointer;
+}
+
+.DocPickerModal__DocCard__content__badges {
+  display: flex;
+  align-items: center;
+  gap: 4px;
+  margin-top: 4px;
+}
+
+.DocPickerModal__DocCard__content__badges .mantine-Tooltip-root {
+  display: block;
+}
+
+.DocPickerModal__DocCard__content__badges .mantine-Badge-root {
+  display: flex;
 }
 
 .DocPickerModal__DocCard__controls {
   display: flex;
   gap: 8px;
   align-items: center;
+  flex-direction: column;
+}
+
+.DocPickerModal__DocCard__controls__buttons {
+  display: flex;
+  gap: 8px;
+  align-items: center;
+}
+
+.DocPickerModal__DocsList__loading {
+  display: flex;
+  justify-content: center;
+  padding: 40px 0;
+}
+
+.DocPickerModal__DocsList__empty {
+  padding: 40px 20px;
+  text-align: center;
+  color: #999;
+  font-size: 14px;
+}
+
+.DocPickerModal__noCollections {
+  padding: 20px;
+  text-align: center;
+  color: #999;
+  font-size: 14px;
+}
+
+.DocPickerModal__DocsList__count {
+  font-size: 12px;
+  color: #666;
+  margin-bottom: 12px;
+  padding: 0 4px;
 }