Skip to content

Commit 8bece22

Browse files
authored
fix: fix image non-empty state on load (#660)
1 parent fbee89d commit 8bece22

4 files changed

Lines changed: 10 additions & 7 deletions

File tree

.changeset/strange-ears-bake.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@blinkk/root-cms': patch
3+
---
4+
5+
fix: fix image non-empty state on load

packages/root-cms/ui/components/DocEditor/fields/FileField.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@ export function FileField(props: FieldProps) {
3030
onFileChange={(file) => {
3131
if (file) {
3232
props.draft.updateKey(props.deepKey, file);
33-
if (file.alt) {
34-
props.draft.updateKey(`${props.deepKey}.alt`, file.alt);
35-
}
3633
} else {
3734
props.draft.removeKey(props.deepKey);
3835
}

packages/root-cms/ui/components/DocEditor/fields/ImageField.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@ export function ImageField(props: FieldProps) {
2828
onFileChange={(file) => {
2929
if (file) {
3030
props.draft.updateKey(props.deepKey, file);
31-
if (file.alt) {
32-
props.draft.updateKey(`${props.deepKey}.alt`, file.alt);
33-
}
3431
} else {
3532
props.draft.removeKey(props.deepKey);
3633
}

packages/root-cms/ui/components/FileUploadField/FileUploadField.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import {
3030
import {IconDotsVertical} from '@tabler/icons-preact';
3131
import {createContext} from 'preact';
3232
import {ChangeEvent, CSSProperties, forwardRef} from 'preact/compat';
33-
import {useContext, useRef, useState} from 'preact/hooks';
33+
import {useContext, useEffect, useRef, useState} from 'preact/hooks';
3434
import {joinClassNames} from '../../utils/classes.js';
3535
import {
3636
buildDownloadURL,
@@ -135,6 +135,10 @@ export function FileUploadField(props: FileUploadFieldProps) {
135135
const acceptedFileTypes =
136136
props.exts ?? (props.variant === 'image' ? IMAGE_MIMETYPES : []);
137137

138+
useEffect(() => {
139+
setFileUploader((prev) => ({...prev, uploadedFile: props.file}));
140+
}, [props.file]);
141+
138142
/** Uploads file data to GCS. */
139143
async function uploadFile(file: File) {
140144
try {

0 commit comments

Comments
 (0)