fix(ledger): parse genesis staking pool vrf/owners/metadata fields (#1859)

PoolRegistrationCertificate.UnmarshalJSON read only the on-chain/API field
names (vrfKeyHash, poolOwners, poolMetadata, operator), but Shelley genesis
staking.pools uses vrf, owners, metadata, and publicKey for the same values. As
a result a pool declared in genesis parsed with an all-zeros VRF key hash (and
dropped owners and metadata). A zero VRF key hash breaks consensus header
VRF-key validation: the pool's blocks are rejected because their real VRF key
does not match the zero registered value.

Accept both name sets, preferring the on-chain/API name when both are present.
Assert the parsed VRF key hash in the InitialPools/PoolById tests, which
previously only checked cost, so the field-name mismatch went unnoticed.

Signed-off-by: Chris Guiney <chris@guiney.net>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: chrisguiney

ledger/common/certs.go

@@ -525,6 +525,16 @@ func (p *PoolRegistrationCertificate) UnmarshalJSON(data []byte) error {
 			Hostname *string `json:"hostname,omitempty"`
 		} `json:"relays"`
 		PoolMetadata *PoolMetadata `json:"poolMetadata,omitempty"`
+
+		// Shelley genesis staking.pools uses different field names than the
+		// on-chain / API representation above for the same values. Accept both
+		// so pools declared in genesis parse correctly — otherwise a genesis
+		// pool's VRF key hash is dropped and reads as all-zeros, which breaks
+		// header VRF-key validation for that pool's blocks.
+		PublicKey string        `json:"publicKey"`
+		Vrf       string        `json:"vrf"`
+		Owners    []string      `json:"owners"`
+		Metadata  *PoolMetadata `json:"metadata,omitempty"`
 	}
 
 	var tmp tempPool
@@ -533,6 +543,25 @@ func (p *PoolRegistrationCertificate) UnmarshalJSON(data []byte) error {
 		return fmt.Errorf("failed to unmarshal pool registration: %w", err)
 	}
 
+	// Resolve fields that have distinct genesis-staking names, preferring the
+	// on-chain/API name when both are present.
+	operator := tmp.Operator
+	if operator == "" {
+		operator = tmp.PublicKey
+	}
+	vrfKeyHash := tmp.VrfKeyHash
+	if vrfKeyHash == "" {
+		vrfKeyHash = tmp.Vrf
+	}
+	poolOwners := tmp.PoolOwners
+	if len(poolOwners) == 0 {
+		poolOwners = tmp.Owners
+	}
+	poolMetadata := tmp.PoolMetadata
+	if poolMetadata == nil {
+		poolMetadata = tmp.Metadata
+	}
+
 	p.Pledge = tmp.Pledge
 	p.Cost = tmp.Cost
 	p.Relays = make([]PoolRelay, len(tmp.Relays))
@@ -545,7 +574,7 @@ func (p *PoolRegistrationCertificate) UnmarshalJSON(data []byte) error {
 			Hostname: relay.Hostname,
 		}
 	}
-	p.PoolMetadata = tmp.PoolMetadata
+	p.PoolMetadata = poolMetadata
 
 	// Handle margin field
 	if len(tmp.Margin) > 0 {
@@ -585,27 +614,27 @@ func (p *PoolRegistrationCertificate) UnmarshalJSON(data []byte) error {
 	}
 
 	// Convert operator key
-	if tmp.Operator != "" {
-		opBytes, err := hex.DecodeString(tmp.Operator)
+	if operator != "" {
+		opBytes, err := hex.DecodeString(operator)
 		if err != nil {
 			return fmt.Errorf("invalid operator key: %w", err)
 		}
 		p.Operator = PoolKeyHash(opBytes)
 	}
 
 	// Convert VRF key hash
-	if tmp.VrfKeyHash != "" {
-		vrfBytes, err := hex.DecodeString(tmp.VrfKeyHash)
+	if vrfKeyHash != "" {
+		vrfBytes, err := hex.DecodeString(vrfKeyHash)
 		if err != nil {
 			return fmt.Errorf("invalid VRF key hash: %w", err)
 		}
 		p.VrfKeyHash = VrfKeyHash(NewBlake2b256(vrfBytes))
 	}
 
 	// Convert pool owners
-	if len(tmp.PoolOwners) > 0 {
-		owners := make([]AddrKeyHash, len(tmp.PoolOwners))
-		for i, owner := range tmp.PoolOwners {
+	if len(poolOwners) > 0 {
+		owners := make([]AddrKeyHash, len(poolOwners))
+		for i, owner := range poolOwners {
 			ownerBytes, err := hex.DecodeString(owner)
 			if err != nil {
 				return fmt.Errorf("invalid pool owner key: %w", err)

ledger/shelley/genesis_test.go

@@ -320,6 +320,18 @@ func TestGenesisStaking(t *testing.T) {
 			t.Errorf("Expected pool cost 340000000, got %d", pool.Cost)
 		}
 
+		// The VRF key hash must be parsed from the genesis "vrf" field.
+		// If it is dropped it reads as all-zeros, which breaks consensus
+		// header VRF-key validation for this pool's blocks.
+		expectedVrf := "eb53a17fbad9b7ea0bcf1e1ea89355305600d593b426dfc3084a924d8877d47e"
+		if got := hex.EncodeToString(pool.VrfKeyHash[:]); got != expectedVrf {
+			t.Errorf(
+				"Expected pool VRF key hash %s, got %s",
+				expectedVrf,
+				got,
+			)
+		}
+
 		// Test delegators
 		if len(delegators) != 1 {
 			t.Errorf("Expected 1 delegator mapping, got %d", len(delegators))
@@ -369,6 +381,18 @@ func TestGenesisStaking(t *testing.T) {
 			t.Errorf("Expected pool cost 340000000, got %d", pool.Cost)
 		}
 
+		// The VRF key hash must be parsed from the genesis "vrf" field.
+		// If it is dropped it reads as all-zeros, which breaks consensus
+		// header VRF-key validation for this pool's blocks.
+		expectedVrf := "eb53a17fbad9b7ea0bcf1e1ea89355305600d593b426dfc3084a924d8877d47e"
+		if got := hex.EncodeToString(pool.VrfKeyHash[:]); got != expectedVrf {
+			t.Errorf(
+				"Expected pool VRF key hash %s, got %s",
+				expectedVrf,
+				got,
+			)
+		}
+
 		// Test delegators
 		if len(delegators) != 1 {
 			t.Errorf("Expected 1 delegator, got %d", len(delegators))