Skip to content

Commit 065dcab

Browse files
committed
Refactor[bmq,mqb]: un-template request managers
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
1 parent b0382af commit 065dcab

23 files changed

Lines changed: 763 additions & 945 deletions

src/groups/bmq/bmqimp/bmqimp_brokersession.cpp

Lines changed: 233 additions & 250 deletions
Large diffs are not rendered by default.

src/groups/bmq/bmqimp/bmqimp_brokersession.h

Lines changed: 167 additions & 184 deletions
Large diffs are not rendered by default.

src/groups/bmq/bmqimp/bmqimp_messagecorrelationidcontainer.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
#include <bmqp_protocol.h>
2222
#include <bmqp_protocolutil.h>
2323
#include <bmqp_queueid.h>
24+
#include <bmqp_requestmanager.h>
2425

2526
// BDE
2627
#include <bsl_utility.h>
@@ -132,10 +133,10 @@ void MessageCorrelationIdContainer::add(
132133
d_correlationIds.insert(bsl::make_pair(key, toInsert));
133134
}
134135

135-
bmqt::MessageGUID MessageCorrelationIdContainer::add(
136-
const RequestManagerType::RequestSp& context,
137-
const bmqp::QueueId& queueId,
138-
const bdlbb::Blob& blob)
136+
bmqt::MessageGUID
137+
MessageCorrelationIdContainer::add(const RequestSp& context,
138+
const bmqp::QueueId& queueId,
139+
const bdlbb::Blob& blob)
139140
{
140141
bsls::SpinLockGuard guard(&d_lock); // LOCK
141142

src/groups/bmq/bmqimp/bmqimp_messagecorrelationidcontainer.h

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,15 @@
3535
// BMQ
3636
#include <bmqp_protocol.h>
3737
#include <bmqp_queueid.h>
38-
#include <bmqp_requestmanager.h>
3938
#include <bmqt_correlationid.h>
4039
#include <bmqt_messageguid.h>
4140

4241
#include <bmqc_orderedhashmap.h>
4342

4443
// BDE
44+
#include <bdlbb_blob.h>
4545
#include <bsl_functional.h>
46+
#include <bsl_memory.h>
4647
#include <bsl_vector.h>
4748
#include <bslma_allocator.h>
4849
#include <bslma_usesbslmaallocator.h>
@@ -51,6 +52,11 @@
5152
#include <bsls_spinlock.h>
5253

5354
namespace BloombergLP {
55+
56+
namespace bmqp {
57+
class RequestManagerRequest;
58+
}
59+
5460
namespace bmqimp {
5561

5662
// ===================================
@@ -62,9 +68,7 @@ class MessageCorrelationIdContainer {
6268
public:
6369
// PUBLIC TYPES
6470

65-
typedef bmqp::RequestManager<bmqp_ctrlmsg::ControlMessage,
66-
bmqp_ctrlmsg::ControlMessage>
67-
RequestManagerType;
71+
typedef bsl::shared_ptr<bmqp::RequestManagerRequest> RequestSp;
6872

6973
/// Struct representing the correlationId and queueId for a given
7074
/// message.
@@ -84,7 +88,7 @@ class MessageCorrelationIdContainer {
8488
bdlbb::Blob d_messageData;
8589
// Message data.
8690

87-
RequestManagerType::RequestSp d_requestContext;
91+
RequestSp d_requestContext;
8892
// Control request context.
8993

9094
/// Create a `QueueAndCorrelationId` having an invalid queueId and
@@ -204,9 +208,9 @@ class MessageCorrelationIdContainer {
204208

205209
/// Add the specified `context` and the `blob` and return a GUID key
206210
/// that can be used to retrieve it later.
207-
bmqt::MessageGUID add(const RequestManagerType::RequestSp& context,
208-
const bmqp::QueueId& queueId,
209-
const bdlbb::Blob& blob);
211+
bmqt::MessageGUID add(const RequestSp& context,
212+
const bmqp::QueueId& queueId,
213+
const bdlbb::Blob& blob);
210214

211215
/// Remove the item uniquely identified by the specified `key`,
212216
/// and populate the optionally specified `correlationId` with the

src/groups/bmq/bmqp/bmqp_requestmanager.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
namespace BloombergLP {
2020
namespace bmqp {
2121

22-
// NOTHING: Template
22+
// NOTHING
2323

2424
} // close package namespace
2525
} // close enterprise namespace

0 commit comments

Comments
 (0)