Refactor[mqbblp]: simplify RootQueueEngine (#1637)

- Remove useless `RootQueueEngine::create`
- `QueueEngineTester`: use `allocateManaged`
- `src/groups/mqb/mqbblp/mqbblp_rootqueueengine.t.cpp`: simplify test cases, remove useless includes, add missing `broadcast` test case

Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>

Author: 678098

src/groups/mqb/mqbblp/mqbblp_localqueue.cpp

@@ -158,10 +158,11 @@ int LocalQueue::configure(bsl::ostream& errorDescription, bool isReconfigure)
     // during update of a domain's configuration, this object already exists,
     // and should not be re-created.
     if (!d_queueEngine_mp) {
-        RootQueueEngine::create(&d_queueEngine_mp,
-                                d_state_p,
-                                *domainCfg,
-                                d_allocator_p);
+        d_queueEngine_mp =
+            bslma::ManagedPtrUtil::allocateManaged<RootQueueEngine>(
+                d_allocator_p,
+                d_state_p,
+                *domainCfg);
     }
 
     // Inform the storage about the queue.

src/groups/mqb/mqbblp/mqbblp_queueenginetester.cpp

@@ -36,7 +36,6 @@
 #include <bmqt_uri.h>
 
 #include <bmqu_memoutstream.h>
-#include <bmqu_time.h>
 
 // BDE
 #include <bdlb_string.h>
@@ -49,7 +48,6 @@
 #include <bsl_memory.h>
 #include <bsl_utility.h>
 #include <bsl_vector.h>
-#include <bslmt_once.h>
 #include <bsls_types.h>
 #include <bslstl_stringref.h>
 
@@ -395,8 +393,6 @@ QueueEngineTester::QueueEngineTester(const mqbconfm::Domain& domainConfig,
 , d_messageCount(0)
 , d_allocator_p(allocator)
 {
-    oneTimeInit();
-
     mqbconfm::Domain config = domainConfig;
 
     config.deduplicationTimeMs() = 0;  // No history
@@ -421,18 +417,9 @@ QueueEngineTester::~QueueEngineTester()
     d_mockDomain_mp->unregisterQueue(queue);
 
     d_mockCluster_mp->stop();
-    oneTimeShutdown();
 }
 
 // PRIVATE MANIPULATORS
-void QueueEngineTester::oneTimeInit()
-{
-    BSLMT_ONCE_DO
-    {
-        bmqu::Time::initialize();
-    }
-}
-
 void QueueEngineTester::init(const mqbconfm::Domain& domainConfig,
                              bool                    startScheduler)
 {
@@ -627,14 +614,6 @@ void QueueEngineTester::init(const mqbconfm::Domain& domainConfig,
         .setHandleFactory(handleFactory_mp);
 }
 
-void QueueEngineTester::oneTimeShutdown()
-{
-    BSLMT_ONCE_DO
-    {
-        bmqu::Time::shutdown();
-    }
-}
-
 void QueueEngineTester::handleReleasedCallback(
     int*                                      rc,
     bool*                                     isDeletedOutput,

src/groups/mqb/mqbblp/mqbblp_queueenginetester.h

@@ -257,18 +257,10 @@ class QueueEngineTester {
   private:
     // PRIVATE MANIPULATORS
 
-    /// Perform any initialization that needs to be done one time only in
-    /// the course of a program's execution (to enable thread-safety of some
-    /// component, etc.).
-    void oneTimeInit();
-
     /// Reset and recreate all objects using the currently set options and
     /// the specific `domainConfig`.
     void init(const mqbconfm::Domain& domainConfig, bool startScheduler);
 
-    /// Pendant operation of the `oneTimeInit` one.
-    void oneTimeShutdown();
-
     void
     handleReleasedCallback(int*  rc,
                            bool* isDeletedOutput,
@@ -642,12 +634,14 @@ inline T* QueueEngineTester::createQueueEngine()
 {
     // PRECONDITIONS
     BSLS_ASSERT_OPT(!d_queueEngine_mp && "'createQueueEngine()' was called");
-    T* result = new (*d_allocator_p)
-        T(d_queueState_mp.get(),
-          *d_queueState_mp->queue()->domain()->config(),
-          d_allocator_p);
+
     // Create and configure Queue Engine
-    d_queueEngine_mp.load(result, d_allocator_p);
+    d_queueEngine_mp = bslma::ManagedPtrUtil::allocateManaged<T>(
+        d_allocator_p,
+        d_queueState_mp.get(),
+        *d_queueState_mp->queue()->domain()->config());
+
+    T* result = static_cast<T*>(d_queueEngine_mp.get());
 
     createQueueEngineHelper(d_queueEngine_mp.get());
 

src/groups/mqb/mqbblp/mqbblp_relayqueueengine.t.cpp

@@ -25,6 +25,7 @@
 #include <mqbstat_brokerstats.h>
 
 #include <bmqu_memoutstream.h>
+#include <bmqu_time.h>
 
 // BMQ
 #include <bmqp_protocol.h>
@@ -2028,6 +2029,8 @@ int main(int argc, char* argv[])
 {
     TEST_PROLOG(bmqtst::TestHelper::e_DEFAULT);
 
+    bmqu::Time::initialize(bmqtst::TestHelperUtil::allocator());
+
     {
         mqbcfg::AppConfig brokerConfig(bmqtst::TestHelperUtil::allocator());
         mqbcfg::BrokerConfig::set(brokerConfig);
@@ -2068,6 +2071,8 @@ int main(int argc, char* argv[])
         }
     }
 
+    bmqu::Time::shutdown();
+
     // Default allocator check is disabled for all UTs:
     // `mqbblp::QueueEngine` and mocks from `mqbi` methods use ball logging
     // that allocates using default allocator.

src/groups/mqb/mqbblp/mqbblp_rootqueueengine.cpp

@@ -300,19 +300,6 @@ void RootQueueEngine::onHandleCreation(void* ptr, void* cookie)
                                                      hndlCreated);
 }
 
-void RootQueueEngine::create(bslma::ManagedPtr<mqbi::QueueEngine>* queueEngine,
-                             QueueState*                           queueState,
-                             const mqbconfm::Domain& domainConfig,
-                             bslma::Allocator*       allocator)
-{
-    // PRECONDITIONS
-    BSLS_ASSERT_SAFE(queueEngine);
-
-    queueEngine->load(new (*allocator)
-                          RootQueueEngine(queueState, domainConfig, allocator),
-                      allocator);
-}
-
 void RootQueueEngine::FanoutConfiguration::loadRoutingConfiguration(
     bmqp_ctrlmsg::RoutingConfiguration* config)
 {

src/groups/mqb/mqbblp/mqbblp_rootqueueengine.h

@@ -220,14 +220,6 @@ class RootQueueEngine BSLS_KEYWORD_FINAL : public mqbi::QueueEngine {
     /// to a boolean flag indicating whether the handle was created or not.
     static void onHandleCreation(void* ptr, void* cookie);
 
-    /// Loads the specified `queueEngine` with a new `RootQueueEngine`
-    /// initialized using the specified `queueState`, `domainConfig`,
-    /// `scheduler` and `allocator`.
-    static void create(bslma::ManagedPtr<mqbi::QueueEngine>* queueEngine,
-                       QueueState*                           queueState,
-                       const mqbconfm::Domain&               domainConfig,
-                       bslma::Allocator*                     allocator);
-
     /// Loads the specified `config` with the appropriate values for
     /// fanout delivery mode.
     struct FanoutConfiguration {