Refactor: implement operator!= using operator==

Signed-off-by: Christopher Beard <cbeard9@bloomberg.net>

Author: chrisbeard

src/groups/bmq/bmqa/bmqa_queueid.h

@@ -192,7 +192,7 @@ inline bool bmqa::operator==(const bmqa::QueueId& lhs,
 inline bool bmqa::operator!=(const bmqa::QueueId& lhs,
                              const bmqa::QueueId& rhs)
 {
-    return rhs.d_impl_sp.get() != lhs.d_impl_sp.get();
+    return !(lhs == rhs);
 }
 
 inline bool bmqa::operator<(const bmqa::QueueId& lhs, const bmqa::QueueId& rhs)

src/groups/bmq/bmqa/bmqa_sessionevent.cpp

@@ -160,11 +160,7 @@ bool operator==(const SessionEvent& lhs, const SessionEvent& rhs)
 
 bool operator!=(const SessionEvent& lhs, const SessionEvent& rhs)
 {
-    // PRECONDITIONS
-    BSLS_ASSERT_SAFE(lhs.d_impl_sp);
-    BSLS_ASSERT_SAFE(rhs.d_impl_sp);
-
-    return *lhs.d_impl_sp != *rhs.d_impl_sp;
+    return !(lhs == rhs);
 }
 
 }  // close package namespace

src/groups/bmq/bmqp/bmqp_queueinfo.h

@@ -232,7 +232,7 @@ QueueInfo<VALUE>::iterator::operator->()
 template <class VALUE>
 inline bool QueueInfo<VALUE>::iterator::operator!=(const iterator& other) const
 {
-    return d_iterator != other.d_iterator;
+    return !(*this == other);
 }
 
 template <class VALUE>
@@ -305,7 +305,7 @@ template <class VALUE>
 inline bool
 QueueInfo<VALUE>::const_iterator::operator!=(const const_iterator& other) const
 {
-    return d_iterator != other.d_iterator;
+    return !(*this == other);
 }
 
 template <class VALUE>

src/groups/bmq/bmqst/bmqst_value.h

@@ -274,11 +274,7 @@ inline bool bmqst::operator==(const bmqst::Value& lhs, const bmqst::Value& rhs)
 
 inline bool bmqst::operator!=(const bmqst::Value& lhs, const bmqst::Value& rhs)
 {
-    if (lhs.hash() != rhs.hash()) {
-        return true;
-    }
-
-    return lhs.d_value != rhs.d_value;
+    return !(lhs == rhs);
 }
 
 }  // close enterprise namespace

src/groups/bmq/bmqt/bmqt_correlationid.h

@@ -582,7 +582,7 @@ inline bool bmqt::operator==(const bmqt::CorrelationId& lhs,
 inline bool bmqt::operator!=(const bmqt::CorrelationId& lhs,
                              const bmqt::CorrelationId& rhs)
 {
-    return lhs.d_variant != rhs.d_variant;
+    return !(lhs == rhs);
 }
 
 inline bool bmqt::operator<(const bmqt::CorrelationId& lhs,

src/groups/bmq/bmqt/bmqt_queueoptions.h

@@ -354,10 +354,7 @@ inline bool bmqt::operator==(const bmqt::QueueOptions& lhs,
 inline bool bmqt::operator!=(const bmqt::QueueOptions& lhs,
                              const bmqt::QueueOptions& rhs)
 {
-    return lhs.maxUnconfirmedMessages() != rhs.maxUnconfirmedMessages() ||
-           lhs.maxUnconfirmedBytes() != rhs.maxUnconfirmedBytes() ||
-           lhs.consumerPriority() != rhs.consumerPriority() ||
-           lhs.suspendsOnBadHostHealth() != rhs.suspendsOnBadHostHealth();
+    return !(lhs == rhs);
 }
 
 inline bsl::ostream& bmqt::operator<<(bsl::ostream&             stream,

src/groups/bmq/bmqt/bmqt_sessionoptions.h

@@ -751,21 +751,7 @@ inline bool bmqt::operator==(const bmqt::SessionOptions& lhs,
 inline bool bmqt::operator!=(const bmqt::SessionOptions& lhs,
                              const bmqt::SessionOptions& rhs)
 {
-    return lhs.brokerUri() != rhs.brokerUri() ||
-           lhs.numProcessingThreads() != rhs.numProcessingThreads() ||
-           lhs.blobBufferSize() != rhs.blobBufferSize() ||
-           lhs.channelHighWatermark() != rhs.channelHighWatermark() ||
-           lhs.statsDumpInterval() != rhs.statsDumpInterval() ||
-           lhs.connectTimeout() != rhs.connectTimeout() ||
-           lhs.openQueueTimeout() != rhs.openQueueTimeout() ||
-           lhs.configureQueueTimeout() != rhs.configureQueueTimeout() ||
-           lhs.closeQueueTimeout() != rhs.closeQueueTimeout() ||
-           lhs.eventQueueLowWatermark() != rhs.eventQueueLowWatermark() ||
-           lhs.eventQueueHighWatermark() != rhs.eventQueueHighWatermark() ||
-           lhs.hostHealthMonitor() != rhs.hostHealthMonitor() ||
-           lhs.traceContext() != rhs.traceContext() ||
-           lhs.tracer() != rhs.tracer() ||
-           lhs.userAgentPrefix() != rhs.userAgentPrefix();
+    return !(lhs == rhs);
 }
 
 inline bsl::ostream& bmqt::operator<<(bsl::ostream&               stream,

src/groups/bmq/bmqt/bmqt_subscription.h

@@ -498,7 +498,7 @@ inline bool operator==(const SubscriptionHandle& lhs,
 inline bool operator!=(const SubscriptionHandle& lhs,
                        const SubscriptionHandle& rhs)
 {
-    return lhs.d_id != rhs.d_id;
+    return !(lhs == rhs);
 }
 
 inline bsl::ostream& operator<<(bsl::ostream&             stream,

src/groups/bmq/bmqt/bmqt_uri.h

@@ -524,7 +524,7 @@ inline bool bmqt::operator==(const bmqt::Uri& lhs, const bmqt::Uri& rhs)
 
 inline bool bmqt::operator!=(const bmqt::Uri& lhs, const bmqt::Uri& rhs)
 {
-    return (lhs.asString() != rhs.asString());
+    return !(lhs == rhs);
 }
 
 inline bool bmqt::operator<(const bmqt::Uri& lhs, const bmqt::Uri& rhs)

src/groups/bmq/bmqt/bmqt_version.h

@@ -188,7 +188,7 @@ inline bool bmqt::operator==(const bmqt::Version& lhs,
 inline bool bmqt::operator!=(const bmqt::Version& lhs,
                              const bmqt::Version& rhs)
 {
-    return lhs.major() != rhs.major() || lhs.minor() != rhs.minor();
+    return !(lhs == rhs);
 }
 
 inline bool bmqt::operator<(const bmqt::Version& lhs, const bmqt::Version& rhs)