Fix[BMQ,MQB]: cppcheck warnings (#844)

Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>

Author: 678098

src/groups/bmq/bmqst/bmqst_printutil.cpp

@@ -114,8 +114,7 @@ const char* memoryHelper(bsls::Types::Int64* num,
     }
 
     bsls::Types::Int64 shift = level * 10;
-
-    bsls::Types::Int64 div = 1 << shift;
+    bsls::Types::Int64 div   = 1LL << shift;
     *num                   = bytes >> shift;
     *remainder             = static_cast<int>(
         bsl::floor(((static_cast<double>(bytes - (*num << shift)) /

src/groups/mqb/mqbblp/mqbblp_routers.t.cpp

@@ -202,22 +202,22 @@ static void test2_priority()
         bmqp_ctrlmsg::Expression(bmqtst::TestHelperUtil::allocator()),
         mqbblp::Routers::Expression());
 
-    mqbi::QueueHandle* handle = 0;
-    ++handle;
+    bsls::ObjectBuffer<mqbmock::QueueHandle> handle;
+
     const bmqp_ctrlmsg::StreamParameters streamParameters(
         bmqtst::TestHelperUtil::allocator());
     mqbblp::Routers::Consumers consumers(bmqtst::TestHelperUtil::allocator());
     const unsigned int         subQueueId           = 13;
     mqbblp::Routers::Consumers::SharedItem consumer = consumers.record(
-        handle,
+        handle.address(),
         mqbblp::Routers::Consumer(streamParameters,
                                   subQueueId,
                                   bmqtst::TestHelperUtil::allocator()));
 
     mqbblp::Routers::Priority priority(bmqtst::TestHelperUtil::allocator());
 
     priority.d_subscribers.record(
-        handle,
+        handle.address(),
         mqbblp::Routers::Subscriber(consumer,
                                     bmqtst::TestHelperUtil::allocator()));
 }
@@ -463,7 +463,6 @@ static void test4_generate()
     bsl::string           appId("foo", bmqtst::TestHelperUtil::allocator());
     int                   priorityCount = 2;
     int                   priority      = 2;
-    mqbmock::QueueHandle* handle        = 0;
     unsigned int          subQueueId    = 13;
 
     in.appId() = appId;
@@ -487,10 +486,16 @@ static void test4_generate()
         }
     }
 
-    appContext
-        .load(++handle, &errorStream, subQueueId, upstreamSubQueueId, in, 0);
+    bsls::ObjectBuffer<mqbmock::QueueHandle> handle1, handle2;
+
+    appContext.load(handle1.address(),
+                    &errorStream,
+                    subQueueId,
+                    upstreamSubQueueId,
+                    in,
+                    0);
     BMQTST_ASSERT_EQ(errorStream.str(), "");
-    appContext.load(++handle,
+    appContext.load(handle2.address(),
                     &errorStream,
                     subQueueId + 1,
                     upstreamSubQueueId,

src/groups/mqb/mqbc/mqbc_clusterstatemanager.t.cpp

@@ -469,6 +469,7 @@ struct Tester {
             }
         }
 
+        BSLS_ASSERT_OPT(highestLSNFollower);
         BSLS_ASSERT_OPT(highestLSNFollower->nodeId() !=
                         d_cluster_mp->netCluster().selfNodeId());
 

src/groups/mqb/mqbc/mqbc_incoreclusterstateledger.t.cpp

@@ -493,6 +493,8 @@ struct Tester {
             }
         }
 
+        BSLS_ASSERT_OPT(blob);
+
         bdlbb::Blob record(d_cluster_mp->bufferFactory(),
                            bmqtst::TestHelperUtil::allocator());
         bdlbb::BlobUtil::append(&record, *blob, sizeof(bmqp::EventHeader));