Fix[MQB]: pass allocator correctly (#800)

Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>

Author: 678098

src/groups/mqb/mqbc/mqbc_clusterdata.cpp

@@ -70,7 +70,7 @@ mqbc::ClusterDataIdentity clusterIdentity(const bslstl::StringRef& name,
     }
 
     // Create and set description
-    bdlma::LocalSequentialAllocator<256> localAllocator;
+    bdlma::LocalSequentialAllocator<256> localAllocator(allocator);
     bmqu::MemOutStream                   os(&localAllocator);
     if (isRemote) {
         os << "ClusterProxy (" << name << ")";
@@ -79,10 +79,7 @@ mqbc::ClusterDataIdentity clusterIdentity(const bslstl::StringRef& name,
         os << "Cluster (" << name << ")";
     }
 
-    bsl::string description;
-    description.assign(os.str().data(), os.str().length());
-
-    return mqbc::ClusterDataIdentity(name, description, identity);
+    return mqbc::ClusterDataIdentity(name, os.str(), identity, allocator);
 }
 
 }  // close unnamed namespace

src/groups/mqb/mqbc/mqbc_clusterdata.h

@@ -86,13 +86,22 @@ class ClusterDataIdentity {
     bmqp_ctrlmsg::ClientIdentity d_identity;
 
   public:
+    // TRAITS
+    BSLMF_NESTED_TRAIT_DECLARATION(ClusterDataIdentity,
+                                   bslma::UsesBslmaAllocator)
+
     // CREATORS
 
-    /// Create a @bbref{mqbc::ClusterDataIdentity} with the specified `name`,
-    /// `description` and `identity`.
-    ClusterDataIdentity(const bsl::string&                  name,
-                        const bsl::string&                  description,
-                        const bmqp_ctrlmsg::ClientIdentity& identity);
+    /// Create a @bbref{mqbc::ClusterDataIdentity}.
+    /// @param name The cluster name.
+    /// @param description The cluster description.
+    /// @param identity The cluster identity.
+    /// @param allocator Allocator to use, or use the default allocator if it
+    ///                  is null.
+    explicit ClusterDataIdentity(const bslstl::StringRef& name,
+                                 const bslstl::StringRef& description,
+                                 const bmqp_ctrlmsg::ClientIdentity& identity,
+                                 bslma::Allocator* allocator = 0);
 
     // ACCESSORS
 
@@ -303,12 +312,13 @@ class ClusterData {
 
 // CREATORS
 inline ClusterDataIdentity::ClusterDataIdentity(
-    const bsl::string&                  name,
-    const bsl::string&                  description,
-    const bmqp_ctrlmsg::ClientIdentity& identity)
-: d_name(name)
-, d_description(description)
-, d_identity(identity)
+    const bslstl::StringRef&            name,
+    const bslstl::StringRef&            description,
+    const bmqp_ctrlmsg::ClientIdentity& identity,
+    bslma::Allocator*                   allocator)
+: d_name(name, allocator)
+, d_description(description, allocator)
+, d_identity(identity, allocator)
 {
     // NOTHING
 }

src/groups/mqb/mqbstat/mqbstat_clusterstats.cpp

@@ -251,7 +251,8 @@ void ClusterStats::initialize(const bsl::string&  name,
             bsl::shared_ptr<bmqst::StatContext>(
                 d_statContext_mp->addSubcontext(
                     bmqst::StatContextConfiguration(partitionName,
-                                                    &localAllocator))));
+                                                    &localAllocator)),
+                allocator));
         setNodeRoleForPartition(pId, PrimaryStatus::e_UNKNOWN);
     }
 }