Skip to content

Commit ec376e8

Browse files
authored
FIX[MQB]: cancelRead might cause a deadlock (#948)
Signed-off-by: Emelia Lei <wlei29@bloomberg.net>
1 parent fe46fe4 commit ec376e8

2 files changed

Lines changed: 0 additions & 6 deletions

File tree

src/groups/mqb/mqba/mqba_adminsession.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -387,9 +387,6 @@ void AdminSession::tearDown(BSLA_UNUSED const bsl::shared_ptr<void>& session,
387387
{
388388
// executed by the *IO* thread
389389

390-
// Cancel the reads on the channel
391-
d_channel_sp->cancelRead();
392-
393390
// Enqueue an event to the client dispatcher thread and wait for it to
394391
// finish; only after this will we have the guarantee that no method will
395392
// try to use the channel.

src/groups/mqb/mqba/mqba_clientsession.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2924,9 +2924,6 @@ void ClientSession::tearDown(const bsl::shared_ptr<void>& session,
29242924

29252925
BALL_LOG_INFO << description() << ": tearDown";
29262926

2927-
// Cancel the reads on the channel
2928-
d_channel_sp->cancelRead();
2929-
29302927
// Enqueue an event to the client dispatcher thread and wait for it to
29312928
// finish; only after this will we have the guarantee that no method will
29322929
// try to use the channel.

0 commit comments

Comments
 (0)