Disable vtab auth by default

Signed-off-by: mkhullar <mohit.khullar@gmail.com>

Author: mohitkhullar

db/comdb2.c

@@ -239,7 +239,7 @@ int64_t gbl_num_auth_allowed = 0;
 int64_t gbl_num_auth_denied = 0;
 int gbl_allow_old_authn = 1;
 int gbl_uses_externalauth = 0;
-int gbl_vtab_externalauth = 1;
+int gbl_vtab_externalauth = 0;
 int gbl_vtab_externalauth_strict = 0;
 #ifdef COMDB2_TEST
 int gbl_uses_simpleauth = 0;

db/db_tunables.h

@@ -2431,7 +2431,7 @@ REGISTER_TUNABLE("externalauth", NULL, TUNABLE_BOOLEAN, &gbl_uses_externalauth,
 REGISTER_TUNABLE("externalauth_connect", "Check for externalauth only once on connect", TUNABLE_BOOLEAN,
                  &gbl_uses_externalauth_connect, NOARG | READEARLY, NULL, NULL, NULL, NULL);
 
-REGISTER_TUNABLE("vtab_externalauth", "Use IAM for vtab access control (Default: on)", TUNABLE_BOOLEAN,
+REGISTER_TUNABLE("vtab_externalauth", "Use IAM for vtab access control (Default: off)", TUNABLE_BOOLEAN,
                  &gbl_vtab_externalauth, 0, NULL, NULL, NULL, NULL);
 
 REGISTER_TUNABLE("vtab_externalauth_strict", "Enforce access control on all CDB2_ALLOW_USER vtabs (Default: off)",

tests/simpleauth.test/lrl.options

@@ -1,4 +1,4 @@
 simpleauth
 dohsql_disable 0
 dohast_disable 0
-vtab_externalauth
+vtab_externalauth 1

tests/tunables.test/t00_all_tunables.expected

@@ -1151,7 +1151,7 @@
 (name='view_feature', description='Enables support for VIEWs (Default: ON)', type='BOOLEAN', value='ON', read_only='N')
 (name='views_dft_preempt_roll_secs', description='Amount of seconds to run phase 1 of time partition rollout before phase 2', type='INTEGER', value='1800', read_only='N')
 (name='views_dft_roll_delete_lag_secs', description='Amount of seconds to run phase 3 of time partition rollout after phase 2', type='INTEGER', value='5', read_only='N')
-(name='vtab_externalauth', description='Use IAM for vtab access control (Default: on)', type='BOOLEAN', value='ON', read_only='N')
+(name='vtab_externalauth', description='Use IAM for vtab access control (Default: off)', type='BOOLEAN', value='OFF', read_only='N')
 (name='vtab_externalauth_strict', description='Enforce access control on all CDB2_ALLOW_USER vtabs (Default: off)', type='BOOLEAN', value='OFF', read_only='N')
 (name='wait_for_prepare_seqnum', description='Wait-for-seqnum for prepare records. (Default: on)', type='BOOLEAN', value='ON', read_only='N')
 (name='wait_for_seqnum_trace', description='', type='BOOLEAN', value='OFF', read_only='N')