Double default authn/authz cache sizes (1000/4000)

Signed-off-by: mkhullar <mohit.khullar@gmail.com>

Author: mohitkhullar

db/comdb2.c

@@ -250,8 +250,8 @@ int gbl_externalauth_warn = 0;
 int gbl_consumer_auth_warnonly = 1;
 int gbl_admin_bypass_externalauth = 0;
 int gbl_passwords_with_externalauth = 0;
-int gbl_identity_cache_max = 500;
-int gbl_authorization_cache_max = 2000;
+int gbl_identity_cache_max = 1000;
+int gbl_authorization_cache_max = 4000;
 int gbl_authentication_cache_ageout = 900;
 int gbl_authorization_cache_ageout = 600;
 int gbl_cache_authz_perms = 1;

db/db_tunables.h

@@ -2486,14 +2486,14 @@ REGISTER_TUNABLE("sqlite_use_temptable_for_rowset",
                  "Use temptable instead of sqlite's binary search tree, for recording rowids (Default: ON)",
                  TUNABLE_BOOLEAN, &gbl_sqlite_use_temptable_for_rowset, 0, NULL, NULL, NULL, NULL);
 
-REGISTER_TUNABLE("max_identity_cache", "Max cache size of externalauth identities (Default: 500)",
-                 TUNABLE_INTEGER, &gbl_identity_cache_max, READONLY, NULL, NULL, NULL, NULL);
+REGISTER_TUNABLE("max_identity_cache", "Max cache size of externalauth identities (Default: 1000)", TUNABLE_INTEGER,
+                 &gbl_identity_cache_max, READONLY, NULL, NULL, NULL, NULL);
 
 REGISTER_TUNABLE("authentication_cache_ageout", "Max age of authentication cache (Default: 900 seconds)",
                  TUNABLE_INTEGER, &gbl_authentication_cache_ageout, 0, NULL, NULL, NULL, NULL);
 
-REGISTER_TUNABLE("max_authorization_cache", "Max cache size of authorized identities (Default: 2000)",
-                 TUNABLE_INTEGER, &gbl_authorization_cache_max, READONLY, NULL, NULL, NULL, NULL);
+REGISTER_TUNABLE("max_authorization_cache", "Max cache size of authorized identities (Default: 4000)", TUNABLE_INTEGER,
+                 &gbl_authorization_cache_max, READONLY, NULL, NULL, NULL, NULL);
 
 REGISTER_TUNABLE("authz_cache", "Enable per query caching of authorized tables.  (Default: on)",
                  TUNABLE_BOOLEAN, &gbl_cache_authz_perms, 0, NULL, NULL, NULL, NULL);

tests/tunables.test/t00_all_tunables.expected

@@ -553,10 +553,10 @@
 (name='master_swing_osql_verbose', description='Produce verbose trace for SQL handlers detecting a master change. (Default: off)', type='BOOLEAN', value='ON', read_only='Y')
 (name='master_swing_osql_verbose_off', description='Disables 'master_swing_osql_verbose'', type='BOOLEAN', value='OFF', read_only='N')
 (name='master_swing_sock_restart_sleep', description='For testing: sleep in osql_sock_restart when master swings', type='INTEGER', value='0', read_only='Y')
-(name='max_authorization_cache', description='Max cache size of authorized identities (Default: 2000)', type='INTEGER', value='2000', read_only='Y')
+(name='max_authorization_cache', description='Max cache size of authorized identities (Default: 4000)', type='INTEGER', value='4000', read_only='Y')
 (name='max_cascaded_rows_per_txn', description='Set the max cascaded rows updated per transaction.', type='INTEGER', value='0', read_only='N')
 (name='max_clientstats', description='Max number of client stats stored in comdb2_clientstats. (Default: 10000)', type='INTEGER', value='10000', read_only='N')
-(name='max_identity_cache', description='Max cache size of externalauth identities (Default: 500)', type='INTEGER', value='500', read_only='Y')
+(name='max_identity_cache', description='Max cache size of externalauth identities (Default: 1000)', type='INTEGER', value='1000', read_only='Y')
 (name='max_incoherent_nodes', description='', type='INTEGER', value='1', read_only='Y')
 (name='max_incoherent_slow', description='Sets maximum number of incoherent-slow nodes.  (Default: 3)', type='INTEGER', value='3', read_only='N')
 (name='max_key_size_new', description='Use new logic for checking max key size (Default: on)', type='INTEGER', value='1', read_only='N')