Skip to content

Commit bfb661f

Browse files
committed
{185248490} Print when toggling externalauth, disallow during full recovery
Signed-off-by: Salil Chandra <schandra107@bloomberg.net>
1 parent 7d222ea commit bfb661f

2 files changed

Lines changed: 21 additions & 2 deletions

File tree

db/db_tunables.c

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1297,6 +1297,25 @@ static int iam_base_bri_update(void *context, void *value)
12971297
return 0;
12981298
}
12991299

1300+
static int externalauth_update(void *context, void *value)
1301+
{
1302+
comdb2_tunable *tunable = (comdb2_tunable *)context;
1303+
int val = *(int *)value;
1304+
logmsg(LOGMSG_USER, "%s called with value %d\n", __func__, val);
1305+
if (val && gbl_fullrecovery) {
1306+
logmsg(LOGMSG_USER, "External authentication cannot be enabled during full recovery; "
1307+
"leaving it disabled\n");
1308+
val = 0;
1309+
}
1310+
if (val) {
1311+
logmsg(LOGMSG_USER, "External authentication enabled\n");
1312+
} else {
1313+
logmsg(LOGMSG_USER, "External authentication disabled\n");
1314+
}
1315+
*(int *)tunable->var = val;
1316+
return 0;
1317+
}
1318+
13001319
static void *file_permissions_value(void *context)
13011320
{
13021321
static char val[15];

db/db_tunables.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2438,8 +2438,8 @@ REGISTER_TUNABLE("allow_old_authn", "Reuse old successful authentication for the
24382438
TUNABLE_BOOLEAN, &gbl_allow_old_authn, NOARG | READEARLY,
24392439
NULL, NULL, NULL, NULL);
24402440

2441-
REGISTER_TUNABLE("externalauth", NULL, TUNABLE_BOOLEAN, &gbl_uses_externalauth, NOARG | READEARLY,
2442-
NULL, NULL, NULL, NULL);
2441+
REGISTER_TUNABLE("externalauth", NULL, TUNABLE_BOOLEAN, &gbl_uses_externalauth, NOARG | READEARLY, NULL, NULL,
2442+
externalauth_update, NULL);
24432443

24442444
REGISTER_TUNABLE("externalauth_connect", "Check for externalauth only once on connect", TUNABLE_BOOLEAN,
24452445
&gbl_uses_externalauth_connect, NOARG | READEARLY, NULL, NULL, NULL, NULL);

0 commit comments

Comments
 (0)