Enable vtab_externalauth_warn by default

Signed-off-by: mkhullar <mohit.khullar@gmail.com>

Author: mohitkhullar

db/comdb2.c

@@ -241,7 +241,7 @@ int gbl_allow_old_authn = 1;
 int gbl_uses_externalauth = 0;
 int gbl_vtab_externalauth = 0;
 int gbl_vtab_externalauth_strict = 0;
-int gbl_vtab_externalauth_warn = 0;
+int gbl_vtab_externalauth_warn = 1;
 #ifdef COMDB2_TEST
 int gbl_uses_simpleauth = 0;
 #endif

db/db_tunables.h

@@ -2441,7 +2441,7 @@ REGISTER_TUNABLE("vtab_externalauth", "Use IAM for vtab access control (Default:
 REGISTER_TUNABLE("vtab_externalauth_strict", "Enforce access control on all CDB2_ALLOW_USER vtabs (Default: off)",
                  TUNABLE_BOOLEAN, &gbl_vtab_externalauth_strict, 0, NULL, NULL, NULL, NULL);
 
-REGISTER_TUNABLE("vtab_externalauth_warn", "Log vtab access denials without enforcing (Default: off)", TUNABLE_BOOLEAN,
+REGISTER_TUNABLE("vtab_externalauth_warn", "Log vtab access denials without enforcing (Default: on)", TUNABLE_BOOLEAN,
                  &gbl_vtab_externalauth_warn, 0, NULL, NULL, NULL, NULL);
 
 REGISTER_TUNABLE("externalauth_warn", "Warn instead of returning error in case of missing authdata",

tests/tunables.test/t00_all_tunables.expected

@@ -1154,7 +1154,7 @@
 (name='views_dft_roll_delete_lag_secs', description='Amount of seconds to run phase 3 of time partition rollout after phase 2', type='INTEGER', value='5', read_only='N')
 (name='vtab_externalauth', description='Use IAM for vtab access control (Default: off)', type='BOOLEAN', value='OFF', read_only='N')
 (name='vtab_externalauth_strict', description='Enforce access control on all CDB2_ALLOW_USER vtabs (Default: off)', type='BOOLEAN', value='OFF', read_only='N')
-(name='vtab_externalauth_warn', description='Log vtab access denials without enforcing (Default: off)', type='BOOLEAN', value='OFF', read_only='N')
+(name='vtab_externalauth_warn', description='Log vtab access denials without enforcing (Default: on)', type='BOOLEAN', value='ON', read_only='N')
 (name='wait_for_prepare_seqnum', description='Wait-for-seqnum for prepare records. (Default: on)', type='BOOLEAN', value='ON', read_only='N')
 (name='wait_for_seqnum_trace', description='', type='BOOLEAN', value='OFF', read_only='N')
 (name='wal_osync', description='Open WAL files using the O_SYNC flag (Default: off)', type='BOOLEAN', value='OFF', read_only='N')