comdb2_unused_files systable

Changes from review- Tx Morgan!

Signed-off-by: Mark Hannum <mhannum@bloomberg.net>

Author: markhannum

bdb/bdb_api.h

@@ -2501,4 +2501,8 @@ int release_locks_int(const char *trace, const char *func, int line, struct sqlc
 int bdb_keylen(bdb_state_type *bdb_state, int ixnum);
 
 void llmeta_collect_tablename_alias(void);
+typedef int (*collect_unused_files_f)(void *args, int lognum, char *filename);
+
+void oldfile_hash_collect(collect_unused_files_f func, void *arg);
+
 #endif

bdb/file.c

@@ -7748,6 +7748,29 @@ void oldfile_dump(void)
     hash_for(oldfile_hash, oldfile_hash_dump, NULL);
 }
 
+struct collect_unused_files {
+    collect_unused_files_f func;
+    void *arg;
+};
+
+static int oldfile_collect(void *ptr, void *arg)
+{
+    struct unused_file *obj = (struct unused_file *)ptr;
+    struct collect_unused_files *u = (struct collect_unused_files *)arg;
+    (*u->func)(u->arg, obj->lognum, obj->fname);
+    return 0;
+}
+
+void oldfile_hash_collect(collect_unused_files_f func, void *arg)
+{
+    Pthread_mutex_lock(&unused_files_mtx);
+    if (oldfile_hash) {
+        struct collect_unused_files u = {.func = func, .arg = arg};
+        hash_for(oldfile_hash, oldfile_collect, &u);
+    }
+    Pthread_mutex_unlock(&unused_files_mtx);
+}
+
 /* use hash tbl to check if we have added file to list previously */
 static int oldfile_list_contains(const char *filename)
 {

sqlite/CMakeLists.txt

@@ -68,6 +68,7 @@ add_library(sqlite
   ext/comdb2/triggers.c
   ext/comdb2/tunables.c
   ext/comdb2/typesamples.c
+  ext/comdb2/unused_files.c
   ext/comdb2/users.c
   ext/comdb2/views.c
   ext/comdb2/fdb.c

sqlite/ext/comdb2/comdb2systblInt.h

@@ -106,6 +106,7 @@ int systblSchemaVersionsInit(sqlite3 *db);
 int systblTableMetricsInit(sqlite3 *db);
 int systblApiHistoryInit(sqlite3 *db);
 int systblDbInfoInit(sqlite3 *db);
+int systblUnusedFilesInit(sqlite3 *db);
 
 /* Simple yes/no answer for booleans */
 #define YESNO(x) ((x) ? "Y" : "N")

sqlite/ext/comdb2/tables.c

@@ -248,6 +248,8 @@ int comdb2SystblInit(
     rc = systblApiHistoryInit(db);
   if (rc == SQLITE_OK)
     rc = systblDbInfoInit(db);
+  if (rc == SQLITE_OK)
+    rc = systblUnusedFilesInit(db);
 #endif
   return rc;
 }

sqlite/ext/comdb2/unused_files.c

@@ -0,0 +1,86 @@
+/*
+   Copyright 2025 Bloomberg Finance L.P.
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+ */
+
+#include <assert.h>
+#include <comdb2systblInt.h>
+#include <ezsystables.h>
+#include <bdb_api.h>
+ 
+typedef struct systable_unused_files {
+    char *filename;
+    int64_t reflog;
+} systable_unused_files_t;
+
+typedef struct getunusedfiles {
+    int count;
+    int alloc;
+    systable_unused_files_t *records;
+} getunusedfiles_t;
+
+static int collect(void *args, int reflog, char *filename)
+{
+    getunusedfiles_t *a = (getunusedfiles_t *)args;
+    systable_unused_files_t *u;
+    a->count++;
+    if (a->count >= a->alloc) {
+        if (a->alloc == 0) a->alloc = 16;
+        else a->alloc = a->alloc * 2;
+        a->records = realloc(a->records, a->alloc * sizeof(systable_unused_files_t));
+        if (!a->records) {
+            logmsg(LOGMSG_FATAL, "%s: realloc failed\n", __func__);
+            abort();
+        }
+    }
+    u = &a->records[a->count - 1];
+    u->filename = strdup(filename);
+    if (!u->filename) {
+        logmsg(LOGMSG_FATAL, "%s: strdup failed\n", __func__);
+        abort();
+    }
+    u->reflog = reflog;
+    return 0;
+}
+
+static int get_unused_files(void **data, int *records)
+{
+    getunusedfiles_t a = {0};
+    oldfile_hash_collect(collect, &a);
+    *data = a.records;
+    *records = a.count;
+    return 0;
+}
+
+static void free_unused_files(void *p, int n)
+{
+    systable_unused_files_t *a, *begin = p;
+    systable_unused_files_t *end = begin + n;
+    for (a = begin; a < end; ++a) {
+        free(a->filename);
+    }
+    free(p);
+}
+
+sqlite3_module systblUnusedFilesModule = {
+    .access_flag = CDB2_ALLOW_USER
+};
+
+int systblUnusedFilesInit(sqlite3 *db) {
+    return create_system_table(db, "comdb2_unused_files", &systblUnusedFilesModule,
+            get_unused_files, free_unused_files, sizeof(systable_unused_files_t),
+            CDB2_CSTRING, "filename", -1, offsetof(systable_unused_files_t, filename),
+            CDB2_INTEGER, "reflog", -1, offsetof(systable_unused_files_t, reflog),
+            SYSTABLE_END_OF_FIELDS);
+}

tests/auth.test/t09.expected

@@ -293,6 +293,7 @@
 (candidate='comdb2_triggers')
 (candidate='comdb2_tunables')
 (candidate='comdb2_type_samples')
+(candidate='comdb2_unused_files')
 (candidate='comdb2_users')
 (candidate='comdb2_views')
 (candidate='abs()')

tests/cdb2sql.test/t00.expected

@@ -85,6 +85,7 @@ unknown @ls sub-command foo
 (name='comdb2_triggers')
 (name='comdb2_tunables')
 (name='comdb2_type_samples')
+(name='comdb2_unused_files')
 (name='comdb2_users')
 (name='comdb2_views')
 table name required

tests/comdb2_unused_files.test/Makefile

@@ -0,0 +1,9 @@
+ifeq ($(TESTSROOTDIR),)
+	include ../testcase.mk
+else
+	include $(TESTSROOTDIR)/testcase.mk
+endif
+
+ifeq ($(TEST_TIMEOUT),)
+	export TEST_TIMEOUT=5m
+endif

tests/comdb2_unused_files.test/README

@@ -0,0 +1 @@
+Simple test to verify that comdb2_unused_files is working