fix(test): harden network utils CI flakes and serialize infra shard

Avoid DNS-hijackable HTTP targets in tools network tests, initialize
Invoke-WithRetry timing locals under StrictMode, surface Quiet failure
lines, and run unit-profile-infra serially to avoid nested-runspace races.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: bolens

profile.d/utilities-modules/network/utilities-network-advanced.ps1

@@ -85,15 +85,20 @@ function Invoke-WithRetry {
 
         $powershell = $null
         $runspacePool = $null
+        # Initialize before try so StrictMode never sees an unset read if BeginInvoke fails mid-setup.
+        $timeoutMs = [Math]::Max(0, $TimeoutSeconds) * 1000
+        $pollIntervalMs = 50
+        $elapsedMs = 0
+        $completed = $false
 
         try {
             # Use runspace for timeout operation (much faster than job)
             $runspacePool = [runspacefactory]::CreateRunspacePool(1, 1)
             $runspacePool.Open()
-            
+
             $powershell = [PowerShell]::Create()
             $powershell.RunspacePool = $runspacePool
-            
+
             # Wrap the scriptblock to accept arguments
             $wrapperScript = {
                 param($ScriptBlock, $ArgumentList)
@@ -104,18 +109,13 @@ function Invoke-WithRetry {
                     & $ScriptBlock
                 }
             }
-            
+
             $null = $powershell.AddScript($wrapperScript)
             $null = $powershell.AddArgument($ScriptBlock)
             $null = $powershell.AddArgument($ArgumentList)
             $handle = $powershell.BeginInvoke()
 
             # Wait for completion or timeout using polling (STA-compatible)
-            $timeoutMs = $TimeoutSeconds * 1000
-            $pollIntervalMs = 50
-            $elapsedMs = 0
-            $completed = $false
-
             while ($elapsedMs -lt $timeoutMs) {
                 if ($handle.IsCompleted) {
                     $completed = $true
@@ -134,14 +134,17 @@ function Invoke-WithRetry {
                 throw "Operation timed out after $TimeoutSeconds seconds"
             }
 
-            # Get the result
+            # Get the result (EndInvoke returns Collection[PSObject]; unwrap single values)
             $result = $powershell.EndInvoke($handle)
             $powershell.Dispose()
             $runspacePool.Close()
             $runspacePool.Dispose()
             $powershell = $null
             $runspacePool = $null
 
+            if ($null -ne $result -and $result -is [System.Collections.IList] -and $result.Count -eq 1) {
+                return $result[0]
+            }
             return $result
 
         }

scripts/utils/code-quality/run-pester-ci-shard.ps1

@@ -133,7 +133,7 @@ function Get-PesterCiShardDefinitions {
     'unit-profile-core-files'    = @{ Kind = 'Pester'; Suite = 'Unit'; Paths = @('tests/unit/profile/files'); MaxParallelThreads = 1 }
     'unit-profile-core-boot-main' = @{ Kind = 'Pester'; Suite = 'Unit'; Paths = @('tests/unit/profile/bootstrap', 'tests/unit/profile/main'); MaxParallelThreads = 1 }
     'unit-profile-core-git-util-sys' = @{ Kind = 'Pester'; Suite = 'Unit'; Paths = @('tests/unit/profile/git', 'tests/unit/profile/utilities', 'tests/unit/profile/system'); MaxParallelThreads = 1 }
-    'unit-profile-infra'         = @{ Kind = 'Pester'; Suite = 'Unit'; Paths = $unitProfileInfra }
+    'unit-profile-infra'         = @{ Kind = 'Pester'; Suite = 'Unit'; Paths = $unitProfileInfra; MaxParallelThreads = 1 }
     'unit-profile-misc-a'        = @{ Kind = 'Pester'; Suite = 'Unit'; Paths = $miscA; MaxParallelThreads = 1 }
     'unit-profile-misc-b'        = @{ Kind = 'Pester'; Suite = 'Unit'; Paths = $miscB; MaxParallelThreads = 1 }
     'integration-tools-a'        = @{ Kind = 'ToolsBatch'; NamePattern = '^[0-9a-d]' }

scripts/utils/code-quality/run-tools-integration-batch.ps1

@@ -197,6 +197,11 @@ foreach ($file in $files) {
 
     $color = if ($stats.Failed -gt 0) { 'Red' } elseif ($stats.Passed -ge 0) { 'Green' } else { 'Yellow' }
     Write-Host "  $($stats.Passed)P / $($stats.Failed)F / $($stats.Skipped)S" -ForegroundColor $color
+    if ($stats.Failed -gt 0) {
+        [regex]::Matches($run.Output, '(?m)^\s+\[-\].*') | Select-Object -First 5 | ForEach-Object {
+            Write-Host "    $($_.Value.Trim())" -ForegroundColor DarkRed
+        }
+    }
 }
 
 Write-Host ''

tests/integration/tools/network/utils.tests.ps1

@@ -113,17 +113,13 @@ Describe 'Network Utils Module' {
 
     Context 'Invoke-HttpRequestWithRetry' {
         It 'function exists and can be called' {
-            Get-Command Invoke-HttpRequestWithRetry -CommandType Function -ErrorAction SilentlyContinue | Should -Not -Be $null
-            # Function uses System.Net.WebRequest directly, so we test that it handles errors gracefully
-            # Test with invalid URL that will fail quickly
-            $result = Invoke-HttpRequestWithRetry -Uri "http://invalid.url.invalid" -Method "GET" -TimeoutSeconds 1 -MaxRetries 1 -ErrorAction SilentlyContinue
-            # Result should be false (request failed) but function should not throw
-            { Invoke-HttpRequestWithRetry -Uri "http://invalid.url.invalid" -Method "GET" -TimeoutSeconds 1 -MaxRetries 1 -ErrorAction SilentlyContinue } | Should -Not -Throw
+            Get-Command Invoke-HttpRequestWithRetry -CommandType Function -ErrorAction SilentlyContinue | Should -Not -BeNullOrEmpty
+            # Closed local port — avoid fake DNS names that CI resolvers may hijack.
+            { Invoke-HttpRequestWithRetry -Uri 'http://127.0.0.1:1/' -Method 'GET' -TimeoutSeconds 1 -MaxRetries 1 -ErrorAction SilentlyContinue } | Should -Not -Throw
         }
 
         It 'handles HTTP request failure gracefully' {
-            # Test with invalid URL that will fail
-            $result = Invoke-HttpRequestWithRetry -Uri "http://invalid.url.invalid" -Method "GET" -TimeoutSeconds 1 -MaxRetries 1 -ErrorAction SilentlyContinue
+            $result = Invoke-HttpRequestWithRetry -Uri 'http://127.0.0.1:1/' -Method 'GET' -TimeoutSeconds 1 -MaxRetries 1 -ErrorAction SilentlyContinue
             # Failure may surface as $false or $null depending on retry/timeout behavior
             @($false, $null) | Should -Contain $result
         }
@@ -148,7 +144,7 @@ Describe 'Network Utils Module' {
 
             $result = Resolve-HostWithRetry -HostName 'example.com'
             $result | Should -Not -BeNullOrEmpty
-            $result.HostName | Should -Match '(?i)^example\.com\.?$'
+            @($result)[0].HostName | Should -Match '(?i)^example\.com\.?$'
         }
 
         It 'handles DNS resolution failure' {
@@ -162,9 +158,9 @@ Describe 'Network Utils Module' {
     }
 
     AfterEach {
-        # Resolve-HostWithRetry stubs Invoke-WithRetry; clear so later files stay isolated.
-        if (Get-Command Clear-CommandTestStubs -ErrorAction SilentlyContinue) {
-            Clear-CommandTestStubs
+        # Resolve-HostWithRetry stubs Invoke-WithRetry; restore the real implementation.
+        if (Get-Command Restore-TestProfileFunctionStubs -ErrorAction SilentlyContinue) {
+            Restore-TestProfileFunctionStubs
         }
     }
 }

tests/unit/profile/network/profile-network-utils-fragment-extended.tests.ps1

@@ -40,8 +40,8 @@ Describe 'profile.d/network-utils.ps1 extended scenarios' {
     It 'Invoke-WithRetry executes without error for a simple script block' {
         . (Join-Path $script:ProfileDir 'network-utils.ps1')
 
-        $result = Invoke-WithRetry -ScriptBlock { 'network-utils probe' } -MaxRetries 1
-        $result | Should -Be 'network-utils probe'
+        $result = Invoke-WithRetry -ScriptBlock { 'network-utils probe' } -MaxRetries 1 -TimeoutSeconds 5 -RetryDelaySeconds 0
+        @($result)[0] | Should -Be 'network-utils probe'
     }
 
     It 'Skips re-initialization when network utilities are already loaded' {