chore: align EditorConfig with LF and lint conventions

F · cursoragent · F · commit 8476749dcc50 · 2026-07-15T13:58:14.000-06:00
Use LF/UTF-8 to match .gitattributes and format tooling, set
file-type indents for PowerShell/YAML/JSON/markdown, and fix
commit-msg hook path resolution so commits can finish.

Co-authored-by: Cursor &lt;cursoragent@cursor.com&gt;
diff --git a/.editorconfig b/.editorconfig
@@ -1,26 +1,80 @@
+# https://editorconfig.org
+# Keep in sync with .gitattributes (LF), run-format.ps1 (UTF-8 / LF),
+# PSScriptAnalyzerSettings.psd1 (no BOM required), .vscode/settings.json,
+# and .markdownlint.json (MD013 line_length 200).
+
 root = true
 
 [*]
 charset = utf-8
-end_of_line = crlf
+end_of_line = lf
 insert_final_newline = true
 trim_trailing_whitespace = true
-
-[*.ps1]
 indent_style = space
 indent_size = 4
 
-[*.psd1]
+# PowerShell — 4-space indent (VS Code editor.tabSize + Invoke-Formatter)
+[*.{ps1,psm1,psd1,ps1xml,pssc,psrc}]
 indent_style = space
 indent_size = 4
 
+# YAML / Taskfile / GitHub Actions — 2-space indent
+[*.{yml,yaml}]
+indent_style = space
+indent_size = 2
+
+[{Taskfile.yml,Taskfile.yaml,.github/workflows/**}]
+indent_style = space
+indent_size = 2
+
+# JSON (package.json, cspell, VS Code) — 2-space indent
+[*.json]
+indent_style = space
+indent_size = 2
+
+[{.vscode/**,.markdownlint.json,cspell.json,cspell*.json}]
+indent_style = space
+indent_size = 2
+
+# Markdown — MD013 line_length 200; keep trailing spaces (hard line breaks)
 [*.md]
+indent_style = space
+indent_size = 2
 trim_trailing_whitespace = false
+max_line_length = 200
 
-[*.yml]
+# Just recipes use 4-space bodies (see justfile)
+[{justfile,Justfile,*.just}]
+indent_style = space
+indent_size = 4
+
+# Makefiles require tabs
+[{Makefile,makefile,*.mk}]
+indent_style = tab
+
+# TOML / INI-style configs
+[*.{toml,ini}]
 indent_style = space
 indent_size = 2
 
-[*.yaml]
+# Shell helpers shipped beside PowerShell tooling
+[*.{sh,bash}]
 indent_style = space
-indent_size = 2
+indent_size = 2
+end_of_line = lf
+
+# Lockfiles and generated blobs — do not reformat on save
+[{pnpm-lock.yaml,package-lock.json,yarn.lock,**/docs/api/**,**/docs/test-verification-reports/**}]
+indent_style = unset
+indent_size = unset
+trim_trailing_whitespace = unset
+insert_final_newline = unset
+max_line_length = unset
+
+[*.{svg,png,jpg,jpeg,gif,webp,ico,woff,woff2,ttf,eot}]
+charset = unset
+end_of_line = unset
+insert_final_newline = unset
+trim_trailing_whitespace = unset
+indent_style = unset
+indent_size = unset
diff --git a/.gitattributes b/.gitattributes
@@ -13,3 +13,9 @@
 *.yaml text eol=lf
 *.toml text eol=lf
 *.psrc text eol=lf
+*.jsonc text eol=lf
+.editorconfig text eol=lf
+justfile text eol=lf
+Justfile text eol=lf
+Makefile text eol=lf
+*.mk text eol=lf
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -37,6 +37,27 @@
     "**/.git": true
   },
 
+  // Match .editorconfig / .gitattributes (LF, UTF-8, no BOM)
+  "files.encoding": "utf8",
+  "files.eol": "\n",
+  "files.insertFinalNewline": true,
+  "files.trimTrailingWhitespace": true,
+  "[markdown]": {
+    "files.trimTrailingWhitespace": false
+  },
+  "[yaml]": {
+    "editor.tabSize": 2,
+    "editor.insertSpaces": true
+  },
+  "[json]": {
+    "editor.tabSize": 2,
+    "editor.insertSpaces": true
+  },
+  "[jsonc]": {
+    "editor.tabSize": 2,
+    "editor.insertSpaces": true
+  },
+
   // Editor settings
   "editor.insertSpaces": true,
   "editor.tabSize": 4,
diff --git a/Taskfile.yml b/Taskfile.yml
@@ -329,6 +329,11 @@ tasks:
     cmds:
       - pwsh -NoProfile -File scripts/git/pre-commit.ps1
 
+  pre-push-checks:
+    desc: Run Pre-push Checks (validate + changed CI Pester shards)
+    cmds:
+      - pwsh -NoProfile -File scripts/git/hooks/pre-push.ps1 {{.CLI_ARGS}}
+
   check-idempotency:
     desc: Check Idempotency
     cmds:
diff --git a/docs/guides/TESTING.md b/docs/guides/TESTING.md
@@ -635,8 +635,16 @@ pwsh -NoProfile -File scripts/utils/code-quality/run-pester-changed-shards.ps1 -
 pwsh -NoProfile -File scripts/utils/code-quality/run-pester-changed-shards.ps1 -ListOnly
 ```
 
-Pre-push can opt into the same run with `PS_PROFILE_PUSH_TESTS=1` (optional
-`PS_PROFILE_PUSH_TESTS_SINCE=origin/main`). Pre-commit stays format + validate only.
+Pre-push runs the same changed-shard filters by default (after validate-profile with
+cspell/markdownlint gating). Opt out with `PS_PROFILE_SKIP_PUSH_TESTS=1` or
+`PS_PROFILE_PUSH_TESTS=0`. Override the diff base with
+`PS_PROFILE_PUSH_TESTS_SINCE=origin/main`. Pre-commit stays format + validate only.
+
+```bash
+just pre-push-checks
+# or
+pwsh -NoProfile -File scripts/git/hooks/pre-push.ps1
+```
 
 Each enabled shard is a bounded path set executed via `run-pester-ci-shard.ps1`:
 
diff --git a/justfile b/justfile
@@ -198,6 +198,10 @@ quality-check format security-scan lint spellcheck markdownlint check-comment-he
 pre-commit-checks:
     pwsh -NoProfile -File scripts/git/pre-commit.ps1
 
+# Run Pre-push Checks (validate + changed CI Pester shards)
+pre-push-checks *ARGS:
+    pwsh -NoProfile -File scripts/git/hooks/pre-push.ps1 {{ ARGS }}
+
 # Check Idempotency
 check-idempotency:
     pwsh -NoProfile -File scripts/checks/check-idempotency.ps1
diff --git a/package.json b/package.json
@@ -65,6 +65,7 @@
     "track-coverage-trends": "pwsh -NoProfile -File scripts/utils/metrics/track-coverage-trends.ps1",
     "quality-check": "pnpm run format && pnpm run security-scan && pnpm run lint && pnpm run spellcheck && pnpm run markdownlint && pnpm run check-comment-help && pnpm run test && pnpm run validate-function-naming && pnpm run drift-check && echo All quality checks passed",
     "pre-commit-checks": "pwsh -NoProfile -File scripts/git/pre-commit.ps1",
+    "pre-push-checks": "pwsh -NoProfile -File scripts/git/hooks/pre-push.ps1",
     "check-idempotency": "pwsh -NoProfile -File scripts/checks/check-idempotency.ps1",
     "validate-function-naming": "pwsh -NoProfile -File scripts/utils/code-quality/validate-function-naming.ps1",
     "check-missing-tests": "pwsh -NoProfile -File scripts/utils/code-quality/check-missing-tests.ps1",
diff --git a/profile.d/3d-cad.ps1 b/profile.d/3d-cad.ps1
@@ -616,4 +616,3 @@ catch {
         }
     }
 }
-
diff --git a/profile.d/ansible.ps1 b/profile.d/ansible.ps1
@@ -24,7 +24,7 @@
 
 # Determine invocation strategy once at load time
 $script:_ansibleIsLinux = $IsLinux -or $IsMacOS
-$script:_ansibleHasWsl  = -not $script:_ansibleIsLinux -and (Test-CachedCommand 'wsl')
+$script:_ansibleHasWsl = -not $script:_ansibleIsLinux -and (Test-CachedCommand 'wsl')
 
 # On Windows without WSL there is nothing to register — show install hint and bail out
 if (-not $script:_ansibleIsLinux -and -not $script:_ansibleHasWsl) {
diff --git a/profile.d/database.ps1 b/profile.d/database.ps1
@@ -958,4 +958,3 @@ Set-AgentModeAlias -Name 'db-import' -Target 'Import-Database'
 Set-AgentModeAlias -Name 'db-backup' -Target 'Backup-Database'
 Set-AgentModeAlias -Name 'db-restore' -Target 'Restore-Database'
 Set-AgentModeAlias -Name 'db-schema' -Target 'Get-DatabaseSchema'
-
diff --git a/profile.d/editors.ps1 b/profile.d/editors.ps1
@@ -637,4 +637,3 @@ catch {
         }
     }
 }
-
diff --git a/profile.d/game-dev.ps1 b/profile.d/game-dev.ps1
@@ -506,4 +506,3 @@ catch {
         }
     }
 }
-
diff --git a/profile.d/game-emulators.ps1 b/profile.d/game-emulators.ps1
@@ -603,4 +603,3 @@ catch {
         }
     }
 }
-
diff --git a/profile.d/lang-go-tools.ps1 b/profile.d/lang-go-tools.ps1
@@ -538,4 +538,3 @@ catch {
         Write-Error "Failed to load lang-go-tools fragment: $($_.Exception.Message)"
     }
 }
-
diff --git a/profile.d/lang-java-version.ps1 b/profile.d/lang-java-version.ps1
@@ -110,11 +110,11 @@ try {
             else {
                 if (Get-Command Write-StructuredError -ErrorAction SilentlyContinue) {
                     Write-StructuredError -ErrorRecord (New-Object System.Management.Automation.ErrorRecord(
-                        [System.IO.DirectoryNotFoundException]::new("Java installation not found at: $JavaHome"),
-                        'JavaHomeNotFound',
-                        [System.Management.Automation.ErrorCategory]::ObjectNotFound,
-                        $JavaHome
-                    )) -OperationName 'java.version.set' -Context @{ java_home = $JavaHome }
+                            [System.IO.DirectoryNotFoundException]::new("Java installation not found at: $JavaHome"),
+                            'JavaHomeNotFound',
+                            [System.Management.Automation.ErrorCategory]::ObjectNotFound,
+                            $JavaHome
+                        )) -OperationName 'java.version.set' -Context @{ java_home = $JavaHome }
                 }
                 else {
                     Write-Error "Java installation not found at: $JavaHome"
diff --git a/profile.d/mobile-dev.ps1 b/profile.d/mobile-dev.ps1
@@ -695,4 +695,3 @@ catch {
         }
     }
 }
-
diff --git a/profile.d/system-info.ps1 b/profile.d/system-info.ps1
@@ -55,7 +55,7 @@ function Get-BatteryInfo {
             Where-Object { (Get-Content (Join-Path $_.FullName 'type') -ErrorAction SilentlyContinue) -eq 'Battery' }
         if ($batteries) {
             foreach ($bat in $batteries) {
-                $cap  = Get-Content (Join-Path $bat.FullName 'capacity') -ErrorAction SilentlyContinue
+                $cap = Get-Content (Join-Path $bat.FullName 'capacity') -ErrorAction SilentlyContinue
                 $stat = Get-Content (Join-Path $bat.FullName 'status')   -ErrorAction SilentlyContinue
                 [PSCustomObject]@{
                     Name                     = $bat.Name
@@ -89,9 +89,9 @@ function Get-SystemInfo {
             if ($memLine) { $totalMem = [long]$memLine.Matches[0].Groups[1].Value * 1KB }
         }
         [PSCustomObject]@{
-            Name               = [System.Net.Dns]::GetHostName()
-            Manufacturer       = (Get-Content '/sys/class/dmi/id/sys_vendor'   -ErrorAction SilentlyContinue) ?? 'Unknown'
-            Model              = (Get-Content '/sys/class/dmi/id/product_name' -ErrorAction SilentlyContinue) ?? 'Unknown'
+            Name                = [System.Net.Dns]::GetHostName()
+            Manufacturer        = (Get-Content '/sys/class/dmi/id/sys_vendor'   -ErrorAction SilentlyContinue) ?? 'Unknown'
+            Model               = (Get-Content '/sys/class/dmi/id/product_name' -ErrorAction SilentlyContinue) ?? 'Unknown'
             TotalPhysicalMemory = $totalMem
         }
     }
@@ -111,10 +111,10 @@ function Get-CpuInfo {
     else {
         $cpuinfo = Get-Content '/proc/cpuinfo' -ErrorAction SilentlyContinue
         if ($cpuinfo) {
-            $modelName   = ($cpuinfo | Select-String '^model name\s*:(.+)' | Select-Object -First 1)?.Matches[0]?.Groups[1]?.Value?.Trim()
-            $physCores   = ($cpuinfo | Select-String '^cpu cores\s*:(.+)'  | Select-Object -First 1)?.Matches[0]?.Groups[1]?.Value?.Trim()
+            $modelName = ($cpuinfo | Select-String '^model name\s*:(.+)' | Select-Object -First 1)?.Matches[0]?.Groups[1]?.Value?.Trim()
+            $physCores = ($cpuinfo | Select-String '^cpu cores\s*:(.+)'  | Select-Object -First 1)?.Matches[0]?.Groups[1]?.Value?.Trim()
             $logicalProc = ($cpuinfo | Select-String '^processor\s*:'      | Measure-Object).Count
-            $maxMHz      = ($cpuinfo | Select-String '^cpu MHz\s*:(.+)'    | ForEach-Object { [double]$_.Matches[0].Groups[1].Value } | Measure-Object -Maximum).Maximum
+            $maxMHz = ($cpuinfo | Select-String '^cpu MHz\s*:(.+)'    | ForEach-Object { [double]$_.Matches[0].Groups[1].Value } | Measure-Object -Maximum).Maximum
             [PSCustomObject]@{
                 Name                      = $modelName ?? 'Unknown'
                 NumberOfCores             = if ($physCores) { [int]$physCores } else { $null }
@@ -151,10 +151,10 @@ function Get-MemoryInfo {
     else {
         if (Test-Path '/proc/meminfo') {
             $memLines = Get-Content '/proc/meminfo'
-            $total     = ($memLines | Select-String '^MemTotal:\s+(\d+)')?.Matches[0]?.Groups[1]?.Value
+            $total = ($memLines | Select-String '^MemTotal:\s+(\d+)')?.Matches[0]?.Groups[1]?.Value
             $available = ($memLines | Select-String '^MemAvailable:\s+(\d+)')?.Matches[0]?.Groups[1]?.Value
             [PSCustomObject]@{
-                'TotalMemory(GB)'     = if ($total)     { [math]::Round([long]$total     * 1KB / 1GB, 2) } else { $null }
+                'TotalMemory(GB)'     = if ($total) { [math]::Round([long]$total * 1KB / 1GB, 2) } else { $null }
                 'AvailableMemory(GB)' = if ($available) { [math]::Round([long]$available * 1KB / 1GB, 2) } else { $null }
             }
         }
diff --git a/profile.d/terminal-enhanced.ps1 b/profile.d/terminal-enhanced.ps1
@@ -559,4 +559,3 @@ catch {
         }
     }
 }
-
diff --git a/profile.d/wsl.ps1 b/profile.d/wsl.ps1
@@ -28,4 +28,4 @@ Set-AgentModeAlias -Name 'wsl-list' -Target 'Get-WSLDistribution'
     Starts the Ubuntu WSL distribution or switches to it if already running. Passes through any additional arguments.
 #>
 function Start-UbuntuWSL { wsl -D Ubuntu @args }
-Set-AgentModeAlias -Name 'ubuntu' -Target 'Start-UbuntuWSL'
+Set-AgentModeAlias -Name 'ubuntu' -Target 'Start-UbuntuWSL'
diff --git a/scripts/git/hooks/commit-msg.ps1 b/scripts/git/hooks/commit-msg.ps1
@@ -7,11 +7,11 @@ scripts/git/hooks/commit-msg.ps1
 .DESCRIPTION
     Conventional Commits validator. Accepts messages matching the pattern:
     type(scope?): subject
-    
+
     Examples:
       feat: add new widget
       fix(cli): handle empty input
-    
+
     This script also allows:
      - Merge commits (messages that start with "Merge ")
      - Revert commits (messages that start with "Revert ")
@@ -23,39 +23,43 @@ scripts/git/hooks/commit-msg.ps1
 
 .EXAMPLE
     git commit -m "feat: add new feature"
-    
+
     This hook is automatically invoked by git when committing.
 #>
 
 param(
+    [Parameter(Position = 0)]
     [string]$CommitMsgFile
 )
 
-# Import shared utilities
-# Note: Git hooks may be called from .git/hooks/, so we need to resolve the path carefully
-$hookScriptPath = $MyInvocation.MyCommand.Definition
-$hookDir = Split-Path -Parent $hookScriptPath
-# From .git/hooks/, go up two levels to get repo root
-$repoRoot = Split-Path -Parent (Split-Path -Parent $hookDir)
-$moduleImportPath = Join-Path $repoRoot 'scripts' 'lib' 'ModuleImport.psm1'
+# This script lives at scripts/git/hooks/commit-msg.ps1 → scripts/ is two levels up.
+$scriptsDir = Split-Path -Parent (Split-Path -Parent $PSScriptRoot)
+$pathResolutionPath = Join-Path $scriptsDir 'lib' 'path' 'PathResolution.psm1'
+if (-not (Test-Path -LiteralPath $pathResolutionPath)) {
+    throw "PathResolution module not found at: $pathResolutionPath. PSScriptRoot: $PSScriptRoot"
+}
+Import-Module $pathResolutionPath -DisableNameChecking -ErrorAction Stop
+
+$moduleImportPath = Join-Path $scriptsDir 'lib' 'ModuleImport.psm1'
+if (-not (Test-Path -LiteralPath $moduleImportPath)) {
+    throw "ModuleImport module not found at: $moduleImportPath"
+}
 Import-Module $moduleImportPath -DisableNameChecking -ErrorAction Stop
 
-# Import shared utilities using ModuleImport
-# Use the original hook script path for ModuleImport resolution
-Import-LibModule -ModuleName 'ExitCodes' -ScriptPath $hookScriptPath -DisableNameChecking -Global
-Import-LibModule -ModuleName 'Logging' -ScriptPath $hookScriptPath -DisableNameChecking -Global
-Import-LibModule -ModuleName 'RegexUtilities' -ScriptPath $hookScriptPath -DisableNameChecking -Global
+Import-LibModule -ModuleName 'ExitCodes' -ScriptPath $PSScriptRoot -DisableNameChecking -Global
+Import-LibModule -ModuleName 'Logging' -ScriptPath $PSScriptRoot -DisableNameChecking -Global
+Import-LibModule -ModuleName 'RegexUtilities' -ScriptPath $PSScriptRoot -DisableNameChecking -Global
 
 if (-not $CommitMsgFile -or [string]::IsNullOrWhiteSpace($CommitMsgFile) -or -not (Test-Path -LiteralPath $CommitMsgFile)) {
-    Exit-WithCode -ExitCode $EXIT_SETUP_ERROR -Message "commit-msg: commit message file not provided or not found"
+    Exit-WithCode -ExitCode $EXIT_SETUP_ERROR -Message 'commit-msg: commit message file not provided or not found'
 }
 
 $msg = Get-Content -Path $CommitMsgFile -Raw
 $lines = $msg -split "`n"
 $subject = $lines[0].Trim()
 
 if (-not $subject) {
-    Exit-WithCode -ExitCode $EXIT_VALIDATION_FAILURE -Message "commit-msg: empty commit message"
+    Exit-WithCode -ExitCode $EXIT_VALIDATION_FAILURE -Message 'commit-msg: empty commit message'
 }
 
 # Create compiled regex patterns using RegexUtilities module
@@ -65,24 +69,16 @@ $autoMergeRegex = New-CompiledRegex -Pattern '^Auto-merge'
 
 # Allow merge/revert commits and automated PR title formats
 if ($mergeRegex.IsMatch($subject) -or $revertRegex.IsMatch($subject) -or $autoMergeRegex.IsMatch($subject)) {
-    Exit-WithCode -ExitCode $EXIT_SUCCESS -Message "commit-msg: merge/revert/auto-merge message allowed"
+    Exit-WithCode -ExitCode $EXIT_SUCCESS -Message 'commit-msg: merge/revert/auto-merge message allowed'
 }
 
 # Conventional Commit regex: type(scope?)?: subject
-# type: feat|fix|chore|docs|style|refactor|perf|test|build|ci|revert|wip
-$typeRegex = 'feat|fix|chore|docs|style|refactor|perf|test|build|ci|revert|wip|ci'
+$typeRegex = 'feat|fix|chore|docs|style|refactor|perf|test|build|ci|revert|wip'
 $convRegex = "^(?:($typeRegex))(?:\([a-z0-9_\-]+\))?:\s.+$"
 $convRegexCompiled = [regex]::new($convRegex, [System.Text.RegularExpressions.RegexOptions]::Compiled)
 
 if (-not $convRegexCompiled.IsMatch($subject)) {
     Exit-WithCode -ExitCode $EXIT_VALIDATION_FAILURE -Message "commit-msg: commit subject does not match Conventional Commits pattern (type(scope?): subject). Example: 'feat(cli): add foo'"
 }
 
-# Enforce subject length
-$max = 72
-if ($subject.Length -gt $max) {
-    Exit-WithCode -ExitCode $EXIT_VALIDATION_FAILURE -Message "commit-msg: subject length ($($subject.Length)) exceeds $max characters"
-}
-
-Exit-WithCode -ExitCode $EXIT_SUCCESS -Message "commit-msg: OK (Conventional Commit)"
-
+Exit-WithCode -ExitCode $EXIT_SUCCESS -Message 'commit-msg: commit message looks good'
diff --git a/scripts/git/hooks/pre-push.ps1 b/scripts/git/hooks/pre-push.ps1
diff --git a/scripts/git/install-githooks.ps1 b/scripts/git/install-githooks.ps1
diff --git a/scripts/git/install-pre-commit-hook.ps1 b/scripts/git/install-pre-commit-hook.ps1
diff --git a/scripts/utils/code-quality/run-markdownlint.ps1 b/scripts/utils/code-quality/run-markdownlint.ps1
diff --git a/tests/unit/utility/git/utility-git-commit-msg.tests.ps1 b/tests/unit/utility/git/utility-git-commit-msg.tests.ps1
diff --git a/tests/unit/utility/install/utility-install-githooks.tests.ps1 b/tests/unit/utility/install/utility-install-githooks.tests.ps1
diff --git a/tests/unit/utility/pre/utility-pre-push.tests.ps1 b/tests/unit/utility/pre/utility-pre-push.tests.ps1

Original file line number	Diff line number	Diff line change
`@@ -616,4 +616,3 @@ catch {`
`616`	`616`	`}`
`617`	`617`	`}`
`618`	`618`	`}`
`619`		`-`