fix(test): keep unit/CI runs non-interactive

bolens · bolens · commit fbbece495eab · 2026-07-16T09:32:49.000-06:00
Pin Pester to 5.7.x, force -NonInteractive child pwsh, and refuse
auto-install paths that can hang waiting for input under tests.
diff --git a/.github/workflows/test-pester.yml b/.github/workflows/test-pester.yml
@@ -88,19 +88,20 @@ jobs:
             Register-PSRepository -Default
           }
           Set-PSRepository -Name PSGallery -InstallationPolicy Trusted
-          Install-Module -Name Pester -MinimumVersion 5.0.0 -MaximumVersion 5.99.99 -Force -Scope CurrentUser -AllowClobber
-          # Prefer 5.7.x when multiple 5.x builds are present; reject Pester 6+ (breaks coverage tracer teardown / mocks).
+          # Pin to 5.7.x: Pester 5.9+ regresses Mock scoping ("Mock data are not setup for this scope")
+          # and TestDrive collisions across sequential containers; Pester 6+ breaks tracer teardown.
+          Install-Module -Name Pester -MinimumVersion 5.7.0 -MaximumVersion 5.7.99 -Force -Scope CurrentUser -AllowClobber
           $pester5 = Get-Module -ListAvailable Pester |
-            Where-Object { $_.Version -ge [version]'5.0.0' -and $_.Version -lt [version]'6.0.0' } |
+            Where-Object { $_.Version -ge [version]'5.7.0' -and $_.Version -lt [version]'5.8.0' } |
             Sort-Object Version -Descending |
             Select-Object -First 1
-          if (-not $pester5) { throw 'Pester 5.x is required but was not installed' }
+          if (-not $pester5) { throw 'Pester 5.7.x is required but was not installed' }
           Import-Module Pester -RequiredVersion $pester5.Version -Force
           Write-Host "Installed Pester $($pester5.Version)"
       - name: Run Pester shard
         shell: pwsh
         run: |
-          pwsh -NoProfile -File scripts/utils/code-quality/run-pester-ci-shard.ps1 -Shard '${{ matrix.shard }}' -Quiet
+          pwsh -NoProfile -NonInteractive -File scripts/utils/code-quality/run-pester-ci-shard.ps1 -Shard '${{ matrix.shard }}' -Quiet
       - name: Upload test results
         if: always()
         uses: actions/upload-artifact@v7
diff --git a/scripts/utils/code-quality/run-pester-ci-shard.ps1 b/scripts/utils/code-quality/run-pester-ci-shard.ps1
@@ -44,6 +44,11 @@ param(
 
 Set-StrictMode -Version Latest
 $ErrorActionPreference = 'Stop'
+$ConfirmPreference = 'None'
+$global:ConfirmPreference = 'None'
+$env:PS_PROFILE_NONINTERACTIVE = '1'
+$env:PS_PROFILE_TEST_MODE = '1'
+$env:PS_PROFILE_SUPPRESS_CONFIRMATIONS = '1'
 
 $runner = Join-Path $RepoRoot 'scripts' 'utils' 'code-quality' 'run-pester.ps1'
 $toolsBatch = Join-Path $RepoRoot 'scripts' 'utils' 'code-quality' 'run-tools-integration-batch.ps1'
diff --git a/scripts/utils/code-quality/run-pester.ps1 b/scripts/utils/code-quality/run-pester.ps1
@@ -886,13 +886,13 @@ $global:ConfirmPreference = 'None'
 # Initialize output utilities
 Initialize-OutputUtils -RepoRoot $repoRoot
 
-# Ensure Pester 5.x is available and imported (Pester 6+ breaks CodeCoverage tracer teardown
-# when profile fragments install PostCommandLookupAction, and changes Mock ParameterFilter semantics).
-# Do NOT call Ensure-ModuleAvailable for Pester — Install-RequiredModule has no MaximumVersion and
-# may install Pester 6+. Install/import only the 5.x range explicitly.
+# Ensure Pester 5.7.x is available and imported.
+# - 5.9+ regresses Mock scoping ("Mock data are not setup for this scope") and TestDrive collisions
+# - 6+ breaks CodeCoverage tracer teardown when profile fragments install PostCommandLookupAction
+# Do NOT call Ensure-ModuleAvailable for Pester — Install-RequiredModule has no MaximumVersion.
 Write-Host "Checking Pester availability..." -ForegroundColor Yellow
-$requiredPesterVersion = [version]'5.0.0'
-$maxPesterVersion = [version]'5.99.99'
+$requiredPesterVersion = [version]'5.7.0'
+$maxPesterVersion = [version]'5.7.99'
 
 $installedPester = Get-Module -ListAvailable -Name 'Pester' |
     Where-Object { $_.Version -ge $requiredPesterVersion -and $_.Version -le $maxPesterVersion } |
@@ -1231,7 +1231,7 @@ try {
     # Handle Interactive mode
     if ($Interactive) {
         $interactiveInputAvailable = $false
-        if ($env:PS_PROFILE_NONINTERACTIVE -ne '1' -and $env:CI -ne 'true' -and $env:GITHUB_ACTIONS -ne 'true') {
+        if ($env:PS_PROFILE_NONINTERACTIVE -ne '1' -and $env:PS_PROFILE_TEST_MODE -ne '1' -and $env:CI -ne 'true' -and $env:GITHUB_ACTIONS -ne 'true') {
             try {
                 $interactiveInputAvailable = -not [Console]::IsInputRedirected
             }
diff --git a/scripts/utils/docs/generate-changelog.ps1 b/scripts/utils/docs/generate-changelog.ps1
@@ -92,6 +92,17 @@ Write-ScriptMessage -Message "Generating changelog..."
 $hasGitCliff = Test-CommandAvailable -CommandName 'git-cliff'
 
 if (-not $hasGitCliff) {
+    # Never auto-install in CI/unit tests — cargo/winget can prompt or run for minutes.
+    $nonInteractive = (
+        $env:PS_PROFILE_NONINTERACTIVE -eq '1' -or
+        $env:PS_PROFILE_TEST_MODE -eq '1' -or
+        $env:CI -eq 'true' -or
+        $env:GITHUB_ACTIONS -eq 'true'
+    )
+    if ($nonInteractive) {
+        Exit-WithCode -ExitCode $EXIT_SETUP_ERROR -Message 'git-cliff is required but not installed (auto-install disabled in non-interactive mode)'
+    }
+
     Write-ScriptMessage -Message "git-cliff not found. Installing..."
 
     # Try to install git-cliff
diff --git a/tests/TestSupport/TestExecution.ps1 b/tests/TestSupport/TestExecution.ps1
@@ -48,7 +48,8 @@ function Invoke-TestScriptFile {
     }
 
     try {
-        $output = & pwsh -NoProfile -File $ScriptPath @ArgumentList 2>&1 | Out-String
+        # Always non-interactive: unit/CI child scripts must never wait on Read-Host / ShouldProcess prompts.
+        $output = & pwsh -NoProfile -NonInteractive -File $ScriptPath @ArgumentList 2>&1 | Out-String
         return [pscustomobject]@{
             ExitCode = $LASTEXITCODE
             Output   = $output
@@ -80,6 +81,9 @@ function Invoke-TestPwshScript {
     $escapedRepoRoot = $repoRoot.Replace("'", "''")
     $scriptPrefix = @"
 `$env:PS_PROFILE_TEST_MODE = '1'
+`$env:PS_PROFILE_NONINTERACTIVE = '1'
+`$env:PS_PROFILE_SUPPRESS_CONFIRMATIONS = '1'
+`$ConfirmPreference = 'None'
 `$env:PS_PROFILE_REPO_ROOT = '$escapedRepoRoot'
 "@
 
@@ -110,7 +114,7 @@ function Invoke-TestPwshScript {
             throw "pwsh command not found. PowerShell Core must be installed to use this function."
         }
         
-        $output = & pwsh -NoProfile -File $tempFile 2>&1
+        $output = & pwsh -NoProfile -NonInteractive -File $tempFile 2>&1
         $exitCode = $LASTEXITCODE
         
         if ($exitCode -ne 0) {
diff --git a/tests/unit/library/chocolatey/library-chocolatey-detection-extended.tests.ps1 b/tests/unit/library/chocolatey/library-chocolatey-detection-extended.tests.ps1
@@ -42,6 +42,46 @@ function script:Clear-ChocolateyTestEnvironment {
     }
 }
 
+function script:Disable-ChocolateyDefaultLocations {
+    <#
+    .SYNOPSIS
+        Isolate detection from a host Chocolatey install (ProgramData + hardcoded fallback).
+    #>
+    $emptyProgramData = Join-Path $script:TempDir 'empty-programdata'
+    if (-not (Test-Path -LiteralPath $emptyProgramData)) {
+        New-Item -ItemType Directory -Path $emptyProgramData -Force | Out-Null
+    }
+    Mock-EnvironmentVariable -Name 'ProgramData' -Value $emptyProgramData
+
+    Mock Get-Command {
+        $cmdName = $Name
+        if ([string]::IsNullOrWhiteSpace($cmdName) -and $args.Count -gt 0) {
+            $cmdName = [string]$args[0]
+        }
+        if ($cmdName -eq 'Test-ValidPath') {
+            return $null
+        }
+        return Microsoft.PowerShell.Core\Get-Command @PSBoundParameters
+    } -ModuleName ChocolateyDetection
+
+    Mock Test-Path {
+        $target = $null
+        if ($PSBoundParameters.ContainsKey('LiteralPath') -and $LiteralPath) {
+            $target = [string]$LiteralPath
+        }
+        elseif ($PSBoundParameters.ContainsKey('Path') -and $Path) {
+            $target = [string]$Path
+        }
+        elseif ($args.Count -gt 0) {
+            $target = [string]$args[0]
+        }
+        if ($target -eq 'C:\ProgramData\chocolatey') {
+            return $false
+        }
+        return Microsoft.PowerShell.Management\Test-Path @PSBoundParameters
+    } -ModuleName ChocolateyDetection
+}
+
 AfterAll {
     Clear-ChocolateyTestEnvironment
     if ($script:TempDir -and (Test-Path -LiteralPath $script:TempDir)) {
@@ -99,6 +139,7 @@ Describe 'ChocolateyDetection extended scenarios' {
             $filePath = Join-Path $script:TempDir 'missing-choco.txt'
             New-Item -ItemType File -Path $filePath -Force | Out-Null
             Mock-EnvironmentVariable -Name 'ChocolateyInstall' -Value $filePath
+            Disable-ChocolateyDefaultLocations
 
             Get-ChocolateyRoot | Should -BeNullOrEmpty
         }
@@ -154,6 +195,7 @@ Describe 'ChocolateyDetection extended scenarios' {
 
         It 'Logs verbose output when no Chocolatey root is found at debug level 2' {
             Mock-EnvironmentVariable -Name 'ChocolateyInstall' -Value $null
+            Disable-ChocolateyDefaultLocations
             $env:PS_PROFILE_DEBUG = '2'
 
             Get-ChocolateyRoot | Should -BeNullOrEmpty
diff --git a/tests/unit/library/chocolatey/library-chocolatey-detection.tests.ps1 b/tests/unit/library/chocolatey/library-chocolatey-detection.tests.ps1
@@ -36,6 +36,47 @@ AfterAll {
     }
 }
 
+function script:Disable-ChocolateyDefaultLocations {
+    <#
+    .SYNOPSIS
+        Point ProgramData at an empty temp dir and block the hardcoded C:\ProgramData\chocolatey fallback.
+    #>
+    $emptyProgramData = Join-Path $script:TempDir 'empty-programdata'
+    if (-not (Test-Path -LiteralPath $emptyProgramData)) {
+        New-Item -ItemType Directory -Path $emptyProgramData -Force | Out-Null
+    }
+    Mock-EnvironmentVariable -Name 'ProgramData' -Value $emptyProgramData
+
+    # Prefer Test-Path fallbacks so the hardcoded path mock below is effective.
+    Mock Get-Command {
+        $cmdName = $Name
+        if ([string]::IsNullOrWhiteSpace($cmdName) -and $args.Count -gt 0) {
+            $cmdName = [string]$args[0]
+        }
+        if ($cmdName -eq 'Test-ValidPath') {
+            return $null
+        }
+        return Microsoft.PowerShell.Core\Get-Command @PSBoundParameters
+    } -ModuleName ChocolateyDetection
+
+    Mock Test-Path {
+        $target = $null
+        if ($PSBoundParameters.ContainsKey('LiteralPath') -and $LiteralPath) {
+            $target = [string]$LiteralPath
+        }
+        elseif ($PSBoundParameters.ContainsKey('Path') -and $Path) {
+            $target = [string]$Path
+        }
+        elseif ($args.Count -gt 0) {
+            $target = [string]$args[0]
+        }
+        if ($target -eq 'C:\ProgramData\chocolatey') {
+            return $false
+        }
+        return Microsoft.PowerShell.Management\Test-Path @PSBoundParameters
+    } -ModuleName ChocolateyDetection
+}
+
 Describe 'ChocolateyDetection Module' {
     Context 'Get-ChocolateyRoot' {
         AfterEach {
@@ -46,6 +87,7 @@ Describe 'ChocolateyDetection Module' {
 
         It 'Returns null when no Chocolatey installation is present' {
             Mock-EnvironmentVariable -Name 'ChocolateyInstall' -Value $null
+            Disable-ChocolateyDefaultLocations
             Get-ChocolateyRoot | Should -BeNullOrEmpty
         }
 
@@ -72,6 +114,7 @@ Describe 'ChocolateyDetection Module' {
 
         It 'Returns null when Chocolatey root cannot be determined' {
             Mock-EnvironmentVariable -Name 'ChocolateyInstall' -Value $null
+            Disable-ChocolateyDefaultLocations
 
             Get-ChocolateyLibPath | Should -BeNullOrEmpty
             Get-ChocolateyBinPath | Should -BeNullOrEmpty
diff --git a/tests/unit/library/command/library-command-extended.tests.ps1 b/tests/unit/library/command/library-command-extended.tests.ps1
@@ -86,13 +86,25 @@ Describe 'Command extended scenarios' {
         }
 
         It 'Selects the Linux install command from a platform map' {
-            $installMap = @{
-                Windows = 'winget install Example'
-                Linux   = 'apt-get install -y example'
-                macOS   = 'brew install example'
-            }
+            $previousPlatform = $env:PS_PROFILE_PLATFORM_FORCE_NAME
+            $env:PS_PROFILE_PLATFORM_FORCE_NAME = 'Linux'
+            try {
+                $installMap = @{
+                    Windows = 'winget install Example'
+                    Linux   = 'apt-get install -y example'
+                    macOS   = 'brew install example'
+                }
 
-            Resolve-InstallCommand -InstallCommand $installMap | Should -Be 'apt-get install -y example'
+                Resolve-InstallCommand -InstallCommand $installMap | Should -Be 'apt-get install -y example'
+            }
+            finally {
+                if ($null -eq $previousPlatform) {
+                    Remove-Item Env:PS_PROFILE_PLATFORM_FORCE_NAME -ErrorAction SilentlyContinue
+                }
+                else {
+                    $env:PS_PROFILE_PLATFORM_FORCE_NAME = $previousPlatform
+                }
+            }
         }
     }
 
@@ -585,15 +597,26 @@ Describe 'Command extended scenarios' {
                     ExternalTools = @{
                         'demo-tool' = @{
                             InstallCommand = @{
-                                Linux = 'apt install demo-tool'
+                                Windows = 'winget install demo-tool'
+                                Linux   = 'apt install demo-tool'
                             }
                         }
                     }
                 }
             }
 
+            $expected = if ($IsWindows -or $PSVersionTable.PSVersion.Major -lt 6) {
+                'Install with: winget install demo-tool'
+            }
+            elseif ($IsLinux) {
+                'Install with: apt install demo-tool'
+            }
+            else {
+                'Install with: scoop install demo-tool'
+            }
+
             Get-ToolInstallHint -ToolName 'demo-tool' -RepoRoot '/tmp/demo-repo' |
-                Should -Be 'Install with: apt install demo-tool'
+                Should -Be $expected
         }
 
         It 'Returns default hint when resolved install command is empty' {
diff --git a/tests/unit/library/envfile/library-envfile-extended.tests.ps1 b/tests/unit/library/envfile/library-envfile-extended.tests.ps1
@@ -282,9 +282,20 @@ QUOTED_DOUBLE="say \"hello\""
             $repoRoot = Join-Path $script:TempRoot 'walk-git-repo'
             $nestedDir = Join-Path $repoRoot 'nested' 'deep'
             New-Item -ItemType Directory -Path $nestedDir -Force | Out-Null
-            New-Item -ItemType File -Path (Join-Path $repoRoot '.git') -Force | Out-Null
+            New-Item -ItemType Directory -Path (Join-Path $repoRoot '.git') -Force | Out-Null
             'WALK_VAR=detected' | Set-Content -LiteralPath (Join-Path $repoRoot '.env') -Encoding UTF8
 
+            # Force the cwd walk path: ignore checkout Get-RepoRoot / $Profile resolution.
+            function global:Get-RepoRoot {
+                param([string]$ScriptPath)
+                throw 'forced miss for Initialize-EnvFiles walk fixture'
+            }
+            $hadProfile = Test-Path Variable:\global:Profile
+            $savedProfile = if ($hadProfile) { $global:Profile } else { $null }
+            if ($hadProfile) {
+                Remove-Variable -Name Profile -Scope Global -ErrorAction SilentlyContinue
+            }
+
             $previousLocation = Get-Location
             try {
                 Set-Location -LiteralPath $nestedDir
@@ -294,6 +305,10 @@ QUOTED_DOUBLE="say \"hello\""
             finally {
                 Set-Location -LiteralPath $previousLocation.Path
                 Remove-Item Env:\WALK_VAR -ErrorAction SilentlyContinue
+                Remove-TestFunction -Name 'Get-RepoRoot'
+                if ($hadProfile) {
+                    Set-Variable -Name Profile -Scope Global -Value $savedProfile
+                }
             }
         }
 
diff --git a/tests/unit/library/file/library-file-content-extended.tests.ps1 b/tests/unit/library/file/library-file-content-extended.tests.ps1
@@ -37,7 +37,7 @@ Describe 'FileContent extended scenarios' {
             $file = Join-Path $script:TempRoot 'present.txt'
             Set-Content -LiteralPath $file -Value 'payload' -Encoding UTF8
 
-            Read-FileContentOrNull -Path $file | Should -Match '^payload$'
+            Read-FileContentOrNull -Path $file | Should -Match '^payload\r?$'
         }
 
         It 'Returns null for missing files' {
diff --git a/tests/unit/library/fragment/library-fragment-loading-extended.tests.ps1 b/tests/unit/library/fragment/library-fragment-loading-extended.tests.ps1
diff --git a/tests/unit/library/security/library-security-scanner.tests.ps1 b/tests/unit/library/security/library-security-scanner.tests.ps1
diff --git a/tests/unit/library/task/library-task-parity-utilities.tests.ps1 b/tests/unit/library/task/library-task-parity-utilities.tests.ps1
diff --git a/tests/unit/utility/generate/utility-generate-changelog.tests.ps1 b/tests/unit/utility/generate/utility-generate-changelog.tests.ps1

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ Describe 'FileContent extended scenarios' {`
`37`	`37`	`$file = Join-Path $script:TempRoot 'present.txt'`
`38`	`38`	`Set-Content -LiteralPath $file -Value 'payload' -Encoding UTF8`
`39`	`39`
`40`		`- Read-FileContentOrNull -Path $file \| Should -Match '^payload$'`
	`40`	`+ Read-FileContentOrNull -Path $file \| Should -Match '^payload\r?$'`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`It 'Returns null for missing files' {`