fix error on search result with two identical titles (#324)

* fix error on search result with two identical titles

* remove slugs

Author: bonukai

server/__tests__/repository/mediaItem/mediaItem.test.ts

@@ -277,7 +277,6 @@ describe('mediaItemRepository', () => {
         source: 'user',
         mediaType: 'tv',
         title: 'Item 1',
-        slug: 'item-1',
         poster: 'poster',
         backdrop: 'backdrop',
       },
@@ -287,15 +286,13 @@ describe('mediaItemRepository', () => {
         source: 'user',
         mediaType: 'tv',
         title: 'Item 4',
-        slug: 'item-5',
       },
       {
         id: 77773,
         tmdbId: 9875321,
         source: 'user',
         mediaType: 'tv',
         title: 'Item 2',
-        slug: 'item-2',
       },
     ];
 
@@ -305,14 +302,12 @@ describe('mediaItemRepository', () => {
         source: 'user',
         mediaType: 'tv',
         title: 'Item 1',
-        slug: 'item-1',
       },
       {
         tmdbId: 9875321,
         source: 'user',
         mediaType: 'tv',
         title: 'Item 2',
-        slug: 'item-2',
       },
       {
         imdbId: 'tt1234567',
@@ -321,21 +316,30 @@ describe('mediaItemRepository', () => {
         poster: 'poster',
         backdrop: 'backdrop',
         title: 'Item 3',
-        slug: 'item-3',
       },
       {
         imdbId: 'tt876123',
         tmdbId: 77812332,
         source: 'user',
         mediaType: 'tv',
         title: 'new Title 4',
-        slug: 'new-title-4',
         overview: 'new overview',
       },
+      {
+        tmdbId: 998,
+        source: 'tmdb',
+        mediaType: 'tv',
+        title: 'title123',
+      },
+      {
+        tmdbId: 999,
+        source: 'tmdb',
+        mediaType: 'tv',
+        title: 'title123',
+      },
     ];
 
     await mediaItemRepository.createMany(existingItems);
-
     const res = await mediaItemRepository.mergeSearchResultWithExistingItems(
       searchResult,
       'tv'
@@ -376,7 +380,7 @@ describe('mediaItemRepository', () => {
     expect(insertedPoster).toBeDefined();
     expect(insertedBackdrop).toBeDefined();
 
-    expect(res.mergeWithSearchResult()).toMatchObject([
+    const expected = [
       {
         ...searchResult[0],
         id: 77771,
@@ -394,7 +398,12 @@ describe('mediaItemRepository', () => {
         ...searchResult[3],
         id: 77772,
       },
-    ]);
+      searchResult[4],
+      searchResult[5],
+    ];
+
+    expect(res.mergeWithSearchResult()).toMatchObject(expected);
+    expect(res.mergeWithSearchResult()).toMatchObject(expected);
 
     expect(res.existingItems).toMatchObject([
       {

server/src/repository/mediaItem.ts

@@ -849,29 +849,28 @@ class MediaItemRepository extends repository<MediaItemBase>({
 
       newItems.forEach((item) => (item.lastTimeUpdated = new Date().getTime()));
 
-      const newItemsId = await Database.knex
-        .batchInsert(
-          this.tableName,
-          newItems.map(
-            (item): Record<string, unknown> => ({
-              ...this.serialize(this.stripValue(item)),
-              slug: Database.knex.raw(
-                `(CASE 
-                  WHEN (
-                    ${Database.knex('mediaItem')
-                      .count()
-                      .where('slug', mediaItemSlug(item))
-                      .toQuery()}) = 0 
-                    THEN '${mediaItemSlug(item)}' 
-                  ELSE '${mediaItemSlug(item)}-${randomSlugId()}' 
-                END)`
-              ),
-            })
-          ),
-          30
-        )
-        .transacting(trx)
-        .returning('id');
+      const newItemsId: { id: number }[] = [];
+
+      for (const newItem of newItems) {
+        const [res] = await trx<MediaItemBase>(this.tableName)
+          .insert({
+            ...this.serialize(this.stripValue(newItem)),
+            slug: Database.knex.raw(
+              `(CASE
+              WHEN (
+                ${Database.knex('mediaItem')
+                  .count()
+                  .where('slug', mediaItemSlug(newItem))
+                  .toQuery()}) = 0
+                THEN '${mediaItemSlug(newItem)}'
+              ELSE '${mediaItemSlug(newItem)}-${randomSlugId()}'
+            END)`
+            ),
+          })
+          .returning<{ id: number }[]>('id');
+
+        newItemsId.push(res);
+      }
 
       const newItemsWithId = _.merge(
         newItems,
@@ -931,7 +930,11 @@ class MediaItemRepository extends repository<MediaItemBase>({
             searchResultId: number;
           })[]
         ) =>
-          _(_.concat(newItemsWithId, existingItems || existingSearchResults))
+          _(
+            _.cloneDeep(
+              _.concat(newItemsWithId, existingItems || existingSearchResults)
+            )
+          )
             .sortBy('searchResultId')
             .forEach((item) => delete item.searchResultId)
             .valueOf(),