Remove constant for the fedora version

Initially, we decided to put all the constants in defaults, but the
versioning for the container images is quite complex and scattered
in the code. Let's relay on the default argument on top of the
Containerfile.

Additionally, in this way, renovate can update the automatically
the containerfiles.

Bump also the version from 43 to 44.

Signed-off-by: Alice Frosi <afrosi@redhat.com>

Author: alicefr

Containerfile

@@ -1,5 +1,5 @@
 # Build environment for bink CLI with all C dependencies
-ARG FEDORA_VERSION=43
+ARG FEDORA_VERSION=44
 FROM quay.io/fedora/fedora:${FEDORA_VERSION} AS builder
 
 # Install Go and required C libraries for Podman bindings

Makefile

@@ -7,7 +7,6 @@ extract = $(shell grep '$(1)' $(DEFAULTS_GO) | head -1 | sed 's/.*"\(.*\)"/\1/')
 BINK_IMAGE := $(call extract,binkImageBase ):latest
 CLUSTER_IMAGE := $(call extract,clusterImageBase ):latest
 DNS_IMAGE := $(call extract,dnsImageBase ):latest
-FEDORA_VERSION := $(call extract,FedoraVersion )
 
 # Binary
 BINK_BINARY := bink
@@ -40,13 +39,13 @@ build-bink:
 # Build the bink CLI container image
 build-bink-image:
 	@echo "=== Building bink CLI container image ==="
-	podman build --build-arg FEDORA_VERSION=$(FEDORA_VERSION) --build-arg VERSION=$(VERSION) -t $(BINK_IMAGE) -f Containerfile .
+	podman build --build-arg VERSION=$(VERSION) -t $(BINK_IMAGE) -f Containerfile .
 	@echo "✅ Bink CLI image built: $(BINK_IMAGE)"
 
 # Build the cluster container image
 build-cluster-image:
 	@echo "=== Building cluster container image ==="
-	podman build --build-arg FEDORA_VERSION=$(FEDORA_VERSION) -t $(CLUSTER_IMAGE) -f $(VM_DIR)/Containerfile $(VM_DIR)
+	podman build -t $(CLUSTER_IMAGE) -f $(VM_DIR)/Containerfile $(VM_DIR)
 	@echo "✅ Cluster image built: $(CLUSTER_IMAGE)"
 
 # Build the DNS container image

containerfiles/cluster-image/Containerfile

@@ -1,4 +1,4 @@
-ARG FEDORA_VERSION=43
+ARG FEDORA_VERSION=44
 FROM quay.io/fedora/fedora:${FEDORA_VERSION}
 
 RUN dnf install -y --setopt=install_weak_deps=0 \

internal/config/defaults.go

@@ -13,21 +13,19 @@ const (
 	DefaultNetworkName = "podman"
 	DefaultSubnet      = "10.88.0.0/16"
 
-	FedoraVersion = "43"
-
 	binkImageBase    = "ghcr.io/bootc-dev/bink/bink"
 	clusterImageBase = "ghcr.io/bootc-dev/bink/cluster"
 	dnsImageBase     = "ghcr.io/bootc-dev/bink/dns"
 
 	DefaultNodeImage = "ghcr.io/bootc-dev/bink/node:v1.35-fedora-44-disk"
 
-	DefaultBaseDisk = "/images/disk.qcow2"
+	DefaultBaseDisk              = "/images/disk.qcow2"
 	DefaultControlPlaneMemory    = 1900
 	DefaultControlPlaneMaxMemory = 4096
 	DefaultWorkerMemory          = 768
 	DefaultWorkerMaxMemory       = 2048
 	DefaultVCPUs                 = 2
-	DefaultDiskSize = "10G"
+	DefaultDiskSize              = "10G"
 
 	DefaultSSHPort      = 2222
 	DefaultSSHUser      = "core"