Skip to content

Commit 50ad440

Browse files
authored
Merge pull request #39 from alicefr/sourceable-expose
api expose: print sourceable export line to stdout
2 parents bc7967f + 2395768 commit 50ad440

3 files changed

Lines changed: 9 additions & 7 deletions

File tree

internal/cli/api/expose.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,11 +123,17 @@ func RunExpose(ctx context.Context, logger *logrus.Logger, nodeName, kubeconfigP
123123
return fmt.Errorf("writing kubeconfig: %w", err)
124124
}
125125

126+
absPath, err := filepath.Abs(kubeconfigPath)
127+
if err != nil {
128+
absPath = kubeconfigPath
129+
}
130+
fmt.Printf("export KUBECONFIG=%s\n", absPath)
131+
126132
logger.Infof("Kubeconfig generated at %s", kubeconfigPath)
127133
logger.Infof(" Server URL: https://localhost:%d", hostPort)
128134
logger.Info("")
129135
logger.Info("Usage:")
130-
logger.Infof(" export KUBECONFIG=%s", kubeconfigPath)
136+
logger.Infof(" eval \"$(bink api expose)\"")
131137
logger.Info(" kubectl get nodes")
132138
logger.Info("")
133139

internal/cli/cluster/start.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -202,10 +202,7 @@ func runStart(ctx context.Context, logger *logrus.Logger, nodeName string, nodeI
202202
}
203203
} else {
204204
logger.Info("Next steps:")
205-
logger.Info(" ./bink api expose")
206-
logger.Info("")
207-
logger.Info("Then use:")
208-
logger.Info(" export KUBECONFIG=./kubeconfig")
205+
logger.Infof(" eval \"$(bink api expose)\"")
209206
logger.Info(" kubectl get nodes")
210207
}
211208
logger.Info("")

internal/ssh/ssh.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,7 @@ func (c *Client) ExecWithOutput(ctx context.Context, command string) error {
7979
return fmt.Errorf("ssh exec failed: %w", err)
8080
}
8181

82-
// Write output to stdout (ContainerExec buffers output, so we write it here)
83-
fmt.Fprint(os.Stdout, output)
82+
fmt.Fprint(os.Stderr, output)
8483

8584
return nil
8685
}

0 commit comments

Comments
 (0)