[Bug]: "Add Desktop Entry" option not working

[nanocodex]

Describe the bug

Bottles is unable to add a new desktop entry for any selected program through the listed drop-down option.

I should have seen it appear on my Start Menu under "Applications" with the matching name and icon shown in the "Create Application" menu. Instead, searching for the program name in the Start Menu only returns the .exe file and ~/.local/share/applications does not show any new desktop entries created from Bottles.

To Reproduce

1. Run flatpak override com.usebottles.bottles --user --filesystem=xdg-data/applications in the terminal before launching Bottles.
2. Add ~/.local/share/applications under Filesystem > Other Files in Flatseal, or through flatpak override com.usebottles.bottles --user --filesystem=~/.local/share/applications in the terminal again.
3. Launch Bottles using the terminal with flatpak run com.usebottles.bottles to view its error logs.
4. Go to any bottle.
5. Select any program.
6. Click the three vertical dots beside the program and select "Add Desktop Entry".
7. When the "Create Application" menu pops up, ensure the application name is in lowercase without spaces in between to remove invalid naming as a probable cause. (e.g. "studio")
8. View error log in terminal to verify result.

Package

Flatpak from Flathub

Distribution

Linux Mint 22.3 "Zena"

Debugging Information

Official Package: true
Version: '62.0'
DE/WM: cinnamon
Display:
    X.org: true
    X.org (port): :0
    Wayland: false
Graphics:
    vendors:
        amd:
            vendor: amd
            envs:
                DRI_PRIME: '1'
            icd: /usr/share/vulkan/icd.d/radeon_icd.x86_64.json:/usr/lib/x86_64-linux-gnu/GL/vulkan/icd.d/radeon_icd.x86_64.json:/usr/lib/i386-linux-gnu/GL/vulkan/icd.d/radeon_icd.i686.json
    prime:
        integrated: null
        discrete: null
Kernel:
    Type: Linux
    Version: 6.17.0-14-generic
Disk:
    Total: 14594240512
    Free: 14594076672
RAM:
    MemTotal: 27.2GiB
    MemAvailable: 23.2GiB
Bottles_envs: null

Troubleshooting Logs

austin@YanJun-EQR:~$ flatpak run com.usebottles.bottles
00:17:29 (INFO) Launching with URI: None 
00:17:29 (INFO) [Activate] request received. 
00:17:29 (INFO) Bottles Started! 
00:17:35 (INFO) Performing Bottles checks… 
00:17:35 (INFO) Dxvks found:
	 - dxvk-2.7.1
	 - dxvk-2.7.1-12-9963ecd
 
00:17:35 (INFO) Vkd3ds found:
	 - vkd3d-proton-3.0
 
00:17:35 (INFO) Nvapis found:
	 - dxvk-nvapi-v0.9.1
 
00:17:35 (INFO) Latencyflexs found:
	 - latencyflex-v0.1.1
 
00:17:35 (INFO) Runners found:
	 - soda-9.0-1
	 - sys-wine-11.0
 
00:17:35 (INFO) Bottles found:
	 - Bricklink Studio 2.0
 
00:17:35 (INFO) [Eagle] Reloading YARA rules... 
00:17:35 (INFO) [Eagle] YARA rules loaded 
00:17:36 (INFO) Catalog installers loaded 
00:17:36 (INFO) Catalog dependencies loaded 
00:17:37 (INFO) Catalog components loaded 
00:17:38 (INFO) Setting Key sync=fsync for bottle Bricklink Studio 2.0… 
00:17:39 (INFO) There is no running wineserver. 
00:17:58 (INFO) Using Wine path converter -- --unix 
00:17:58 (INFO) Executing command: /app/bin/wine winepath --unix 'C:\Program Files\Studio 2.0\Studio.exe' 
002c:err:wineboot:process_run_key Error running cmd L"C:\\windows\\system32\\winemenubuilder.exe -a -r" (126).
WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"

Traceback (most recent call last):
  File "/app/share/bottles/bottles/backend/utils/manager.py", line 247, in prepare_install_cb
    portal.dynamic_launcher_install(
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        ret["token"],
        ^^^^^^^^^^^^^
    ...<11 lines>...
        )
        ^
    )
    ^

Additional context

On Linux Mint, ~/.local/share/applications points to /home/<user>/.local/share/applications. Adding either of these to the filesystem section of Bottles in Flatseal has no effect on creating a desktop entry.

I initially ran into this problem when installing Bricklink Studio on my Linux Mint operating system, when I wanted to create a simple desktop entry to quickly access it from the home screen.

Additionally, it would have been helpful if Bottles let me know it needs additional permissions to create a desktop entry and how to grant it in the app itself, without having to search for the documentation.

It would also be nice to know how to manually create a desktop shortcut for Bottles applications as a fallback in the future.

[ignapk]

Hi, thanks for this bug report, it has already been reported in #4402, see my comment explaining your situation in #4402 (comment). Bottles adopted the dynamic launcher xdg-desktop-portal for creating the desktop entries, which means it no longer needs the filesystem permission override (which is why it no longer tells users to add it). There's information on manually creating the desktop entries in the mentioned ticket #4402 (comment)