Skip to content

CONTRIBUTING.md

Latest commit

 

History

History
113 lines (67 loc) · 4.67 KB

CONTRIBUTING.md

File metadata and controls

113 lines (67 loc) · 4.67 KB

CONTRIBUTING

Thank you for considering contributing in the BSV Blockchain ecosystem! This document outlines the processes and practices we expect contributors to adhere to.

Table of Contents

  1. General Guidelines
  2. Code of Conduct
  3. Getting Started
  4. Pull Request Process
  5. Coding Conventions
  6. Documentation and Testing
  7. Contact & Support

General Guidelines

  • Issues First: If you're planning to add a new feature or change existing behavior, please open an issue first. This allows us to avoid multiple people working on similar features and provides a place for discussion.

  • Stay Updated: Always pull the latest changes from the main branch before creating a new branch or starting on new code.

  • Simplicity Over Complexity: Your solution should be as simple as possible, given the requirements.

Code of Conduct

Posting Issues and Comments

  • Be Respectful: Everyone is here to help and grow. Avoid any language that might be considered rude or offensive.

  • Be Clear and Concise: Always be clear about what you're suggesting or reporting. If an issue is related to a particular piece of code or a specific error message, include that in your comment.

  • Stay On Topic: Keep the conversation relevant to the issue at hand. If you have a new idea or unrelated question, please open a new issue.

Coding and PRs

  • Stay Professional: Avoid including "fun" code, comments, or irrelevant file changes in your commits and pull requests.

Getting Started

  1. Fork the Repository: Click on the "Fork" button in the top-right corner of this repository.

  2. Clone the Forked Repository: git clone https://github.com/YOUR_USERNAME/py-sdk.git

  3. Navigate to the Directory: cd py-sdk

  4. Install Dependencies: Always run pip install -e .[test,dev] after pulling to ensure tooling is up-to-date.

Pull Request Process

  1. Create a Branch: For every new feature or bugfix, create a new branch.

  2. Commit Your Changes: Make your changes and commit them. Commit messages should be clear and concise to explain what was done.

  3. Run Linter & Formatter: ruff check --fix . && black . — then verify with ruff check . && black --check ..

  4. Run Tests: Ensure all tests pass and check coverage: pytest --cov=bsv --cov-branch --cov-report=html.

  5. Documentation: All code must be fully annotated with comments.

  6. Push to Your Fork: git push origin your-new-branch.

  7. Open a Pull Request: Go to your fork on GitHub and click "New Pull Request". Fill out the PR template, explaining your changes.

  8. Code Review: At least two maintainers must review and approve the PR before it's merged. Address any feedback or changes requested.

  9. Merge: Once approved, the PR will be merged into the main branch.

Coding Conventions

  • Code Style: We use PEP 8 for our Python coding style, enforced by Ruff (linter) and Black (formatter).

  • Linting & Formatting: All code must pass Ruff and Black before submitting a PR. Run the following commands from the project root:

    # Fix auto-fixable lint issues
ruff check --fix .

# Format code
black .

# Verify no remaining lint errors
ruff check .

# Verify formatting is correct
black --check .

    Configuration for both tools is in pyproject.toml ([tool.ruff] and [tool.black]). Line length is 120 characters.

  • Testing: Always include tests for new code or changes. We aim for industry-standard levels of test coverage.

  • Documentation: All functions, classes, and modules should be documented. Use annotation comments to describe the purpose, parameters, and return values.

Documentation and Testing

  • Documentation: Update the documentation whenever you add or modify the code.

  • Testing: We use pytest for all tests. Write comprehensive tests, ensuring edge cases are covered. All PRs should maintain or improve the current test coverage.

  • Branch Coverage: We measure both line and branch coverage. For critical modules (wallet, auth, crypto), aim for 70%+ branch coverage. Include tests for both branches of conditional statements. Run pytest --cov=bsv --cov-branch --cov-report=html to check branch coverage.

Contact & Support

If you have any questions or need assistance with your contributions, feel free to reach out. Remember, we're here to help each other grow and improve the ecosystem.

Thank you for being a part of this journey. Your contributions help shape the future of the BSV Blockchain!