fix: rebroadcast tx on proof timeout instead of marking invalid (#8)

* fix: rebroadcast transactions instead of marking invalid on proof timeout

When a transaction was successfully broadcast but not yet mined, the
system previously marked it 'invalid' after max failed proof checks.
This caused a double-spend: reviewStatus restored the inputs to
spendable, they were spent again, and when the original tx was mined
the wallet had two conflicting transactions.

Fix 1 (TaskCheckForProofs): reset to 'unsent' + attempts=0 instead of
'invalid' when the proof-attempt limit is exceeded. TaskSendWaiting
picks up 'unsent' reqs and rebroadcasts them automatically.

Fix 2 (EntityProvenTx.fromReq): same rebroadcast logic for the
secondary threshold (attempts > 8, age > 60 min) to prevent an earlier
bypass of the main limit.

Fix 3 (reviewStatus): add a guard to Step 2 so inputs are only
restored to spendable when there is no live ProvenTxReq (in
unmined/callback/unconfirmed/sending/unsent status) for the same txid.
Defense-in-depth to prevent double-spend even if a req reaches 'failed'.

Fix 4 (Monitor): increase unprovenAttemptsLimitTest from 10 to 100,
giving ~24h of testnet blocks before a rebroadcast cycle.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: add wasBroadcast flag and maxRebroadcastAttempts circuit breaker (Phases 2 & 4)

Phase 2: Add `wasBroadcast` and `rebroadcastAttempts` schema columns to
`proven_tx_reqs` (migration 2026-04-30-001). Set `wasBroadcast = true`
when a req transitions to 'unmined' via broadcast success
(attemptToPostReqsToNetwork) or ARC SSE event. Use the flag in
TaskCheckForProofs and EntityProvenTx.fromReq so that proof-timeout
resets only happen for genuinely broadcast transactions; unbroadcast reqs
are still marked invalid.

Phase 4: Add `maxRebroadcastAttempts: number` (default 0 = unlimited) to
MonitorOptions. The proof-timeout path in TaskCheckForProofs increments
`rebroadcastAttempts` each cycle; once the circuit-breaker limit is
reached the req is marked invalid even for a broadcast tx.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* testing plan

Signed-off-by: Deggen <d.kellenschwiler@bsvassociation.org>

* exclude dist

Signed-off-by: Deggen <d.kellenschwiler@bsvassociation.org>

* update pnpm

Signed-off-by: Deggen <d.kellenschwiler@bsvassociation.org>

* make sure they all pass

Signed-off-by: Deggen <d.kellenschwiler@bsvassociation.org>

* fix wallet proof timeout rebroadcast recovery

* fix(docs-site): add path '/' to layout route so vite-react-ssg emits dist/index.html

Without an explicit `path: '/'` on the root layout route, vite-react-ssg cannot
discover the root pre-render target and never writes dist/index.html, causing
pagefind and check-built-links to fail. Child paths converted to relative (no
leading slash) and root index.md mapped to an index route per React Router v6
convention. Also adds `test -f dist/index.html` guard before pagefind to produce
a clear error instead of a cryptic SSG crash.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix ci recursive workspace builds

* chore: ignore .worktrees/ directory

* test: allow slower mongo memory startup

* ci: allow required native dependency builds

* Update .github/workflows/conformance.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix(wallet): harden input restoration guard

* fix(ci): repair version and conformance checks

* fix(wallet): rethrow unexpected purge beef errors

* docs(wallet): summarize rebroadcast recovery PR

---------

Signed-off-by: Deggen <d.kellenschwiler@bsvassociation.org>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: 3 people

.github/workflows/ci.yml

@@ -32,16 +32,16 @@ jobs:
         run: node scripts/check-versions.mjs
 
       - name: Build all packages
-        # Exclude: example-paymail (example package, not production)
-        run: pnpm -r --filter '!example-paymail' run build
+        # Exclude: workspace root (delegating script) and example-paymail (example package, not production)
+        run: pnpm -r --filter '!@bsv/ts-stack' --filter '!example-paymail' run build
 
       - name: Lint all packages
         continue-on-error: true
-        run: pnpm -r run lint --if-present
+        run: pnpm -r --filter '!@bsv/ts-stack' run lint --if-present
 
       - name: Test all packages
-        # Exclude: example-paymail (example package, not production)
-        run: pnpm -r --filter '!example-paymail' run test
+        # Exclude: workspace root (delegating script) and example-paymail (example package, not production)
+        run: pnpm -r --filter '!@bsv/ts-stack' --filter '!example-paymail' run test
 
   conformance:
     name: Conformance Vectors

.github/workflows/conformance.yml

@@ -23,7 +23,7 @@ jobs:
         run: mkdir -p conformance/reports
       - name: Run TS conformance runner
         run: |
-          pnpm --filter @bsv/conformance-runner-ts test -- \
+          pnpm --filter @bsv/conformance-runner-ts test \
             --json --outputFile=../../reports/ts-results.json
         working-directory: ${{ github.workspace }}/conformance/runner/ts
       - name: Upload TS conformance reports

.github/workflows/release.yml

@@ -28,7 +28,7 @@ jobs:
         run: pnpm install --frozen-lockfile
 
       - name: Build all packages
-        run: pnpm -r run build
+        run: pnpm -r --filter '!@bsv/ts-stack' run build
 
       - name: Publish changed packages
         # No token needed — npm authenticates via GitHub OIDC.

docs-site/package.json

@@ -5,7 +5,7 @@
   "type": "module",
   "scripts": {
     "dev": "vite",
-    "build": "node scripts/build-manifest.mjs && vite-react-ssg build && pagefind --site dist --output-path dist/_pagefind && node scripts/check-built-links.mjs",
+    "build": "node scripts/build-manifest.mjs && vite-react-ssg build && test -f dist/index.html && pagefind --site dist --output-path dist/_pagefind && node scripts/check-built-links.mjs",
     "preview": "vite preview",
     "validate": "node scripts/validate-frontmatter.mjs && node scripts/check-links.mjs"
   },

docs-site/src/routes.tsx

@@ -24,13 +24,21 @@ function mdRoute(docPath: string): string {
     .replace(/\.md$/, '/')
 }
 
-const docRoutes: RouteObject[] = Object.keys(pages).map(key => ({
-  path: mdRoute(key),
-  element: page(pages[key]),
-}))
+// vite-react-ssg requires parent route to have path '/' so it can discover
+// the root route for pre-rendering. Child paths must be relative (no leading /).
+const docRoutes: RouteObject[] = Object.keys(pages).map(key => {
+  const absPath = mdRoute(key)
+  if (absPath === '/') {
+    // Root index.md → React Router index route so RootLayout renders at /
+    return { index: true, element: page(pages[key]) } as RouteObject
+  }
+  // Strip leading / to make path relative to the '/' parent
+  return { path: absPath.slice(1), element: page(pages[key]) }
+})
 
 export const routes: RouteObject[] = [
   {
+    path: '/',
     element: <RootLayout />,
     children: [
       ...docRoutes,

package.json

@@ -3,10 +3,10 @@
   "private": true,
   "description": "BSV TypeScript monorepo — SDK, Wallet, Network, Overlay, Messaging, Middleware, Helpers",
   "scripts": {
-    "build": "pnpm -r run build",
-    "test": "pnpm -r run test",
-    "lint": "pnpm -r run lint",
-    "clean": "pnpm -r run clean",
+    "build": "pnpm -r --filter '!@bsv/ts-stack' run build",
+    "test": "pnpm -r --filter '!@bsv/ts-stack' run test",
+    "lint": "pnpm -r --filter '!@bsv/ts-stack' run lint",
+    "clean": "pnpm -r --filter '!@bsv/ts-stack' run clean",
     "sync-versions": "node scripts/sync-versions.mjs",
     "check-versions": "node scripts/check-versions.mjs",
     "conformance": "node conformance/runner/src/runner.js",
@@ -23,8 +23,13 @@
     "node": ">=22",
     "pnpm": ">=9"
   },
-  "packageManager": "pnpm@9.0.0",
+  "packageManager": "pnpm@10.33.2",
   "pnpm": {
+    "onlyBuiltDependencies": [
+      "better-sqlite3",
+      "mongodb-memory-server",
+      "sqlite3"
+    ],
     "overrides": {
       "jest-environment-node": "^30.3.0",
       "jest-mock": "^30.3.0",

packages/overlays/topics/src/__tests__/any.test.ts

@@ -14,6 +14,8 @@ import { AnyLookupService } from '../any/AnyLookupService.js'
 import { AnyStorage } from '../any/AnyStorage.js'
 import { OutputAdmittedByTopic, LookupQuestion } from '@bsv/overlay'
 
+const mongoMemoryServerOptions = { instance: { launchTimeout: 60000 } }
+
 // ---------------------------------------------------------------------------
 // Helpers
 // ---------------------------------------------------------------------------
@@ -86,8 +88,8 @@ describe('AnyLookupService (MongoDB)', () => {
   let service: AnyLookupService
 
   beforeAll(async () => {
-    jest.setTimeout(30000)
-    mongod = await MongoMemoryServer.create()
+    jest.setTimeout(60000)
+    mongod = await MongoMemoryServer.create(mongoMemoryServerOptions)
     client = new MongoClient(mongod.getUri())
     await client.connect()
     db = client.db('test_any')

packages/overlays/topics/src/__tests__/hello.test.ts

@@ -31,6 +31,8 @@ import { HelloWorldLookupService } from '../hello/HelloWorldLookupService.js'
 import { HelloWorldStorage } from '../hello/HelloWorldStorage.js'
 import { OutputAdmittedByTopic, LookupQuestion } from '@bsv/overlay'
 
+const mongoMemoryServerOptions = { instance: { launchTimeout: 60000 } }
+
 // ---------------------------------------------------------------------------
 // Helpers
 // ---------------------------------------------------------------------------
@@ -185,8 +187,8 @@ describe('HelloWorldLookupService (MongoDB)', () => {
   let service: HelloWorldLookupService
 
   beforeAll(async () => {
-    jest.setTimeout(30000)
-    mongod = await MongoMemoryServer.create()
+    jest.setTimeout(60000)
+    mongod = await MongoMemoryServer.create(mongoMemoryServerOptions)
     client = new MongoClient(mongod.getUri())
     await client.connect()
     db = client.db('test_hello')

packages/overlays/topics/src/__tests__/kvstore.test.ts

@@ -30,6 +30,8 @@ import KVStoreLookupServiceFactory from '../kvstore/KVStoreLookupService.js'
 import { KVStoreStorageManager } from '../kvstore/KVStoreStorageManager.js'
 import { OutputAdmittedByTopic, LookupQuestion } from '@bsv/overlay'
 
+const mongoMemoryServerOptions = { instance: { launchTimeout: 60000 } }
+
 // ---------------------------------------------------------------------------
 // Helpers
 // ---------------------------------------------------------------------------
@@ -263,8 +265,8 @@ describe('KVStoreLookupService (MongoDB)', () => {
   let service: ReturnType<typeof KVStoreLookupServiceFactory>
 
   beforeAll(async () => {
-    jest.setTimeout(30000)
-    mongod = await MongoMemoryServer.create()
+    jest.setTimeout(60000)
+    mongod = await MongoMemoryServer.create(mongoMemoryServerOptions)
     client = new MongoClient(mongod.getUri())
     await client.connect()
     db = client.db('test_kvstore')