Do not crash the whole invoice creation if monero isn't available

Author: NicolasDorier

Plugins/Monero/Payments/MoneroLikePaymentMethodHandler.cs

@@ -40,32 +40,41 @@ public MoneroLikePaymentMethodHandler(MoneroLikeSpecificBtcPayNetwork network, M
             Serializer = BlobSerializer.CreateSerializer().Serializer;
             _moneroRpcProvider = moneroRpcProvider;
         }
+        bool IsReady() => _moneroRpcProvider.IsConfigured(_network.CryptoCode) && _moneroRpcProvider.IsAvailable(_network.CryptoCode);
 
-        public Task BeforeFetchingRates(PaymentMethodContext context)
+		public Task BeforeFetchingRates(PaymentMethodContext context)
         {
             context.Prompt.Currency = _network.CryptoCode;
             context.Prompt.Divisibility = _network.Divisibility;
-            if (context.Prompt.Activated)
+            if (context.Prompt.Activated && IsReady())
             {
                 var supportedPaymentMethod = ParsePaymentMethodConfig(context.PaymentMethodConfig);
                 var walletClient = _moneroRpcProvider.WalletRpcClients[_network.CryptoCode];
                 var daemonClient = _moneroRpcProvider.DaemonRpcClients[_network.CryptoCode];
-                context.State = new Prepare()
+                try
                 {
-                    GetFeeRate = daemonClient.SendCommandAsync<GetFeeEstimateRequest, GetFeeEstimateResponse>("get_fee_estimate", new GetFeeEstimateRequest()),
-                    ReserveAddress = s => walletClient.SendCommandAsync<CreateAddressRequest, CreateAddressResponse>("create_address", new CreateAddressRequest() { Label = $"btcpay invoice #{s}", AccountIndex = supportedPaymentMethod.AccountIndex }),
-                    AccountIndex = supportedPaymentMethod.AccountIndex
-                };
-            }
+                    context.State = new Prepare()
+                    {
+                        GetFeeRate = daemonClient.SendCommandAsync<GetFeeEstimateRequest, GetFeeEstimateResponse>("get_fee_estimate", new GetFeeEstimateRequest()),
+                        ReserveAddress = s => walletClient.SendCommandAsync<CreateAddressRequest, CreateAddressResponse>("create_address", new CreateAddressRequest() { Label = $"btcpay invoice #{s}", AccountIndex = supportedPaymentMethod.AccountIndex }),
+                        AccountIndex = supportedPaymentMethod.AccountIndex
+                    };
+                }
+                catch (Exception ex)
+				{
+                    context.Logs.Write($"Error in BeforeFetchingRates: {ex.Message}", InvoiceEventData.EventSeverity.Error);
+				}
+			}
             return Task.CompletedTask;
         }
 
-        public async Task ConfigurePrompt(PaymentMethodContext context)
+		public async Task ConfigurePrompt(PaymentMethodContext context)
         {
-            if (!_moneroRpcProvider.IsAvailable(_network.CryptoCode))
+            if (!_moneroRpcProvider.IsConfigured(_network.CryptoCode))
+				throw new PaymentMethodUnavailableException($"BTCPAY_XMR_WALLET_DAEMON_URI or BTCPAY_XMR_DAEMON_URI isn't configured");
+            if (!_moneroRpcProvider.IsAvailable(_network.CryptoCode) || context.State is not Prepare moneroPrepare)
                 throw new PaymentMethodUnavailableException($"Node or wallet not available");
             var invoice = context.InvoiceEntity;
-            Prepare moneroPrepare = (Prepare)context.State;
             var feeRatePerKb = await moneroPrepare.GetFeeRate;
             var address = await moneroPrepare.ReserveAddress(invoice.Id);
 

Plugins/Monero/Services/MoneroRPCProvider.cs

@@ -57,7 +57,8 @@ public MoneroRPCProvider(MoneroLikeConfiguration moneroLikeConfiguration,
 
         public ImmutableDictionary<string, JsonRpcClient> CashCowWalletRpcClients { get; set; }
 
-        public bool IsAvailable(string cryptoCode)
+		public bool IsConfigured(string cryptoCode) => WalletRpcClients.ContainsKey(cryptoCode) && DaemonRpcClients.ContainsKey(cryptoCode);
+		public bool IsAvailable(string cryptoCode)
         {
             cryptoCode = cryptoCode.ToUpperInvariant();
             return _summaries.ContainsKey(cryptoCode) && IsAvailable(_summaries[cryptoCode]);