Merge pull request #88 from btcpay-monero/change-password

Add ChangePasswordRequest class and update ChangePassword

Author: deverickapollo

Monero.IntegrationTests/MoneroWalletRpcIntegrationTest.cs

@@ -786,6 +786,24 @@ public async Task TestSaveAndClose()
         await CloseWallet(moneroWallet);
     }
 
+    //Can change password
+    [Test]
+    public async Task TestChangePassword()
+    {
+        const string oldPassword = "oldPassword";
+        const string newPassword = "newPassword";
+
+        IMoneroWallet moneroWallet = await CreateWallet(new MoneroWalletConfig().SetPassword(oldPassword));
+        string path = await moneroWallet.GetPath();
+
+        await moneroWallet.ChangePassword(oldPassword, newPassword);
+        await CloseWallet(moneroWallet, true);
+
+        moneroWallet = await OpenWallet(new MoneroWalletConfig().SetPath(path).SetPassword(newPassword));
+        Assert.That(await moneroWallet.GetPath(), Is.EqualTo(path));
+        await CloseWallet(moneroWallet);
+    }
+
     // Can validate address
     [Test]
     public async Task TestValidateAddress()

Monero/Wallet/MoneroWalletRpc.cs

@@ -1378,10 +1378,12 @@ public async Task<List<string>> SubmitMultisigTxHex(string signedMultisigTxHex)
 
     public async Task ChangePassword(string oldPassword, string newPassword)
     {
-        MoneroJsonRpcParams parameters = [];
-        parameters.Add("old_password", oldPassword);
-        parameters.Add("new_password", newPassword);
-        await _rpc.SendCommandAsync<MoneroJsonRpcParams, MoneroRpcResponse>("change_wallet_password", parameters);
+        ChangePasswordRequest parameters = new()
+        {
+            OldPassword = oldPassword,
+            NewPassword = newPassword
+        };
+        await _rpc.SendCommandAsync<ChangePasswordRequest, MoneroRpcResponse>("change_wallet_password", parameters);
     }
 
     public async Task Save()

Monero/Wallet/Rpc/ChangePasswordRequest.cs

@@ -0,0 +1,9 @@
+using System.Text.Json.Serialization;
+
+namespace Monero.Wallet.Rpc;
+
+public class ChangePasswordRequest
+{
+    [JsonPropertyName("old_password")] public required string OldPassword { get; set; }
+    [JsonPropertyName("new_password")] public required string NewPassword { get; set; }
+}