Skip to content

Fix : manifest generation - #56

Merged
r1ckstardev merged 6 commits into
btcpayserver:mainfrom
teamssUTXO:main
May 7, 2026
Merged

Fix : manifest generation#56
r1ckstardev merged 6 commits into
btcpayserver:mainfrom
teamssUTXO:main

Conversation

@teamssUTXO

@teamssUTXO teamssUTXO commented May 5, 2026

Copy link
Copy Markdown
Collaborator

Related to the previous fix of translations directory : 2522bc9, this fix the manifest generation CI workflow by change the translations directory path.

@coderabbitai

coderabbitai Bot commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Rate limit exceeded

@teamssUTXO has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 57 minutes and 32 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 82fdbdde-222d-49c4-91af-3df11c9205fb

📥 Commits

Reviewing files that changed from the base of the PR and between 240f6ef and e8db389.

📒 Files selected for processing (1)
  • BTCPayTranslator.slnx
📝 Walkthrough

Walkthrough

The PR moves translations from Translator/translations to a repository-root translations folder, updates the CLI default translation path and help text, adjusts the GitHub workflow trigger to the new path, updates manifest.json (French metadata and adds Romanian), and edits a French translation string.

Changes

Translation Directory Relocation

Layer / File(s) Summary
Manifest language entries
manifest.json		 Updated French (fr) Sha, set Maintainer to `teamssUTXO
Translation string
translations/french.json		 Updated French message for "Constraints do not match any installed camera." to "Aucune caméra ne satisfait les contraintes spécifiées."
Remove nested reference
Translator/translations		 Removed the ../translations reference from Translator/translations.
CLI Configuration
Translator/Program.cs		 Changed generate-manifest defaultTranslationPath to Path.Combine(projectDirectory, "..", "translations") and updated --translation-path help text to indicate <repo-root>/translations.
Workflow & Solution wiring
.github/workflows/manifest.yml, BTCPayTranslator.slnx		 Changed workflow on.push.paths from Translator/translations/**/*.json to translations/**/*.json; added .github/workflows/manifest.yml to the solution /Misc/ folder.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • btcpayserver/btcpayserver-translator#54: Directly related—updates the generate-manifest workflow trigger path and CLI default translation directory to point to the repository-root translations folder.

Poem

🐰 I hopped through folders, found files unbound,

Moved translations home to common ground.
French now polished, Romanian arrives,
CI listens where the repo thrives.
A joyful hop — manifests aligned!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix : manifest generation' directly addresses the PR objective of fixing the manifest generation CI workflow.
Description check ✅ Passed The description relates to the changeset by explaining the fix for manifest generation CI workflow and references a prior translation directory change.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@r1ckstardev
r1ckstardev merged commit 3fdd343 into btcpayserver:main May 7, 2026
2 checks passed
This was referenced Jun 9, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@teamssUTXO @r1ckstardev