integration,rpctest: remove unused create test chain option

The previous commit made CreateTestChain option useless, so this commit
cleans up the codebase by effectively removing the option and all the
references to it.

Author: allocz

integration/chain_test.go

@@ -32,10 +32,7 @@ func TestGetTxSpendingPrevOut(t *testing.T) {
 	require.NoError(t, err)
 
 	// Setup the node.
-	sOpts := &rpctest.SetUpOpts{
-		CreateTestChain:  true,
-		NumMatureOutputs: 100,
-	}
+	sOpts := &rpctest.SetUpOpts{NumMatureOutputs: 100}
 	require.NoError(t, r.SetUp(sOpts))
 	t.Cleanup(func() {
 		require.NoError(t, r.TearDown(nil))

integration/csv_fork_test.go

@@ -115,10 +115,7 @@ func TestBIP0113Activation(t *testing.T) {
 	if err != nil {
 		t.Fatal("unable to create primary harness: ", err)
 	}
-	sOpts := &rpctest.SetUpOpts{
-		CreateTestChain:  true,
-		NumMatureOutputs: 1,
-	}
+	sOpts := &rpctest.SetUpOpts{NumMatureOutputs: 1}
 	if err := r.SetUp(sOpts); err != nil {
 		t.Fatalf("unable to setup test chain: %v", err)
 	}
@@ -416,10 +413,7 @@ func TestBIP0068AndBIP0112Activation(t *testing.T) {
 	if err != nil {
 		t.Fatal("unable to create primary harness: ", err)
 	}
-	sOpts := &rpctest.SetUpOpts{
-		CreateTestChain:  true,
-		NumMatureOutputs: 1,
-	}
+	sOpts := &rpctest.SetUpOpts{NumMatureOutputs: 1}
 	if err := r.SetUp(sOpts); err != nil {
 		t.Fatalf("unable to setup test chain: %v", err)
 	}

integration/p2a_test.go

@@ -38,10 +38,7 @@ func TestPayToAnchorSimple(t *testing.T) {
 
 	// Initialize the test harness with mining enabled to confirm
 	// transactions.
-	sOpts := &rpctest.SetUpOpts{
-		CreateTestChain:  true,
-		NumMatureOutputs: 25,
-	}
+	sOpts := &rpctest.SetUpOpts{NumMatureOutputs: 25}
 	err = harness.SetUp(sOpts)
 	if err != nil {
 		t.Fatalf("unable to setup test harness: %v", err)

integration/rawtx_test.go

@@ -33,10 +33,7 @@ func TestTestMempoolAccept(t *testing.T) {
 	require.NoError(t, err)
 
 	// Setup the node.
-	sOpts := &rpctest.SetUpOpts{
-		CreateTestChain:  true,
-		NumMatureOutputs: 100,
-	}
+	sOpts := &rpctest.SetUpOpts{NumMatureOutputs: 100}
 	require.NoError(t, r.SetUp(sOpts))
 	t.Cleanup(func() {
 		require.NoError(t, r.TearDown(nil))

integration/rpcserver_test.go

@@ -316,10 +316,7 @@ func TestMain(m *testing.M) {
 	// Initialize the primary mining node with a chain of length 125,
 	// providing 25 mature coinbases to allow spending from for testing
 	// purposes.
-	sOpts := &rpctest.SetUpOpts{
-		CreateTestChain:  true,
-		NumMatureOutputs: 25,
-	}
+	sOpts := &rpctest.SetUpOpts{NumMatureOutputs: 25}
 	if err := primaryHarness.SetUp(sOpts); err != nil {
 		fmt.Println("unable to setup test chain: ", err)
 

integration/rpctest/rpc_harness.go

@@ -285,9 +285,6 @@ func New(opts *HarnessOpts) (*Harness, error) {
 // SetUpOpts are options that can be passed to SetUp when starting the harness
 // instance.
 type SetUpOpts struct {
-	// CreateTestChain tells the harness to generate blocks.
-	CreateTestChain bool
-
 	// NumMatureOutputs is the count of mature outputs to be generated.
 	NumMatureOutputs uint32
 

integration/rpctest/rpc_harness_test.go

@@ -478,10 +478,7 @@ func testMemWalletReorg(r *Harness, t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	sOpts := &SetUpOpts{
-		CreateTestChain:  true,
-		NumMatureOutputs: 5,
-	}
+	sOpts := &SetUpOpts{NumMatureOutputs: 5}
 	if err := harness.SetUp(sOpts); err != nil {
 		t.Fatalf("unable to complete rpctest setup: %v", err)
 	}
@@ -559,7 +556,7 @@ func testNodeRestart(_ *Harness, t *testing.T) {
 	// Start the node and mine some blocks.
 	h, err := New(nil)
 	require.NoError(t, err)
-	err = h.SetUp(&SetUpOpts{CreateTestChain: true, NumMatureOutputs: 1})
+	err = h.SetUp(&SetUpOpts{NumMatureOutputs: 1})
 	require.NoError(t, err)
 	count, err := h.Client.GetBlockCount()
 	require.NoError(t, err)
@@ -714,10 +711,7 @@ func TestMain(m *testing.M) {
 	// Initialize the main mining node with a chain of length 125,
 	// providing 25 mature coinbases to allow spending from for testing
 	// purposes.
-	sOpts := &SetUpOpts{
-		CreateTestChain:  true,
-		NumMatureOutputs: numMatureOutputs,
-	}
+	sOpts := &SetUpOpts{NumMatureOutputs: numMatureOutputs}
 	if err = mainHarness.SetUp(sOpts); err != nil {
 		fmt.Println("unable to setup test chain: ", err)