Skip to content

Commit 2d75da3

Browse files
committed
Improve the titles of object pages slightly
1 parent 738b05b commit 2d75da3

1 file changed

Lines changed: 17 additions & 1 deletion

File tree

cmd/bonanza_browser/browser_service.go

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -946,6 +946,7 @@ func renderObjectPage(
946946
currentPayloadRendererIndex int,
947947
currentEncoderConfiguration string,
948948
cookie *browser_pb.Cookie,
949+
titlePrefix string,
949950
payload []g.Node,
950951
) g.Node {
951952
setCookie(w, cookie)
@@ -959,7 +960,7 @@ func renderObjectPage(
959960
}
960961

961962
rawReference := base64.RawURLEncoding.EncodeToString(decodableReference.Value.GetRawReference())
962-
return renderPage(rawReference, []g.Node{
963+
return renderPage(titlePrefix+rawReference, []g.Node{
963964
h.Div(
964965
h.Class("flex w-full space-x-4 p-4"),
965966

@@ -1013,6 +1014,7 @@ func (s *BrowserService) doObject(
10131014
r *http.Request,
10141015
payloadRenderers []payloadRenderer,
10151016
defaultPayloadRendererIndex int,
1017+
titlePrefix string,
10161018
) (g.Node, error) {
10171019
objectReference, err := getReferenceFromRequest(r)
10181020
if err != nil {
@@ -1037,6 +1039,7 @@ func (s *BrowserService) doObject(
10371039
currentPayloadRendererIndex,
10381040
currentEncoderConfigurationStr,
10391041
cookie,
1042+
titlePrefix,
10401043
renderErrorAlert(fmt.Errorf("failed to obtain encoder configuration: %w", err)),
10411044
), nil
10421045
}
@@ -1051,6 +1054,7 @@ func (s *BrowserService) doObject(
10511054
currentPayloadRendererIndex,
10521055
currentEncoderConfigurationStr,
10531056
cookie,
1057+
titlePrefix,
10541058
renderErrorAlert(fmt.Errorf("failed to download object: %w", err)),
10551059
), nil
10561060
}
@@ -1085,10 +1089,19 @@ func (s *BrowserService) doObject(
10851089
currentPayloadRendererIndex,
10861090
currentEncoderConfigurationStr,
10871091
cookie,
1092+
titlePrefix,
10881093
rendered,
10891094
), nil
10901095
}
10911096

1097+
func getAbbreviatedMessageType(r *http.Request) string {
1098+
messageType := r.PathValue("message_type")
1099+
if i := strings.LastIndexByte(messageType, '.'); i >= 0 {
1100+
messageType = messageType[i+1:]
1101+
}
1102+
return messageType
1103+
}
1104+
10921105
func (s *BrowserService) doProtoObject(w http.ResponseWriter, r *http.Request) (g.Node, error) {
10931106
payloadRenderers := []payloadRenderer{
10941107
rawPayloadRenderer{},
@@ -1107,6 +1120,7 @@ func (s *BrowserService) doProtoObject(w http.ResponseWriter, r *http.Request) (
11071120
r,
11081121
payloadRenderers,
11091122
/* defaultPayloadRendererIndex = */ len(payloadRenderers)-1,
1123+
getAbbreviatedMessageType(r)+" ",
11101124
)
11111125
}
11121126

@@ -1128,6 +1142,7 @@ func (s *BrowserService) doProtoListObject(w http.ResponseWriter, r *http.Reques
11281142
r,
11291143
payloadRenderers,
11301144
/* defaultPayloadRendererIndex = */ len(payloadRenderers)-1,
1145+
getAbbreviatedMessageType(r)+" list ",
11311146
)
11321147
}
11331148

@@ -1142,6 +1157,7 @@ func (s *BrowserService) doRawObject(w http.ResponseWriter, r *http.Request) (g.
11421157
r,
11431158
payloadRenderers,
11441159
/* defaultPayloadRendererIndex = */ len(payloadRenderers)-1,
1160+
"",
11451161
)
11461162
}
11471163

0 commit comments

Comments
 (0)