Skip to content

Commit c5cb7c4

Browse files
committed
Implement ctx.runfiles() entirely in Starlark
Right now this function calls into a native implementation that lives in ConfiguredTarget. This one returns runfiles objects that are implemented in Go. This change gets rid of that, replacing runfiles objects with a simple struct. The merge() and merge_all() methods are provided in the form of computed fields.
1 parent 85a9fab commit c5cb7c4

16 files changed

Lines changed: 2806 additions & 2989 deletions

File tree

pkg/model/analysis/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ go_library(
2323
"configured_target.go",
2424
"directory_creation_parameters.go",
2525
"directory_readers.go",
26+
"empty_default_info.go",
2627
"exec_transition.go",
2728
"file_access_parameters.go",
2829
"file_creation_parameters.go",

pkg/model/analysis/computer.json

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@
127127
"ConfiguredTarget",
128128
"DirectoryCreationParametersObject",
129129
"FileCreationParametersObject",
130+
"EmptyDefaultInfo",
130131
"ExecTransition",
131132
"ResolvedToolchains",
132133
"RootModule",
@@ -167,6 +168,16 @@
167168
"type": "*DirectoryReaders[TReference]"
168169
}
169170
},
171+
"EmptyDefaultInfo": {
172+
"dependsOn": [
173+
"BuiltinsModuleNames",
174+
"CanonicalRepoName",
175+
"CompiledBzlFileDecodedGlobals",
176+
"CompiledBzlFileFunctionFactory",
177+
"CompiledBzlFileGlobal",
178+
"RootModule"
179+
]
180+
},
170181
"ExecTransition": {
171182
"dependsOn": [
172183
"BuiltinsModuleNames",

0 commit comments

Comments
 (0)