chore(tests): trim low-value tests (batch 2) (#608)

- Drop redundant error-branch tests in embed-releases / embed-entities
  (same contract is covered in embed-changelog-pipeline)
- Replace local selectChangelog helper with canonical
  selectChangelogFile from @buildinternet/releases-core
- Drop redundant cacheControl, log-search MCP, workflows-ai model-pin,
  and workflows-embed unobservable-clamp tests
- Drop CATEGORIES dup in managed-discovery (covered in categories.test)
- Drop tautological hash determinism test and a redundant isSeedRun case

~241 LOC removed across 10 files. Closes #606.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: zachdunn

packages/search/src/embed-entities.test.ts

@@ -19,11 +19,10 @@ function fakeVoyageFetch() {
   return { fetchImpl, calls };
 }
 
-function fakeVectorize(opts: { upsertThrows?: boolean } = {}) {
+function fakeVectorize() {
   const upserted: any[] = [];
   const index: VectorizeIndex = {
     async upsert(v: any[]) {
-      if (opts.upsertThrows) throw new Error("vec down");
       upserted.push(...v);
       return { mutationId: "m1" };
     },
@@ -37,15 +36,6 @@ function fakeVectorize(opts: { upsertThrows?: boolean } = {}) {
   return { index, upserted };
 }
 
-function captureLogger() {
-  const warns: string[] = [];
-  return {
-    warn: (...args: unknown[]) => warns.push(args.map(String).join(" ")),
-    error: (..._args: unknown[]) => {},
-    warns,
-  };
-}
-
 describe("embedAndUpsertEntities", () => {
   test("empty input short-circuits", async () => {
     const { fetchImpl, calls } = fakeVoyageFetch();
@@ -151,56 +141,7 @@ describe("embedAndUpsertEntities", () => {
     expect(persisted).toEqual([["org_1", "org_2"]]);
   });
 
-  test("embed failure → logs, no upsert, no onPersisted", async () => {
-    const fetchImpl = (async () => new Response("err", { status: 400 })) as unknown as typeof fetch;
-    const vec = fakeVectorize();
-    const logger = captureLogger();
-    let persistedCalled = false;
-    await embedAndUpsertEntities({
-      entities: [{ id: "org_1", kind: "org", name: "x" }],
-      vectorIndex: vec.index,
-      embedConfig: { provider: "voyage", apiKey: "k", fetchImpl, maxRetries: 0 },
-      onPersisted: async () => {
-        persistedCalled = true;
-      },
-      logger,
-    });
-    expect(vec.upserted.length).toBe(0);
-    expect(persistedCalled).toBe(false);
-    expect(logger.warns.some((w) => w.includes("embed pipeline failed"))).toBe(true);
-  });
-
-  test("upsert failure → logs, no onPersisted", async () => {
-    const { fetchImpl } = fakeVoyageFetch();
-    const vec = fakeVectorize({ upsertThrows: true });
-    const logger = captureLogger();
-    let persistedCalled = false;
-    await embedAndUpsertEntities({
-      entities: [{ id: "org_1", kind: "org", name: "x" }],
-      vectorIndex: vec.index,
-      embedConfig: { provider: "voyage", apiKey: "k", fetchImpl },
-      onPersisted: async () => {
-        persistedCalled = true;
-      },
-      logger,
-    });
-    expect(persistedCalled).toBe(false);
-    expect(logger.warns.some((w) => w.includes("Vectorize upsert failed"))).toBe(true);
-  });
-
-  test("onPersisted failure is caught and logged", async () => {
-    const { fetchImpl } = fakeVoyageFetch();
-    const vec = fakeVectorize();
-    const logger = captureLogger();
-    await embedAndUpsertEntities({
-      entities: [{ id: "org_1", kind: "org", name: "x" }],
-      vectorIndex: vec.index,
-      embedConfig: { provider: "voyage", apiKey: "k", fetchImpl },
-      onPersisted: async () => {
-        throw new Error("db down");
-      },
-      logger,
-    });
-    expect(logger.warns.some((w) => w.includes("onPersisted callback failed"))).toBe(true);
-  });
+  // Embed/upsert/onPersisted error-branch coverage lives in
+  // embed-changelog-pipeline.test.ts — the same swallow-and-log contract
+  // applies across all three pipelines.
 });

packages/search/src/embed-releases.test.ts

@@ -24,16 +24,11 @@ function fakeVoyageFetch() {
   return { fetchImpl, calls };
 }
 
-function fakeVectorize(
-  opts: {
-    upsertThrows?: boolean;
-  } = {},
-) {
+function fakeVectorize() {
   const upserted: any[] = [];
   const deleted: string[] = [];
   const index: VectorizeIndex = {
     async upsert(v: any[]) {
-      if (opts.upsertThrows) throw new Error("vectorize boom");
       upserted.push(...v);
       return { mutationId: "m1" };
     },
@@ -48,17 +43,6 @@ function fakeVectorize(
   return { index, upserted, deleted };
 }
 
-function captureLogger() {
-  const warns: string[] = [];
-  const errors: string[] = [];
-  return {
-    warn: (...args: unknown[]) => warns.push(args.map(String).join(" ")),
-    error: (...args: unknown[]) => errors.push(args.map(String).join(" ")),
-    warns,
-    errors,
-  };
-}
-
 const baseRelease: EmbedReleaseInput = {
   id: "rel_1",
   title: "v1.0",
@@ -160,59 +144,9 @@ describe("embedAndUpsertReleases", () => {
     expect(meta.release_type).toBe("feature");
   });
 
-  test("embedding failure → logs, does NOT throw, does NOT call onPersisted", async () => {
-    const fetchImpl = (async () =>
-      new Response("nope", { status: 400 })) as unknown as typeof fetch;
-    const vec = fakeVectorize();
-    const logger = captureLogger();
-    let persistedCalled = false;
-    await embedAndUpsertReleases({
-      releases: [baseRelease],
-      vectorIndex: vec.index,
-      embedConfig: { provider: "voyage", apiKey: "k", fetchImpl, maxRetries: 0 },
-      onPersisted: async () => {
-        persistedCalled = true;
-      },
-      logger,
-    });
-    expect(vec.upserted.length).toBe(0);
-    expect(persistedCalled).toBe(false);
-    expect(logger.warns.some((w) => w.includes("embed pipeline failed"))).toBe(true);
-  });
-
-  test("upsert failure → logs, does NOT throw, does NOT call onPersisted", async () => {
-    const { fetchImpl } = fakeVoyageFetch();
-    const vec = fakeVectorize({ upsertThrows: true });
-    const logger = captureLogger();
-    let persistedCalled = false;
-    await embedAndUpsertReleases({
-      releases: [baseRelease],
-      vectorIndex: vec.index,
-      embedConfig: { provider: "voyage", apiKey: "k", fetchImpl },
-      onPersisted: async () => {
-        persistedCalled = true;
-      },
-      logger,
-    });
-    expect(persistedCalled).toBe(false);
-    expect(logger.warns.some((w) => w.includes("Vectorize upsert failed"))).toBe(true);
-  });
-
-  test("onPersisted callback failure is caught and logged", async () => {
-    const { fetchImpl } = fakeVoyageFetch();
-    const vec = fakeVectorize();
-    const logger = captureLogger();
-    await embedAndUpsertReleases({
-      releases: [baseRelease],
-      vectorIndex: vec.index,
-      embedConfig: { provider: "voyage", apiKey: "k", fetchImpl },
-      onPersisted: async () => {
-        throw new Error("db down");
-      },
-      logger,
-    });
-    expect(logger.warns.some((w) => w.includes("onPersisted callback failed"))).toBe(true);
-  });
+  // Embed/upsert/onPersisted error-branch coverage lives in
+  // embed-changelog-pipeline.test.ts — the same swallow-and-log contract
+  // applies across all three pipelines.
 
   test("multi-release batch: ids in order, each gets its own vector slot", async () => {
     const { fetchImpl } = fakeVoyageFetch();

tests/api/changelog-route.test.ts

@@ -1,5 +1,8 @@
 import { describe, it, expect, beforeAll, afterAll } from "bun:test";
-import { buildChangelogResponse } from "@buildinternet/releases-core/changelog-slice";
+import {
+  buildChangelogResponse,
+  selectChangelogFile,
+} from "@buildinternet/releases-core/changelog-slice";
 import { createTestDb, type TestDatabase } from "../db-helper.js";
 import { eq } from "drizzle-orm";
 import {
@@ -9,35 +12,16 @@ import {
   type SourceChangelogFile,
 } from "@buildinternet/releases-core/schema";
 
-// This test mirrors the server-side logic of `handleSourceChangelog`
-// (src/api/routes/sources.ts) and `GET /v1/sources/:slug/changelog` in
-// workers/api/src/routes/sources.ts without going through the getDb()
-// singleton — both handlers share the same resolution rules:
-//   - omitted path → prefer root CHANGELOG.md, fall back to first by path
-//   - unknown path → 404 sentinel
-//   - known path → return that row
-//   - response carries `files` index + `truncated` flag
-// Touching the singleton requires resetting mode.ts caches, which is
-// brittle across parallel test files.
+// This test exercises the response-building path used by both
+// `handleSourceChangelog` (src/api/routes/sources.ts) and
+// `GET /v1/sources/:slug/changelog` (workers/api/src/routes/sources.ts).
+// It uses the canonical `selectChangelogFile` from the core package to pick
+// the row, then asserts on the `buildChangelogResponse` output — the part
+// that's unique to the worker layer. The not-found sentinels are covered
+// by the core package's own tests.
 
 const MB = 1024 * 1024;
 
-type ChangelogSelectResult = "not_found_source" | "not_found_path" | SourceChangelogFile;
-
-function selectChangelog(
-  allRows: SourceChangelogFile[],
-  requestedPath: string | null,
-): ChangelogSelectResult {
-  if (allRows.length === 0) return "not_found_source";
-  if (requestedPath) {
-    const match = allRows.find((r) => r.path === requestedPath);
-    if (!match) return "not_found_path";
-    return match;
-  }
-  const root = allRows.find((r) => !r.path.includes("/"));
-  return root ?? allRows[0];
-}
-
 let tdb: TestDatabase;
 let sourceId: string;
 
@@ -104,22 +88,24 @@ function buildFiles(rows: SourceChangelogFile[]) {
   }));
 }
 
+function selectOrFail(rows: SourceChangelogFile[], path: string | null): SourceChangelogFile {
+  const selected = selectChangelogFile(rows, path);
+  if (!selected) throw new Error("expected row");
+  return selected;
+}
+
 describe("source changelog route resolution", () => {
   it("returns the root file when path is omitted", () => {
     const rows = fetchAll();
-    const selected = selectChangelog(rows, null);
-    expect(selected).not.toBe("not_found_source");
-    expect(selected).not.toBe("not_found_path");
-    if (typeof selected === "string") return;
+    const selected = selectOrFail(rows, null);
     const res = buildChangelogResponse(selected, { offset: null, limit: null }, buildFiles(rows));
     expect(res.path).toBe("CHANGELOG.md");
     expect(res.truncated).toBe(false);
   });
 
   it("includes a files index for every tracked file", () => {
     const rows = fetchAll();
-    const selected = selectChangelog(rows, null);
-    if (typeof selected === "string") throw new Error("expected row");
+    const selected = selectOrFail(rows, null);
     const res = buildChangelogResponse(selected, { offset: null, limit: null }, buildFiles(rows));
     expect(res.files.map((f) => f.path).toSorted()).toEqual([
       "CHANGELOG.md",
@@ -133,36 +119,23 @@ describe("source changelog route resolution", () => {
 
   it("resolves path=<known> to the requested file", () => {
     const rows = fetchAll();
-    const selected = selectChangelog(rows, "packages/alpha/CHANGELOG.md");
-    if (typeof selected === "string") throw new Error("expected row");
+    const selected = selectOrFail(rows, "packages/alpha/CHANGELOG.md");
     const res = buildChangelogResponse(selected, { offset: null, limit: null }, buildFiles(rows));
     expect(res.path).toBe("packages/alpha/CHANGELOG.md");
     expect(res.content).toBe("# alpha\n");
   });
 
-  it("returns not_found_path for an unknown path", () => {
-    const rows = fetchAll();
-    const selected = selectChangelog(rows, "packages/missing/CHANGELOG.md");
-    expect(selected).toBe("not_found_path");
-  });
-
   it("flags truncated=true when bytes === 1MB", () => {
     const rows = fetchAll();
-    const selected = selectChangelog(rows, "packages/huge/CHANGELOG.md");
-    if (typeof selected === "string") throw new Error("expected row");
+    const selected = selectOrFail(rows, "packages/huge/CHANGELOG.md");
     const res = buildChangelogResponse(selected, { offset: null, limit: null }, buildFiles(rows));
     expect(res.truncated).toBe(true);
     expect(res.truncatedAt).toBe(MB);
   });
 
-  it("returns not_found_source for empty row set", () => {
-    expect(selectChangelog([], null)).toBe("not_found_source");
-  });
-
   it("falls back to live encoding when row.tokens is null", () => {
     const rows = fetchAll();
-    const selected = selectChangelog(rows, "CHANGELOG.md");
-    if (typeof selected === "string") throw new Error("expected row");
+    const selected = selectOrFail(rows, "CHANGELOG.md");
     const res = buildChangelogResponse(
       { ...selected, tokens: null },
       { offset: null, limit: null },
@@ -175,8 +148,7 @@ describe("source changelog route resolution", () => {
 
   it("honors the tokens range param end-to-end through buildChangelogResponse", () => {
     const rows = fetchAll();
-    const selected = selectChangelog(rows, "CHANGELOG.md");
-    if (typeof selected === "string") throw new Error("expected row");
+    const selected = selectOrFail(rows, "CHANGELOG.md");
     const res = buildChangelogResponse(
       selected,
       { offset: null, limit: null, tokens: "100" },

tests/api/log-search.test.ts

@@ -80,25 +80,15 @@ describe("prepareSearchLogRow", () => {
 });
 
 describe("prepareMcpSearchLogRow", () => {
-  it("defaults the types array to the command name", () => {
+  // Generic shape (truncation, blank check, mode validation) is covered by
+  // prepareSearchLogRow above. The MCP variant only adds one unique branch:
+  // the `types` array defaults to the command name when not supplied.
+  it("defaults the types array to the command name and pins surface=mcp", () => {
     const row = prepareMcpSearchLogRow({
       command: "search",
       query: "vercel",
     });
     expect(row!.types).toBe(JSON.stringify(["search"]));
     expect(row!.surface).toBe("mcp");
   });
-
-  it("preserves an explicit types array", () => {
-    const row = prepareMcpSearchLogRow({
-      command: "search_releases",
-      query: "vercel",
-      types: ["search_releases", "releases"],
-    });
-    expect(row!.types).toBe(JSON.stringify(["search_releases", "releases"]));
-  });
-
-  it("returns null for blank queries", () => {
-    expect(prepareMcpSearchLogRow({ command: "search", query: " " })).toBeNull();
-  });
 });

tests/api/middleware.test.ts

@@ -154,12 +154,6 @@ describe("cacheControl", () => {
     expect(res.headers.get("Cache-Control")).toBe("public, max-age=120");
   });
 
-  it("uses private visibility by default", async () => {
-    const { app, env } = createApp(60);
-    const res = await app.request("/test", { method: "GET" }, env);
-    expect(res.headers.get("Cache-Control")).toContain("private");
-  });
-
   it("skips caching when CACHE_DISABLED is set", async () => {
     const { app } = createApp(60);
     const res = await app.request("/test", { method: "GET" }, { CACHE_DISABLED: "1" });

tests/unit/hash.test.ts

@@ -7,14 +7,6 @@ describe("sha256Hex", () => {
     expect(result).toMatch(/^[a-f0-9]{64}$/);
   });
 
-  it("returns deterministic results", () => {
-    expect(sha256Hex("test")).toBe(sha256Hex("test"));
-  });
-
-  it("returns different hashes for different inputs", () => {
-    expect(sha256Hex("a")).not.toBe(sha256Hex("b"));
-  });
-
   it("handles empty string", () => {
     const result = sha256Hex("");
     expect(result).toMatch(/^[a-f0-9]{64}$/);