fix: bad input validation for download base url

Author: fallard84

action/dist/main.js

@@ -19864,7 +19864,7 @@ function parseInputs() {
   const agentDownloadBaseURL = formatUrlWithTrailingSlash(
     core.getInput("_agent-download-base-url")
   );
-  if (!agentDownloadBaseURL) {
+  if (!agentDownloadBaseURL && !localAgent) {
     throw new Error(`_agent-download-base-url cannot be empty`);
   }
   return {
@@ -19952,6 +19952,7 @@ async function installAgent({
     await downloadAgent({
       actionDirectory,
       agentDirectory,
+      // Input validation will ensure there is a value when localAgent = false
       agentDownloadBaseURL,
       version
     });

action/dist/main.js.map

@@ -19876,7 +19876,7 @@ function parseInputs() {
   const agentDownloadBaseURL = formatUrlWithTrailingSlash(
     core.getInput("_agent-download-base-url")
   );
-  if (!agentDownloadBaseURL) {
+  if (!agentDownloadBaseURL && !localAgent) {
     throw new Error(`_agent-download-base-url cannot be empty`);
   }
   return {

action/dist/post.js

@@ -13,7 +13,7 @@ export interface Inputs {
   egressPolicy: EgressPolicy;
   localAgent: boolean;
   logDirectory: string;
-  agentDownloadBaseURL: string;
+  agentDownloadBaseURL?: string;
   agentVersion?: string;
   controlPlaneApiBaseUrl?: string;
   controlPlaneWebappBaseUrl?: string;

action/dist/post.js.map

@@ -65,15 +65,16 @@ async function installAgent({
   agentDirectory: string;
   localAgent: boolean;
   version: string;
-  agentDownloadBaseURL: string;
+  agentDownloadBaseURL?: string;
 }): Promise<void> {
   if (localAgent) {
     await copyLocalAgent({ agentDirectory });
   } else {
     await downloadAgent({
       actionDirectory,
       agentDirectory,
-      agentDownloadBaseURL,
+      // Input validation will ensure there is a value when localAgent = false
+      agentDownloadBaseURL: agentDownloadBaseURL!,
       version,
     });
   }