Skip to content

Commit 8089b5e

Browse files
committed
feat: restrict default allowed domains (#217)
The agent used to allow github.com, api.github.com and *.blob.core.windows.net by default as a convenience. Given these domains allow anyone to easily use as exfiltration destination, Bullfrog egress filtering could be easily bypass in jobs, even when egress to github wasn't required. This is a breaking change because some users might have use bullfrog in jobs that require egress to github.com or api.github.com without the domains being explicitly allowed. After this change, github.com and api.github.com will need to be explicitly allowed in bullfrog.
1 parent 9a8b7b2 commit 8089b5e

2 files changed

Lines changed: 26 additions & 3 deletions

File tree

agent/agent.go

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,31 @@ import (
1414
)
1515

1616
var (
17-
blocking = false
18-
defaultDomains = []string{"github.com", "api.github.com", "*.actions.githubusercontent.com", "results-receiver.actions.githubusercontent.com", "*.blob.core.windows.net", "*.githubapp.com"}
17+
blocking = false
18+
defaultDomains = []string{
19+
"*.actions.githubusercontent.com",
20+
"*.githubapp.com",
21+
"glb-*.github.qkg1.top",
22+
"productionresultssa1.blob.core.windows.net",
23+
"productionresultssa2.blob.core.windows.net",
24+
"productionresultssa3.blob.core.windows.net",
25+
"productionresultssa4.blob.core.windows.net",
26+
"productionresultssa5.blob.core.windows.net",
27+
"productionresultssa6.blob.core.windows.net",
28+
"productionresultssa7.blob.core.windows.net",
29+
"productionresultssa8.blob.core.windows.net",
30+
"productionresultssa9.blob.core.windows.net",
31+
"productionresultssa10.blob.core.windows.net",
32+
"productionresultssa11.blob.core.windows.net",
33+
"productionresultssa12.blob.core.windows.net",
34+
"productionresultssa13.blob.core.windows.net",
35+
"productionresultssa14.blob.core.windows.net",
36+
"productionresultssa15.blob.core.windows.net",
37+
"productionresultssa16.blob.core.windows.net",
38+
"productionresultssa17.blob.core.windows.net",
39+
"productionresultssa18.blob.core.windows.net",
40+
"productionresultssa19.blob.core.windows.net",
41+
}
1942
defaultIps = []string{"168.63.129.16", "169.254.169.254", "127.0.0.1"}
2043
defaultDNSServers = []string{"127.0.0.53"}
2144
)

agent/agent.sha256

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
72fdea56ef365e362fd5ae69c1d5866fc4636db4e8e4aa10855d158d3f5e439f agent
1+
b6f598a15855507d5c95bf2b047cd1a0210a1fb1fecf2fc63fefdf8d4cb48c63 agent

0 commit comments

Comments
 (0)