fix: Now world error failing to parse

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>

Author: GordonSmith

src/errorParser.ts

@@ -3,17 +3,22 @@
  */
 
 /**
- * Regex pattern to extract error information from WIT validation errors
- * Groups:
- * 1. Main error message (after "Error: ")
- * 2. Detailed error message (after "Caused by:")
- * 3. File path (from the arrow line)
- * 4. Row number
- * 5. Column number
+ * Regex patterns to extract error information from WIT validation errors
  */
-const witErrorRegex =
+
+/**
+ * Pattern for errors with file location information
+ * Groups: 1=main error, 2=detailed error, 3=file path, 4=row, 5=column
+ */
+const witErrorWithLocationRegex =
     /Error:\s*([^\n]+)(?:\n\nCaused by:\s*\n\s*([^\n]+(?:\n[^\n-]+)*?))?[\s\S]*?-->\s*([^:]+):(\d+):(\d+)/;
 
+/**
+ * Pattern for errors without file location information
+ * Groups: 1=main error
+ */
+const witErrorWithoutLocationRegex = /Error:\s*([^\n]+)/;
+
 /**
  * Extracts error information from a WIT validation error stack trace
  * @param errorStack - The error stack trace string
@@ -26,19 +31,33 @@ export function extractErrorInfo(errorStack: string): {
     row?: number;
     column?: number;
 } | null {
-    const match = errorStack.match(witErrorRegex);
+    // First try to match errors with file location
+    let match = errorStack.match(witErrorWithLocationRegex);
 
-    if (!match) {
-        return null;
+    if (match) {
+        const [, mainError, detailedError, filePath, rowStr, columnStr] = match;
+        return {
+            mainError: mainError.trim(),
+            detailedError: detailedError?.trim(),
+            filePath: filePath.trim(),
+            row: parseInt(rowStr, 10),
+            column: parseInt(columnStr, 10),
+        };
     }
 
-    const [, mainError, detailedError, filePath, rowStr, columnStr] = match;
+    // If no location match, try simple error format
+    match = errorStack.match(witErrorWithoutLocationRegex);
+
+    if (match) {
+        const [, mainError] = match;
+        return {
+            mainError: mainError.trim(),
+            detailedError: undefined,
+            filePath: undefined,
+            row: undefined,
+            column: undefined,
+        };
+    }
 
-    return {
-        mainError: mainError.trim(),
-        detailedError: detailedError?.trim(),
-        filePath: filePath.trim(),
-        row: parseInt(rowStr, 10),
-        column: parseInt(columnStr, 10),
-    };
+    return null;
 }

tests/errorParser.test.ts

@@ -32,6 +32,13 @@ Caused by:
 	at async syntaxCheckCurrentFile (/home/gordon/vscode-wit/dist/extension.js:152:21)
 	at async /home/gordon/vscode-wit/dist/extension.js:142:5
 	at async Xb.h (file:///home/gordon/.vscode-server/bin/dfaf44141ea9deb3b4096f7cd6d24e00c147a4b1/out/vs/workbench/api/node/extensionHostProcess.js:120:41516)`,
+    `Error: The main package \`test:comments\` contains no worlds
+	at generateTypes (file:///home/gordon/vscode-wit/dist/extension.js:28632:11)
+	at typesComponent (file:///home/gordon/vscode-wit/dist/extension.js:28853:14)
+	at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
+	at async WitSyntaxValidator.validate (file:///home/gordon/vscode-wit/dist/extension.js:28933:7)
+	at async syntaxCheckCurrentFile (file:///home/gordon/vscode-wit/dist/extension.js:29078:23)
+	at async file:///home/gordon/vscode-wit/dist/extension.js:29046:9`,
 ];
 
 describe("WIT Error Parser", () => {
@@ -62,6 +69,17 @@ describe("WIT Error Parser", () => {
             expect(result?.column).toBe(1);
         });
 
+        it("should extract error info from third sample stack (error without file location)", () => {
+            const result = extractErrorInfo(testSampleStacks[2]);
+
+            expect(result).not.toBeNull();
+            expect(result?.mainError).toBe("The main package `test:comments` contains no worlds");
+            expect(result?.detailedError).toBeUndefined();
+            expect(result?.filePath).toBeUndefined();
+            expect(result?.row).toBeUndefined();
+            expect(result?.column).toBeUndefined();
+        });
+
         it("should return null for invalid error stack", () => {
             const invalidStack = "This is not a valid WIT error stack";
             const result = extractErrorInfo(invalidStack);
@@ -153,20 +171,30 @@ Caused by:
 
                 // Verify the extracted information is reasonable
                 expect(result?.mainError?.length, "Main error should not be empty").toBeGreaterThan(0);
-                expect(result?.detailedError?.length, "Detailed error should not be empty").toBeGreaterThan(0);
-                expect(result?.filePath, "File path should contain .wit").toContain(".wit");
-                expect(result?.row, "Row should be positive").toBeGreaterThan(0);
-                expect(result?.column, "Column should be positive").toBeGreaterThan(0);
-
-                // Check specific expected values
-                if (index === 0) {
-                    expect(result?.filePath).toContain("floats.wit");
-                } else if (index === 1) {
-                    expect(result?.filePath).toContain("integers.wit");
-                }
 
-                expect(result?.row).toBe(3);
-                expect(result?.column).toBe(1);
+                if (index < 2) {
+                    // First two samples have detailed error and file location
+                    expect(result?.detailedError?.length, "Detailed error should not be empty").toBeGreaterThan(0);
+                    expect(result?.filePath, "File path should contain .wit").toContain(".wit");
+                    expect(result?.row, "Row should be positive").toBeGreaterThan(0);
+                    expect(result?.column, "Column should be positive").toBeGreaterThan(0);
+
+                    // Check specific expected values
+                    if (index === 0) {
+                        expect(result?.filePath).toContain("floats.wit");
+                    } else if (index === 1) {
+                        expect(result?.filePath).toContain("integers.wit");
+                    }
+
+                    expect(result?.row).toBe(3);
+                    expect(result?.column).toBe(1);
+                } else {
+                    // Third sample has no detailed error or file location
+                    expect(result?.detailedError).toBeUndefined();
+                    expect(result?.filePath).toBeUndefined();
+                    expect(result?.row).toBeUndefined();
+                    expect(result?.column).toBeUndefined();
+                }
             });
         });
     });