c-api: Fix reference to wasmtime_config_concurrency_support without ifdef - #13419
Closed
leonm1 wants to merge 1 commit into
Closed
c-api: Fix reference to wasmtime_config_concurrency_support without ifdef#13419leonm1 wants to merge 1 commit into
leonm1 wants to merge 1 commit into
Conversation
Signed-off-by: Matt Leon <mattleon@google.com>
Author
|
Ah, this was fixed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When updating wasmtime in github.com/proxy-wasm/proxy-wasm-cpp-host (which is now using the C++ API), I noticed that this config setting, introduced in #12703, is behind an
#ifdefin the c-api, but not in the C++ API. This produces a link-time error when using the c++ API without the concurrency-support feature.